mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-09 01:10:24 +00:00
9dac77fdc2
Registration omitted `userVerification`, so Chromium raised the credential to credProtect level 3 and the authenticator then hid it from the second-factor login, which asked for `discouraged`. Registration and each login now set their own value, with `preferred` on the second factor so credentials already registered at level 3 keep working without re-enrollment. Also add relevant e2e test coverage for webauthn, one test chromium only because Firefox lacks the APIs needed. Fixes https://github.com/go-gitea/gitea/issues/33531 Fixes https://github.com/go-gitea/gitea/issues/36019 Fixes https://github.com/go-gitea/gitea/issues/38139
78 lines
2.1 KiB
Go
78 lines
2.1 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package webauthn
|
|
|
|
import (
|
|
"context"
|
|
"encoding/binary"
|
|
"encoding/gob"
|
|
|
|
"gitea.dev/models/auth"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/util"
|
|
|
|
"github.com/go-webauthn/webauthn/protocol"
|
|
"github.com/go-webauthn/webauthn/webauthn"
|
|
)
|
|
|
|
// WebAuthn represents the global WebAuthn instance
|
|
var WebAuthn *webauthn.WebAuthn
|
|
|
|
// Init initializes the WebAuthn instance from the config.
|
|
func Init() {
|
|
gob.Register(&webauthn.SessionData{}) // TODO: CHI-SESSION-GOB-REGISTER.
|
|
|
|
appURL, _ := protocol.FullyQualifiedOrigin(setting.AppURL)
|
|
|
|
WebAuthn = &webauthn.WebAuthn{
|
|
Config: &webauthn.Config{
|
|
RPDisplayName: setting.AppName,
|
|
RPID: setting.Domain,
|
|
RPOrigins: []string{appURL},
|
|
AttestationPreference: protocol.PreferNoAttestation, // Gitea never verifies attestation
|
|
},
|
|
}
|
|
}
|
|
|
|
// user represents an implementation of webauthn.User based on User model
|
|
type user struct {
|
|
ctx context.Context
|
|
User *user_model.User
|
|
|
|
defaultAuthFlags protocol.AuthenticatorFlags
|
|
}
|
|
|
|
var _ webauthn.User = (*user)(nil)
|
|
|
|
func NewWebAuthnUser(ctx context.Context, u *user_model.User, defaultAuthFlags ...protocol.AuthenticatorFlags) webauthn.User {
|
|
return &user{ctx: ctx, User: u, defaultAuthFlags: util.OptionalArg(defaultAuthFlags)}
|
|
}
|
|
|
|
// WebAuthnID implements the webauthn.User interface
|
|
func (u *user) WebAuthnID() []byte {
|
|
id := make([]byte, 8)
|
|
binary.PutVarint(id, u.User.ID)
|
|
return id
|
|
}
|
|
|
|
// WebAuthnName implements the webauthn.User interface
|
|
func (u *user) WebAuthnName() string {
|
|
return util.IfZero(u.User.LoginName, u.User.Name)
|
|
}
|
|
|
|
// WebAuthnDisplayName implements the webauthn.User interface
|
|
func (u *user) WebAuthnDisplayName() string {
|
|
return u.User.DisplayName()
|
|
}
|
|
|
|
// WebAuthnCredentials implements the webauthn.User interface
|
|
func (u *user) WebAuthnCredentials() []webauthn.Credential {
|
|
dbCreds, err := auth.GetWebAuthnCredentialsByUID(u.ctx, u.User.ID)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
return dbCreds.ToCredentials(u.defaultAuthFlags)
|
|
}
|