mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-27 03:43:40 +00:00
Artem Lytkin
c8660364d9
With SIGNING_FORMAT = ssh the OpenPGP verification path builds its GPGSettings from the instance signing key but leaves the format empty, so it runs `gpg -a --export` on an SSH public key path. Depending on the local gpg setup that either exports nothing, so an OpenPGP signed commit reports gpg.error.generate_hash instead of a missing key, or it fails outright and logs an export error for every such commit. Both guards are needed. The first covers SIGNING_KEY set to a path with SIGNING_FORMAT=ssh; the second covers the shipped default SIGNING_KEY=default, where the format comes from git's own gpg.format and never gets reconciled with the hardcoded "openpgp". Drop either one and a working config goes back to broken. Also raise minimum git version to 2.18 which was already required before this change. Fixes: https://github.com/go-gitea/gitea/issues/37452 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
60 lines
1.2 KiB
Go
60 lines
1.2 KiB
Go
// Copyright 2015 The Gogs Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"crypto/sha1"
|
|
"encoding/hex"
|
|
"strings"
|
|
"sync"
|
|
|
|
"gitea.dev/modules/util"
|
|
)
|
|
|
|
// ObjectCache provides thread-safe cache operations.
|
|
type ObjectCache[T any] struct {
|
|
lock sync.RWMutex
|
|
cache map[string]T
|
|
}
|
|
|
|
func newObjectCache[T any]() *ObjectCache[T] {
|
|
return &ObjectCache[T]{cache: make(map[string]T, 10)}
|
|
}
|
|
|
|
// Set adds obj to cache
|
|
func (oc *ObjectCache[T]) Set(id string, obj T) {
|
|
oc.lock.Lock()
|
|
defer oc.lock.Unlock()
|
|
|
|
oc.cache[id] = obj
|
|
}
|
|
|
|
// Get gets cached obj by id
|
|
func (oc *ObjectCache[T]) Get(id string) (T, bool) {
|
|
oc.lock.RLock()
|
|
defer oc.lock.RUnlock()
|
|
|
|
obj, has := oc.cache[id]
|
|
return obj, has
|
|
}
|
|
|
|
func HashFilePathForWebUI(s string) string {
|
|
h := sha1.New()
|
|
_, _ = h.Write([]byte(s))
|
|
return hex.EncodeToString(h.Sum(nil))
|
|
}
|
|
|
|
func SplitCommitTitleBody(commitMessage string, titleRuneLimit int) (title, body string) {
|
|
title, body, _ = strings.Cut(commitMessage, "\n")
|
|
title, title2 := util.EllipsisTruncateRunes(title, titleRuneLimit)
|
|
if title2 != "" {
|
|
if body == "" {
|
|
body = title2
|
|
} else {
|
|
body = title2 + "\n" + body
|
|
}
|
|
}
|
|
return title, body
|
|
}
|