mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-14 07:42:59 +00:00
bircni
01e9febbea
`github.event.inputs` must mirror the raw `workflow_dispatch` payload, where GitHub keeps every input as a string. Only the separate `inputs` context preserves declared types, e.g. booleans. A previous fix coerced boolean inputs in the single map that fed both contexts, so `github.event.inputs.someBool` became a real boolean and comparisons like `== 'true'` stopped matching. `github.event.inputs` now stays string-only again. The `inputs` context used for server-side `if:` evaluation of needs-gated/matrix-deferred jobs re-coerces booleans independently, from the job's own workflow declaration, so that path keeps working correctly. Fixes https://github.com/go-gitea/gitea/issues/38896 --------- Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
87 lines
3.6 KiB
Go
87 lines
3.6 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
act_model "gitea.dev/actionslib/pkg/model"
|
|
actions_model "gitea.dev/models/actions"
|
|
"gitea.dev/modules/actions/jobparser"
|
|
"gitea.dev/modules/setting"
|
|
|
|
"go.yaml.in/yaml/v4"
|
|
)
|
|
|
|
// EvaluateRunConcurrencyFillModel evaluates the expressions in a run-level (workflow) concurrency,
|
|
// and fills the run attempt model with the evaluated `concurrency.group` and `concurrency.cancel-in-progress` values.
|
|
// Workflow-level concurrency doesn't depend on the job outputs, so it can always be evaluated if there is no syntax error.
|
|
// Callers must resolve `inputs`, there is no job in scope here to read `on: workflow_dispatch` from.
|
|
// See https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#concurrency
|
|
func EvaluateRunConcurrencyFillModel(ctx context.Context, run *actions_model.ActionRun, attempt *actions_model.ActionRunAttempt, wfRawConcurrency *act_model.RawConcurrency, vars map[string]string, inputs map[string]any) error {
|
|
if err := run.LoadAttributes(ctx); err != nil {
|
|
return fmt.Errorf("run LoadAttributes: %w", err)
|
|
}
|
|
|
|
actionsRunCtx := GenerateGiteaContext(ctx, run, attempt, nil)
|
|
jobResults := map[string]*jobparser.JobResult{"": {}}
|
|
if inputs == nil {
|
|
if run.Event == "workflow_dispatch" {
|
|
setting.PanicInDevOrTesting("run %d: workflow_dispatch inputs must be resolved by the caller", run.ID)
|
|
}
|
|
inputs = map[string]any{}
|
|
}
|
|
|
|
var err error
|
|
attempt.ConcurrencyGroup, attempt.ConcurrencyCancel, err = jobparser.EvaluateConcurrency(wfRawConcurrency, "", nil, actionsRunCtx, jobResults, vars, inputs)
|
|
if err != nil {
|
|
return fmt.Errorf("evaluate concurrency: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// EvaluateJobConcurrencyFillModel evaluates the expressions in a job-level concurrency,
|
|
// and fills the job's model fields with `concurrency.group` and `concurrency.cancel-in-progress`.
|
|
// Job-level concurrency may depend on other job's outputs (via `needs`): `concurrency.group: my-group-${{ needs.job1.outputs.out1 }}`
|
|
// If the needed jobs haven't been executed yet, this evaluation will also fail.
|
|
// See https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idconcurrency
|
|
func EvaluateJobConcurrencyFillModel(ctx context.Context, run *actions_model.ActionRun, attempt *actions_model.ActionRunAttempt, actionRunJob *actions_model.ActionRunJob, vars map[string]string, inputs map[string]any) error {
|
|
if err := actionRunJob.LoadAttributes(ctx); err != nil {
|
|
return fmt.Errorf("job LoadAttributes: %w", err)
|
|
}
|
|
|
|
var rawConcurrency act_model.RawConcurrency
|
|
if err := yaml.Unmarshal([]byte(actionRunJob.RawConcurrency), &rawConcurrency); err != nil {
|
|
return fmt.Errorf("unmarshal raw concurrency: %w", err)
|
|
}
|
|
|
|
actionsJobCtx := GenerateGiteaContext(ctx, run, attempt, actionRunJob)
|
|
|
|
jobResults, err := findJobNeedsAndFillJobResults(ctx, actionRunJob)
|
|
if err != nil {
|
|
return fmt.Errorf("find job needs and fill job results: %w", err)
|
|
}
|
|
|
|
if inputs == nil {
|
|
var err error
|
|
inputs, err = getInputsForJob(ctx, run, actionRunJob)
|
|
if err != nil {
|
|
return fmt.Errorf("get inputs: %w", err)
|
|
}
|
|
}
|
|
|
|
workflowJob, err := actionRunJob.ParseJob()
|
|
if err != nil {
|
|
return fmt.Errorf("load job %d: %w", actionRunJob.ID, err)
|
|
}
|
|
|
|
actionRunJob.ConcurrencyGroup, actionRunJob.ConcurrencyCancel, err = jobparser.EvaluateConcurrency(&rawConcurrency, actionRunJob.JobID, workflowJob, actionsJobCtx, jobResults, vars, inputs)
|
|
if err != nil {
|
|
return fmt.Errorf("evaluate concurrency: %w", err)
|
|
}
|
|
actionRunJob.IsConcurrencyEvaluated = true
|
|
return nil
|
|
}
|