fix(actions): allow larger scheduled workflows (#38985)

MySQL stores `action_schedule.content` as `BLOB`, limiting scheduled
workflow definitions to 65,535 bytes. Oversized workflows fail schedule
refresh and can also suppress default-branch push handling.

Store scheduled workflow content as `LONGBLOB`, migrate existing MySQL
columns, and cover the migration by persisting 65,536 bytes.

Fixes https://github.com/go-gitea/gitea/issues/38613
This commit is contained in:
Julian Scholle
2026-08-21 01:06:44 +02:00
committed by GitHub
parent ffd982c7ab
commit fe567d26c1
4 changed files with 79 additions and 2 deletions
+1
View File
@@ -422,6 +422,7 @@ func prepareMigrationTasks() []*migration {
newMigration(346, "Add license_path column to repo_license and backfill", v28.AddLicensePathToRepoLicense),
newMigration(347, "Add watch options", v28.AddWatchOptions),
newMigration(348, "Recreate email_hash table for SHA256 avatar hashes", v28.RecreateEmailHashTable),
newMigration(349, "Expand action_schedule content column", v28.ExpandActionScheduleContent),
}
return preparedMigrations
}
+29
View File
@@ -0,0 +1,29 @@
// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package v28
import (
"context"
"gitea.dev/modelmigration/base"
"gitea.dev/modules/setting"
"xorm.io/xorm/schemas"
)
func ExpandActionScheduleContent(ctx context.Context, x base.EngineMigration) error {
if !setting.Database.Type.IsMySQL() {
return nil
}
return base.ModifyColumn(ctx, x, "action_schedule", &schemas.Column{
Name: "content",
SQLType: schemas.SQLType{
Name: "LONGBLOB",
},
Length: 0,
Nullable: true,
DefaultIsEmpty: true,
})
}
+47
View File
@@ -0,0 +1,47 @@
// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package v28
import (
"bytes"
"testing"
"gitea.dev/modelmigration/migrationtest"
"gitea.dev/modules/setting"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestExpandActionScheduleContent(t *testing.T) {
if !setting.Database.Type.IsMySQL() {
t.Skip("Only MySQL limits BLOB columns to 65,535 bytes")
}
type ActionSchedule struct {
ID int64 `xorm:"pk autoincr"`
Content []byte `xorm:"BLOB"`
}
x, deferable := migrationtest.PrepareTestEnv(t, 0, new(ActionSchedule))
defer deferable()
if x == nil || t.Failed() {
return
}
require.NoError(t, ExpandActionScheduleContent(t.Context(), x))
tables := migrationtest.LoadTableSchemasMap(t, x)
assert.Equal(t, "LONGBLOB", tables["action_schedule"].GetColumn("content").SQLType.Name)
content := bytes.Repeat([]byte("x"), 65_536)
_, err := x.Insert(&ActionSchedule{Content: content})
require.NoError(t, err)
var stored ActionSchedule
has, err := x.Get(&stored)
require.NoError(t, err)
require.True(t, has)
assert.Equal(t, content, stored.Content)
}
+2 -2
View File
@@ -30,8 +30,8 @@ type ActionSchedule struct {
Ref string
CommitSHA string
Event webhook_module.HookEventType
EventPayload string `xorm:"LONGTEXT"`
Content []byte
EventPayload string `xorm:"LONGTEXT"`
Content []byte `xorm:"LONGBLOB"`
Created timeutil.TimeStamp `xorm:"created"`
Updated timeutil.TimeStamp `xorm:"updated"`
}