James Braid 276a4b735a fix(oauth): don't wait for the browser opener to exit (#1093) ...

Fixes `tea login add --oauth` hanging after the user authenticates in the
browser.

`xdg-open` (at least on Debian) runs the browser in the foreground, so it does
not exit until the browser does. `open.Run` waits for it, so tea is blocked and
doesn't get the oAuth callback from the browser.

This only happens when `xdg-open` has to start the browser. With one already
running, the new process hands off and exits immediately.

`open.Start` launches the opener and returns. The test mocks `xdg-open` with a
script that holds the foreground and fails if `openBrowser` waits on it.

Reviewed-on: https://gitea.com/gitea/tea/pulls/1093
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: James Braid <jamesb@loreland.org>

2026-08-16 12:57:47 +00:00

..

oauth_test.go

fix(oauth): don't wait for the browser opener to exit (#1093)

2026-08-16 12:57:47 +00:00

oauth.go

fix(oauth): don't wait for the browser opener to exit (#1093)

2026-08-16 12:57:47 +00:00