From 3556e416125a2ade57a9be8e672b32642f914de6 Mon Sep 17 00:00:00 2001
From: Valentin Tolmer <valentin@tolmer.fr>
Date: Sat, 5 Apr 2025 01:24:38 -0500
Subject: [PATCH] server: flatten remaining files

---
 migration-tool/src/lldap.rs                   | 10 ++--
 server/src/{infra => }/auth_service.rs        |  2 +-
 server/src/{infra => }/cli.rs                 |  2 +-
 server/src/{infra => }/configuration.rs       |  2 +-
 server/src/{infra => }/database_string.rs     |  0
 server/src/{infra => }/db_cleaner.rs          |  0
 server/src/{infra => }/graphql_server.rs      |  2 +-
 server/src/{infra => }/healthcheck.rs         |  2 +-
 server/src/{infra => }/jwt_sql_tables.rs      |  0
 server/src/{infra => }/ldap_server.rs         |  2 +-
 server/src/{infra => }/logging.rs             |  2 +-
 server/src/{infra => }/mail.rs                |  2 +-
 server/src/main.rs                            | 51 +++++++++++--------
 server/src/{infra => }/mod.rs                 |  0
 server/src/{infra => }/schema.rs              |  0
 .../{infra => }/sql_tcp_backend_handler.rs    |  2 +-
 server/src/{infra => }/tcp_backend_handler.rs |  0
 server/src/{infra => }/tcp_server.rs          |  4 +-
 18 files changed, 47 insertions(+), 36 deletions(-)
 rename server/src/{infra => }/auth_service.rs (99%)
 rename server/src/{infra => }/cli.rs (99%)
 rename server/src/{infra => }/configuration.rs (99%)
 rename server/src/{infra => }/database_string.rs (100%)
 rename server/src/{infra => }/db_cleaner.rs (100%)
 rename server/src/{infra => }/graphql_server.rs (98%)
 rename server/src/{infra => }/healthcheck.rs (98%)
 rename server/src/{infra => }/jwt_sql_tables.rs (100%)
 rename server/src/{infra => }/ldap_server.rs (99%)
 rename server/src/{infra => }/logging.rs (97%)
 rename server/src/{infra => }/mail.rs (98%)
 rename server/src/{infra => }/mod.rs (100%)
 rename server/src/{infra => }/schema.rs (100%)
 rename server/src/{infra => }/sql_tcp_backend_handler.rs (99%)
 rename server/src/{infra => }/tcp_backend_handler.rs (100%)
 rename server/src/{infra => }/tcp_server.rs (98%)

diff --git a/migration-tool/src/lldap.rs b/migration-tool/src/lldap.rs
index 4320d59..300e339 100644
--- a/migration-tool/src/lldap.rs
+++ b/migration-tool/src/lldap.rs
@@ -88,7 +88,7 @@ impl User {
     query_path = "queries/create_user.graphql",
     response_derives = "Debug",
     variables_derives = "Debug,Clone",
-    custom_scalars_module = "crate::infra::graphql"
+    custom_scalars_module = "crate::graphql"
 )]
 struct CreateUser;
 
@@ -100,7 +100,7 @@ pub type CreateUserInput = create_user::CreateUserInput;
     query_path = "queries/create_group.graphql",
     response_derives = "Debug",
     variables_derives = "Debug,Clone",
-    custom_scalars_module = "crate::infra::graphql"
+    custom_scalars_module = "crate::graphql"
 )]
 struct CreateGroup;
 
@@ -109,7 +109,7 @@ struct CreateGroup;
     schema_path = "../schema.graphql",
     query_path = "queries/list_users.graphql",
     response_derives = "Debug",
-    custom_scalars_module = "crate::infra::graphql"
+    custom_scalars_module = "crate::graphql"
 )]
 struct ListUsers;
 
@@ -118,7 +118,7 @@ struct ListUsers;
     schema_path = "../schema.graphql",
     query_path = "queries/list_groups.graphql",
     response_derives = "Debug",
-    custom_scalars_module = "crate::infra::graphql"
+    custom_scalars_module = "crate::graphql"
 )]
 struct ListGroups;
 
@@ -364,7 +364,7 @@ pub fn get_lldap_groups(graphql_client: &GraphQLClient) -> Result<Vec<LldapGroup
     query_path = "queries/add_user_to_group.graphql",
     response_derives = "Debug",
     variables_derives = "Debug,Clone",
-    custom_scalars_module = "crate::infra::graphql"
+    custom_scalars_module = "crate::graphql"
 )]
 struct AddUserToGroup;
 
diff --git a/server/src/infra/auth_service.rs b/server/src/auth_service.rs
similarity index 99%
rename from server/src/infra/auth_service.rs
rename to server/src/auth_service.rs
index 836890a..e3719b4 100644
--- a/server/src/infra/auth_service.rs
+++ b/server/src/auth_service.rs
@@ -1,4 +1,4 @@
-use crate::infra::{
+use crate::{
     tcp_backend_handler::*,
     tcp_server::{AppState, TcpError, TcpResult, error_to_http_response},
 };
diff --git a/server/src/infra/cli.rs b/server/src/cli.rs
similarity index 99%
rename from server/src/infra/cli.rs
rename to server/src/cli.rs
index 43a8702..7ae7ab8 100644
--- a/server/src/infra/cli.rs
+++ b/server/src/cli.rs
@@ -6,7 +6,7 @@ use serde::{Deserialize, Serialize};
 use strum::{EnumString, IntoStaticStr};
 use url::Url;
 
-use crate::infra::database_string::DatabaseUrl;
+use crate::database_string::DatabaseUrl;
 
 // Can be deserialized from either a boolean or a string, to facilitate migration.
 #[derive(Copy, Clone, Debug, Serialize, Default, EnumString, IntoStaticStr)]
diff --git a/server/src/infra/configuration.rs b/server/src/configuration.rs
similarity index 99%
rename from server/src/infra/configuration.rs
rename to server/src/configuration.rs
index 0c82a82..8f51297 100644
--- a/server/src/infra/configuration.rs
+++ b/server/src/configuration.rs
@@ -1,4 +1,4 @@
-use crate::infra::{
+use crate::{
     cli::{
         GeneralConfigOpts, LdapsOpts, RunOpts, SmtpEncryption, SmtpOpts, TestEmailOpts,
         TrueFalseAlways,
diff --git a/server/src/infra/database_string.rs b/server/src/database_string.rs
similarity index 100%
rename from server/src/infra/database_string.rs
rename to server/src/database_string.rs
diff --git a/server/src/infra/db_cleaner.rs b/server/src/db_cleaner.rs
similarity index 100%
rename from server/src/infra/db_cleaner.rs
rename to server/src/db_cleaner.rs
diff --git a/server/src/infra/graphql_server.rs b/server/src/graphql_server.rs
similarity index 98%
rename from server/src/infra/graphql_server.rs
rename to server/src/graphql_server.rs
index c2701eb..65f7f72 100644
--- a/server/src/infra/graphql_server.rs
+++ b/server/src/graphql_server.rs
@@ -1,4 +1,4 @@
-use crate::infra::{auth_service::check_if_token_is_valid, tcp_server::AppState};
+use crate::{auth_service::check_if_token_is_valid, tcp_server::AppState};
 use actix_web::FromRequest;
 use actix_web::HttpMessage;
 use actix_web::{Error, HttpRequest, HttpResponse, error::JsonPayloadError, web};
diff --git a/server/src/infra/healthcheck.rs b/server/src/healthcheck.rs
similarity index 98%
rename from server/src/infra/healthcheck.rs
rename to server/src/healthcheck.rs
index 8ee4dfa..dda0cda 100644
--- a/server/src/infra/healthcheck.rs
+++ b/server/src/healthcheck.rs
@@ -1,4 +1,4 @@
-use crate::infra::{configuration::LdapsOptions, ldap_server::read_certificates};
+use crate::{configuration::LdapsOptions, ldap_server::read_certificates};
 use anyhow::{Context, Result, anyhow, bail, ensure};
 use futures_util::SinkExt;
 use ldap3_proto::{
diff --git a/server/src/infra/jwt_sql_tables.rs b/server/src/jwt_sql_tables.rs
similarity index 100%
rename from server/src/infra/jwt_sql_tables.rs
rename to server/src/jwt_sql_tables.rs
diff --git a/server/src/infra/ldap_server.rs b/server/src/ldap_server.rs
similarity index 99%
rename from server/src/infra/ldap_server.rs
rename to server/src/ldap_server.rs
index e3f3def..54233f1 100644
--- a/server/src/infra/ldap_server.rs
+++ b/server/src/ldap_server.rs
@@ -1,4 +1,4 @@
-use crate::infra::configuration::{Configuration, LdapsOptions};
+use crate::configuration::{Configuration, LdapsOptions};
 use actix_rt::net::TcpStream;
 use actix_server::ServerBuilder;
 use actix_service::{ServiceFactoryExt, fn_service};
diff --git a/server/src/infra/logging.rs b/server/src/logging.rs
similarity index 97%
rename from server/src/infra/logging.rs
rename to server/src/logging.rs
index 003d648..b28be36 100644
--- a/server/src/infra/logging.rs
+++ b/server/src/logging.rs
@@ -1,4 +1,4 @@
-use crate::infra::configuration::Configuration;
+use crate::configuration::Configuration;
 use actix_web::{
     Error,
     dev::{ServiceRequest, ServiceResponse},
diff --git a/server/src/infra/mail.rs b/server/src/mail.rs
similarity index 98%
rename from server/src/infra/mail.rs
rename to server/src/mail.rs
index fb68f1d..221ead2 100644
--- a/server/src/infra/mail.rs
+++ b/server/src/mail.rs
@@ -1,4 +1,4 @@
-use crate::infra::{cli::SmtpEncryption, configuration::MailOptions};
+use crate::{cli::SmtpEncryption, configuration::MailOptions};
 use anyhow::{Ok, Result, anyhow};
 use lettre::{
     AsyncSmtpTransport, AsyncTransport, Message, Tokio1Executor, message::Mailbox,
diff --git a/server/src/main.rs b/server/src/main.rs
index ec506ba..21a3d59 100644
--- a/server/src/main.rs
+++ b/server/src/main.rs
@@ -3,12 +3,26 @@
 // TODO: Remove next line when it stops warning about async functions.
 #![allow(clippy::blocks_in_conditions)]
 
-use crate::infra::{
-    cli::*,
+mod auth_service;
+mod cli;
+mod configuration;
+mod database_string;
+mod db_cleaner;
+mod graphql_server;
+mod healthcheck;
+mod jwt_sql_tables;
+mod ldap_server;
+mod logging;
+mod mail;
+mod sql_tcp_backend_handler;
+mod tcp_backend_handler;
+mod tcp_server;
+
+use crate::{
+    cli::{Command, RunOpts, TestEmailOpts},
     configuration::{Configuration, compare_private_key_hashes},
     database_string::DatabaseUrl,
     db_cleaner::Scheduler,
-    healthcheck, mail,
 };
 use actix::Actor;
 use actix_server::ServerBuilder;
@@ -28,8 +42,6 @@ use lldap_domain_handlers::handler::{
     UserListerBackendHandler, UserRequestFilter,
 };
 
-mod infra;
-
 const ADMIN_PASSWORD_MISSING_ERROR: &str = "The LDAP admin password must be initialized. \
             Either set the `ldap_user_pass` config value or the `LLDAP_LDAP_USER_PASS` environment variable. \
             A minimum of 8 characters is recommended.";
@@ -107,7 +119,7 @@ async fn setup_sql_tables(database_url: &DatabaseUrl) -> Result<DatabaseConnecti
     sql_tables::init_table(&sql_pool)
         .await
         .context("while creating base tables")?;
-    infra::jwt_sql_tables::init_table(&sql_pool)
+    jwt_sql_tables::init_table(&sql_pool)
         .await
         .context("while creating jwt tables")?;
     Ok(sql_pool)
@@ -193,16 +205,15 @@ async fn set_up_server(config: Configuration) -> Result<ServerBuilder> {
             "Restart the server without --force-update-private-key or --force-ldap-user-pass-reset to continue."
         );
     }
-    let server_builder = infra::ldap_server::build_ldap_server(
+    let server_builder = ldap_server::build_ldap_server(
         &config,
         backend_handler.clone(),
         actix_server::Server::build(),
     )
     .context("while binding the LDAP server")?;
-    let server_builder =
-        infra::tcp_server::build_tcp_server(&config, backend_handler, server_builder)
-            .await
-            .context("while binding the TCP server")?;
+    let server_builder = tcp_server::build_tcp_server(&config, backend_handler, server_builder)
+        .await
+        .context("while binding the TCP server")?;
     // Run every hour.
     let scheduler = Scheduler::new("0 0 * * * * *", sql_pool);
     scheduler.start();
@@ -212,8 +223,8 @@ async fn set_up_server(config: Configuration) -> Result<ServerBuilder> {
 async fn run_server_command(opts: RunOpts) -> Result<()> {
     debug!("CLI: {:#?}", &opts);
 
-    let config = infra::configuration::init(opts)?;
-    infra::logging::init(&config)?;
+    let config = configuration::init(opts)?;
+    logging::init(&config)?;
 
     let server = set_up_server(config).await?.workers(1);
 
@@ -222,8 +233,8 @@ async fn run_server_command(opts: RunOpts) -> Result<()> {
 
 async fn send_test_email_command(opts: TestEmailOpts) -> Result<()> {
     let to = opts.to.parse()?;
-    let config = infra::configuration::init(opts)?;
-    infra::logging::init(&config)?;
+    let config = configuration::init(opts)?;
+    logging::init(&config)?;
 
     mail::send_test_email(to, &config.smtp_options)
         .await
@@ -232,8 +243,8 @@ async fn send_test_email_command(opts: TestEmailOpts) -> Result<()> {
 
 async fn run_healthcheck(opts: RunOpts) -> Result<()> {
     debug!("CLI: {:#?}", &opts);
-    let config = infra::configuration::init(opts)?;
-    infra::logging::init(&config)?;
+    let config = configuration::init(opts)?;
+    logging::init(&config)?;
 
     info!("Starting healthchecks");
 
@@ -263,8 +274,8 @@ async fn run_healthcheck(opts: RunOpts) -> Result<()> {
 
 async fn create_schema_command(opts: RunOpts) -> Result<()> {
     debug!("CLI: {:#?}", &opts);
-    let config = infra::configuration::init(opts)?;
-    infra::logging::init(&config)?;
+    let config = configuration::init(opts)?;
+    logging::init(&config)?;
     setup_sql_tables(&config.database_url).await?;
     info!("Schema created successfully.");
     Ok(())
@@ -272,7 +283,7 @@ async fn create_schema_command(opts: RunOpts) -> Result<()> {
 
 #[actix::main]
 async fn main() -> Result<()> {
-    let cli_opts = infra::cli::init();
+    let cli_opts = cli::init();
     match cli_opts.command {
         Command::ExportGraphQLSchema(opts) => {
             lldap_graphql_server::api::export_schema(opts.output_file)
diff --git a/server/src/infra/mod.rs b/server/src/mod.rs
similarity index 100%
rename from server/src/infra/mod.rs
rename to server/src/mod.rs
diff --git a/server/src/infra/schema.rs b/server/src/schema.rs
similarity index 100%
rename from server/src/infra/schema.rs
rename to server/src/schema.rs
diff --git a/server/src/infra/sql_tcp_backend_handler.rs b/server/src/sql_tcp_backend_handler.rs
similarity index 99%
rename from server/src/infra/sql_tcp_backend_handler.rs
rename to server/src/sql_tcp_backend_handler.rs
index 33a7ff7..923e156 100644
--- a/server/src/infra/sql_tcp_backend_handler.rs
+++ b/server/src/sql_tcp_backend_handler.rs
@@ -1,4 +1,4 @@
-use crate::infra::tcp_backend_handler::TcpBackendHandler;
+use crate::tcp_backend_handler::TcpBackendHandler;
 use async_trait::async_trait;
 use chrono::NaiveDateTime;
 use lldap_domain::types::UserId;
diff --git a/server/src/infra/tcp_backend_handler.rs b/server/src/tcp_backend_handler.rs
similarity index 100%
rename from server/src/infra/tcp_backend_handler.rs
rename to server/src/tcp_backend_handler.rs
diff --git a/server/src/infra/tcp_server.rs b/server/src/tcp_server.rs
similarity index 98%
rename from server/src/infra/tcp_server.rs
rename to server/src/tcp_server.rs
index 8259ad7..b88eeed 100644
--- a/server/src/infra/tcp_server.rs
+++ b/server/src/tcp_server.rs
@@ -1,4 +1,4 @@
-use crate::infra::{
+use crate::{
     auth_service,
     configuration::{Configuration, MailOptions},
     logging::CustomRootSpanBuilder,
@@ -145,7 +145,7 @@ fn http_config<Backend>(
     .service(
         web::scope("/api")
             .wrap(auth_service::CookieToHeaderTranslatorFactory)
-            .configure(crate::infra::graphql_server::configure_endpoint::<Backend>),
+            .configure(crate::graphql_server::configure_endpoint::<Backend>),
     )
     .service(
         web::resource("/pkg/lldap_app_bg.wasm.gz")