mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-13 08:37:47 +00:00
Lovepreet Singh
65c5a5ff7b
Fixes #38217 ## Problem Turnstile CAPTCHA verification uses `http.DefaultClient`, so the request to `challenges.cloudflare.com` bypasses Gitea's configured HTTP proxy — unlike other outbound HTTP clients such as the update checker (`modules/updatechecker/update_checker.go`) and migrations. In deployments where egress is only permitted through the configured proxy, verification fails. ## Fix Build the client with `proxy.Proxy()` as the transport proxy, mirroring the update checker: ```go func httpClient() *http.Client { return &http.Client{ Transport: &http.Transport{ Proxy: proxy.Proxy(), }, } } ``` The client is built per call (rather than a package-level var) because `proxy.Proxy()` reads `setting.Proxy` when invoked; building it at request time ensures it reflects the loaded settings. When no proxy is configured, behavior is unchanged (`proxy.Proxy()` returns a no-op / `http.ProxyFromEnvironment`). --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
50 lines
1.1 KiB
Go
50 lines
1.1 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package util
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestOnceValue(t *testing.T) {
|
|
t.Run("RepeatCall", func(t *testing.T) {
|
|
callCount := 0
|
|
o := OnceValue[int]{Func: func() int {
|
|
callCount++
|
|
return 42
|
|
}}
|
|
assert.Equal(t, 42, o.Value())
|
|
assert.Equal(t, 42, o.Value())
|
|
assert.Equal(t, 1, callCount)
|
|
o.Reset()
|
|
assert.Equal(t, 42, o.Value())
|
|
assert.Equal(t, 2, callCount)
|
|
assert.Equal(t, 42, o.Value())
|
|
assert.Equal(t, 2, callCount)
|
|
})
|
|
|
|
t.Run("Panic", func(t *testing.T) {
|
|
callCount := 0
|
|
doPanic := true
|
|
o := OnceValue[int]{Func: func() int {
|
|
callCount++
|
|
if doPanic {
|
|
panic("some error")
|
|
}
|
|
return 42
|
|
}}
|
|
assert.PanicsWithValue(t, "some error", func() { o.Value() })
|
|
assert.PanicsWithValue(t, "some error", func() { o.Value() })
|
|
assert.Equal(t, 1, callCount)
|
|
doPanic = false
|
|
o.Reset()
|
|
assert.Equal(t, 42, o.Value())
|
|
assert.Equal(t, 2, callCount)
|
|
assert.Equal(t, 42, o.Value())
|
|
assert.Equal(t, 2, callCount)
|
|
})
|
|
}
|