mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-13 09:47:48 +00:00
bircni
f69e15afe7
Addresses a batch of privately reported security issues, grouped by area: - **SSRF** - migration PR-patch/asset fetches, OAuth2 avatar & OpenID discovery, pull-mirror URL re-validation, and the outbound proxy path. - **Access-token scope** - prevent scope escalation on token creation; keep public-only tokens confined (feeds, packages, Actions listings, star/watch lists, limited/private owners). - **Access control / disclosure** - go-get default-branch leak, webhook authorization-header leak, watch clearing on private transitions, label/attachment scoping. - **Denial of service** - input bounds for npm dist-tags, Debian control files, Arch file lists, and SSH keys. ### 📌 Attention for site admins Not breaking - existing configs keep working - but two changes are worth a look: - **New SSRF protection** Outbound requests (migrations, OAuth2 avatars, OpenID discovery, pull mirrors, proxy path) are now validated against the allow/block host lists. If your instance legitimately reaches internal hosts, you may need to add them to `[security].ALLOWED_HOST_LIST` (and the relevant `ALLOW_LOCALNETWORKS` settings). - **Deprecation** `[webhook].ALLOWED_HOST_LIST` is deprecated and will be removed in a future release. Use `[security].ALLOWED_HOST_LIST` instead; the old key still works for now. --------- Co-authored-by: TheFox0x7 <thefox0x7@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Zettat123 <zettat123@gmail.com>
30 lines
873 B
Go
30 lines
873 B
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestLoadSecurityFrom(t *testing.T) {
|
|
assert.Equal(t, "SAMEORIGIN", Security.XFrameOptions)
|
|
assert.Equal(t, "nosniff", Security.XContentTypeOptions)
|
|
assert.Equal(t, "external", Security.AllowedHostList)
|
|
|
|
cfg, err := NewConfigProviderFromData(`[security]
|
|
X_FRAME_OPTIONS = DENY
|
|
X_CONTENT_TYPE_OPTIONS = unset
|
|
ALLOWED_HOST_LIST = foo
|
|
CONTENT_SECURITY_POLICY_GENERAL = "script-src *; foo"
|
|
`)
|
|
assert.NoError(t, err)
|
|
loadSecurityFrom(cfg)
|
|
assert.Equal(t, "DENY", Security.XFrameOptions)
|
|
assert.Equal(t, "unset", Security.XContentTypeOptions)
|
|
assert.Equal(t, "foo", Security.AllowedHostList)
|
|
assert.Equal(t, `"script-src *`, Security.ContentSecurityPolicyGeneral) // holy shit ini package bug
|
|
}
|