Giteabot eee37e0560 fix: avoid enumerating every public repository in issue search (#38992) (#39000) ...

Backport #38992 by @lunny

Both issue search endpoints resolve their repository filter with
`SearchRepositoryIDs` and pass the result to the indexer as `RepoIDs`.
They mean
to leave public repositories to the indexer, but
`SearchRepoOptions.AllPublic` is
only read when `OwnerID > 0`, so without an `owner` filter the flag does
nothing
and every public repository is enumerated, without a `LIMIT`, into
`repo_id IN (...)`.

Those IDs are redundant, as `allPublic` is passed to the indexer, which
already
matches every public repository. On a large instance this binds tens of
thousands
of parameters and can fail in the driver, making the endpoint return 500
for every
filter. Admins are worst hit, as `SearchRepositoryCondition` skips their
accessible-repository condition and enumerates the whole table.

Restrict the enumeration to private repositories. The result set is
unchanged, as
the dropped IDs are a subset of what `allPublic` matches.

Both endpoints held copies of this block, so it moves to
`routers/common`.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

2026-08-20 19:51:20 +02:00

..

actions

fix(actions): let a rerun of selected jobs read the previous attempt's artifacts (#38857) (#38901)

2026-08-13 13:31:42 +00:00

packages

enhance: add missing npm package metadata properties (#38826) (#38831)

2026-08-08 16:50:10 +00:00

v1

fix: avoid enumerating every public repository in issue search (#38992) (#39000)

2026-08-20 19:51:20 +02:00