mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-19 21:38:41 +00:00
bircni
ed4a23e893
Admin and write team authorize now grant that mode on every unit, including units added later, instead of only rows present in `team_unit`. Granular teams keep `authorize=none` and explicit unit rows. Closes the `TEAM-UNIT-PERMISSION` design gap from https://github.com/go-gitea/gitea/pull/34128. Maybe also fix #15962 (actually maybe it had been fixed before, the root cause is out-of-sync "access" table) ## Screenshots only writing selected: <img width="1399" height="1007" alt="image" src="https://github.com/user-attachments/assets/1d1b4c49-a59a-47b6-998f-0464a067395b" /> _Created with the help of AI_ --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
45 lines
1.6 KiB
Go
45 lines
1.6 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package organization_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
org_model "gitea.dev/models/organization"
|
|
"gitea.dev/models/perm"
|
|
"gitea.dev/models/unit"
|
|
"gitea.dev/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_GetTeamsByIDs(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// 1 owner team, 2 normal team
|
|
teams, err := org_model.GetTeamsByIDs(t.Context(), []int64{1, 2})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, teams, 2)
|
|
assert.Equal(t, "Owners", teams[1].Name)
|
|
assert.Equal(t, "team1", teams[2].Name)
|
|
}
|
|
|
|
func TestTeamList_UnitMaxAccess(t *testing.T) {
|
|
ctx := t.Context()
|
|
adminTeam := &org_model.Team{AccessMode: perm.AccessModeAdmin, Units: nil}
|
|
writeTeam := &org_model.Team{AccessMode: perm.AccessModeWrite, Units: nil}
|
|
granularTeam := &org_model.Team{
|
|
AccessMode: perm.AccessModeNone,
|
|
Units: []*org_model.TeamUnit{
|
|
{Type: unit.TypeCode, AccessMode: perm.AccessModeWrite},
|
|
},
|
|
}
|
|
|
|
assert.Equal(t, perm.AccessModeAdmin, org_model.TeamList{adminTeam}.AnyRepoUnitMaxAccess(ctx, unit.TypeActions))
|
|
assert.Equal(t, perm.AccessModeWrite, org_model.TeamList{writeTeam}.AnyRepoUnitMaxAccess(ctx, unit.TypeActions))
|
|
assert.Equal(t, perm.AccessModeWrite, org_model.TeamList{granularTeam}.AnyRepoUnitMaxAccess(ctx, unit.TypeCode))
|
|
assert.Equal(t, perm.AccessModeNone, org_model.TeamList{granularTeam}.AnyRepoUnitMaxAccess(ctx, unit.TypeActions))
|
|
assert.Equal(t, perm.AccessModeAdmin, org_model.TeamList{granularTeam, adminTeam}.AnyRepoUnitMaxAccess(ctx, unit.TypeActions))
|
|
}
|