mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-05 14:46:19 +00:00
13d0f24423
* Closes #36942 * Fixes #19265 Replaces the SSE-based push channel (`/user/events`) with a WebSocket endpoint (`/-/ws`). ### What changes - **New `/-/ws` endpoint** (authenticated). One WebSocket per origin, shared across tabs via a single `SharedWorker`. - **Pubsub broker** (`services/pubsub`) for fan-out by topic, behind a `Broker` interface. `MemoryBroker` is the default (single process); a Redis backend is available for multi-process setups, configured via `[websocket].PUBSUB_TYPE` / `PUBSUB_CONN_STR`. The internal Gitea queue was not usable here because it has FIFO/single-consumer semantics. - **Push-only event production.** Events are emitted by write-triggered notifiers — `NotificationCountChange`, `PublishStopwatchesForUser`, and the logout publisher — wired into the existing `notify.Notifier` interface. No server-side pollers. - **Typed pub/sub on the client.** `web_src/js/modules/worker.ts` is a singleton transport; features subscribe per event type via `onUserEvent('notification-count', cb)` instead of branching on `event.data.type`. - **Wire contract** (`UserEventType` union) is shared between the worker and consumers via `web_src/js/types.ts`, kept in sync with `services/websocket/events.go`. - **Client-side periodic polling fallback** kicks in only when the WebSocket cannot be established (e.g. proxy blocks WS, browser lacks module-SharedWorker support). ### What's removed - `modules/eventsource` (SSE manager, run loop, messenger). - `/user/events` route and `tests/integration/eventsource_test.go`. - All server-side polling for stopwatches and notification counts. ### Stopwatch multi-tab fix The navbar stopwatch icon was previously rendered conditionally on `{{if $activeStopwatch}}`, so tabs loaded before the timer started had no DOM element to update. The icon and popup are now always rendered (toggled with `tw-hidden`), and the start/stop/cancel handlers POST silently so all open tabs reflect the change in real time. ### Deployment note WebSocket needs the upgrade headers to pass through a reverse proxy, e.g. for nginx: ```nginx proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "upgrade"; ``` Without them the WebSocket cannot be established, and after 3 consecutive failed opens the shared worker signals `push-unavailable`: the notification count and stopwatch fall back to periodic polling on the existing `[ui.notification]` timeouts. Real-time push is lost, the features keep working. The reverse-proxy docs need the same note (see the `docs-update-needed` label). --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Epid <rexmrj@gmail.com>
240 lines
6.0 KiB
Go
240 lines
6.0 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
issues_model "gitea.dev/models/issues"
|
|
"gitea.dev/routers/api/v1/utils"
|
|
"gitea.dev/services/context"
|
|
"gitea.dev/services/convert"
|
|
notify_service "gitea.dev/services/notify"
|
|
)
|
|
|
|
// StartIssueStopwatch creates a stopwatch for the given issue.
|
|
func StartIssueStopwatch(ctx *context.APIContext) {
|
|
// swagger:operation POST /repos/{owner}/{repo}/issues/{index}/stopwatch/start issue issueStartStopWatch
|
|
// ---
|
|
// summary: Start stopwatch on an issue.
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: owner
|
|
// in: path
|
|
// description: owner of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: repo
|
|
// in: path
|
|
// description: name of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: index
|
|
// in: path
|
|
// description: index of the issue to create the stopwatch on
|
|
// type: integer
|
|
// format: int64
|
|
// required: true
|
|
// responses:
|
|
// "201":
|
|
// "$ref": "#/responses/empty"
|
|
// "403":
|
|
// description: Not repo writer, user does not have rights to toggle stopwatch
|
|
// "404":
|
|
// "$ref": "#/responses/notFound"
|
|
// "409":
|
|
// description: Cannot start a stopwatch again if it already exists
|
|
|
|
issue := prepareIssueForStopwatch(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if ok, err := issues_model.CreateIssueStopwatch(ctx, ctx.Doer, issue); err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
} else if !ok {
|
|
ctx.APIError(http.StatusConflict, "cannot start a stopwatch again if it already exists")
|
|
return
|
|
}
|
|
notify_service.StopwatchChanged(ctx, ctx.Doer)
|
|
|
|
ctx.Status(http.StatusCreated)
|
|
}
|
|
|
|
// StopIssueStopwatch stops a stopwatch for the given issue.
|
|
func StopIssueStopwatch(ctx *context.APIContext) {
|
|
// swagger:operation POST /repos/{owner}/{repo}/issues/{index}/stopwatch/stop issue issueStopStopWatch
|
|
// ---
|
|
// summary: Stop an issue's existing stopwatch.
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: owner
|
|
// in: path
|
|
// description: owner of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: repo
|
|
// in: path
|
|
// description: name of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: index
|
|
// in: path
|
|
// description: index of the issue to stop the stopwatch on
|
|
// type: integer
|
|
// format: int64
|
|
// required: true
|
|
// responses:
|
|
// "201":
|
|
// "$ref": "#/responses/empty"
|
|
// "403":
|
|
// description: Not repo writer, user does not have rights to toggle stopwatch
|
|
// "404":
|
|
// "$ref": "#/responses/notFound"
|
|
// "409":
|
|
// description: Cannot stop a non-existent stopwatch
|
|
|
|
issue := prepareIssueForStopwatch(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if ok, err := issues_model.FinishIssueStopwatch(ctx, ctx.Doer, issue); err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
} else if !ok {
|
|
ctx.APIError(http.StatusConflict, "cannot stop a non-existent stopwatch")
|
|
return
|
|
}
|
|
notify_service.StopwatchChanged(ctx, ctx.Doer)
|
|
ctx.Status(http.StatusCreated)
|
|
}
|
|
|
|
// DeleteIssueStopwatch delete a specific stopwatch
|
|
func DeleteIssueStopwatch(ctx *context.APIContext) {
|
|
// swagger:operation DELETE /repos/{owner}/{repo}/issues/{index}/stopwatch/delete issue issueDeleteStopWatch
|
|
// ---
|
|
// summary: Delete an issue's existing stopwatch.
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: owner
|
|
// in: path
|
|
// description: owner of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: repo
|
|
// in: path
|
|
// description: name of the repo
|
|
// type: string
|
|
// required: true
|
|
// - name: index
|
|
// in: path
|
|
// description: index of the issue to stop the stopwatch on
|
|
// type: integer
|
|
// format: int64
|
|
// required: true
|
|
// responses:
|
|
// "204":
|
|
// "$ref": "#/responses/empty"
|
|
// "403":
|
|
// description: Not repo writer, user does not have rights to toggle stopwatch
|
|
// "404":
|
|
// "$ref": "#/responses/notFound"
|
|
// "409":
|
|
// description: Cannot cancel a non-existent stopwatch
|
|
|
|
issue := prepareIssueForStopwatch(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if ok, err := issues_model.CancelStopwatch(ctx, ctx.Doer, issue); err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
} else if !ok {
|
|
ctx.APIError(http.StatusConflict, "cannot cancel a non-existent stopwatch")
|
|
return
|
|
}
|
|
notify_service.StopwatchChanged(ctx, ctx.Doer)
|
|
|
|
ctx.Status(http.StatusNoContent)
|
|
}
|
|
|
|
func prepareIssueForStopwatch(ctx *context.APIContext) *issues_model.Issue {
|
|
issue, err := issues_model.GetIssueByIndex(ctx, ctx.Repo.Repository.ID, ctx.PathParamInt64("index"))
|
|
if err != nil {
|
|
if issues_model.IsErrIssueNotExist(err) {
|
|
ctx.APIErrorNotFound()
|
|
} else {
|
|
ctx.APIErrorInternal(err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
if !ctx.Repo.Permission.CanWriteIssuesOrPulls(issue.IsPull) {
|
|
ctx.Status(http.StatusForbidden)
|
|
return nil
|
|
}
|
|
|
|
if !ctx.Repo.CanUseTimetracker(ctx, issue, ctx.Doer) {
|
|
ctx.Status(http.StatusForbidden)
|
|
return nil
|
|
}
|
|
return issue
|
|
}
|
|
|
|
// GetStopwatches get all stopwatches
|
|
func GetStopwatches(ctx *context.APIContext) {
|
|
// swagger:operation GET /user/stopwatches user userGetStopWatches
|
|
// ---
|
|
// summary: Get list of all existing stopwatches
|
|
// parameters:
|
|
// - name: page
|
|
// in: query
|
|
// description: page number of results to return (1-based)
|
|
// type: integer
|
|
// - name: limit
|
|
// in: query
|
|
// description: page size of results
|
|
// type: integer
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// responses:
|
|
// "200":
|
|
// "$ref": "#/responses/StopWatchList"
|
|
|
|
sws, err := issues_model.GetUserStopwatches(ctx, ctx.Doer.ID, utils.GetListOptions(ctx))
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
count, err := issues_model.CountUserStopwatches(ctx, ctx.Doer.ID)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
apiSWs, err := convert.ToStopWatches(ctx, ctx.Doer, sws)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
ctx.SetTotalCountHeader(count)
|
|
ctx.JSON(http.StatusOK, apiSWs)
|
|
}
|