mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-19 22:48:32 +00:00
bircni
ed4a23e893
Admin and write team authorize now grant that mode on every unit, including units added later, instead of only rows present in `team_unit`. Granular teams keep `authorize=none` and explicit unit rows. Closes the `TEAM-UNIT-PERMISSION` design gap from https://github.com/go-gitea/gitea/pull/34128. Maybe also fix #15962 (actually maybe it had been fixed before, the root cause is out-of-sync "access" table) ## Screenshots only writing selected: <img width="1399" height="1007" alt="image" src="https://github.com/user-attachments/assets/1d1b4c49-a59a-47b6-998f-0464a067395b" /> _Created with the help of AI_ --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
122 lines
3.7 KiB
Go
122 lines
3.7 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.dev/models/db"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRepository_GetCollaborators(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
test := func(repoID int64) {
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: repoID})
|
|
collaborators, _, err := repo_model.GetCollaborators(t.Context(), &repo_model.FindCollaborationOptions{RepoID: repo.ID})
|
|
assert.NoError(t, err)
|
|
expectedLen, err := db.GetEngine(t.Context()).Count(&repo_model.Collaboration{RepoID: repoID})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, collaborators, int(expectedLen))
|
|
for _, collaborator := range collaborators {
|
|
assert.Equal(t, collaborator.User.ID, collaborator.Collaboration.UserID)
|
|
assert.Equal(t, repoID, collaborator.Collaboration.RepoID)
|
|
}
|
|
}
|
|
test(1)
|
|
test(2)
|
|
test(3)
|
|
test(4)
|
|
|
|
// Test db.ListOptions
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 22})
|
|
|
|
collaborators1, _, err := repo_model.GetCollaborators(t.Context(), &repo_model.FindCollaborationOptions{
|
|
ListOptions: db.ListOptions{PageSize: 1, Page: 1},
|
|
RepoID: repo.ID,
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, collaborators1, 1)
|
|
|
|
collaborators2, _, err := repo_model.GetCollaborators(t.Context(), &repo_model.FindCollaborationOptions{
|
|
ListOptions: db.ListOptions{PageSize: 1, Page: 2},
|
|
RepoID: repo.ID,
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, collaborators2, 1)
|
|
|
|
assert.NotEqual(t, collaborators1[0].ID, collaborators2[0].ID)
|
|
}
|
|
|
|
func TestRepository_IsCollaborator(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
test := func(repoID, userID int64, expected bool) {
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: repoID})
|
|
actual, err := repo_model.IsCollaborator(t.Context(), repo.ID, userID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, expected, actual)
|
|
}
|
|
test(3, 2, true)
|
|
test(3, unittest.NonexistentID, false)
|
|
test(4, 2, false)
|
|
test(4, 4, true)
|
|
}
|
|
|
|
func TestRepository_IsOwnerMemberCollaborator(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
|
|
|
|
// Organisation owner.
|
|
actual, err := repo_model.HasAccessToRepoCodeUnit(t.Context(), repo1, 2)
|
|
assert.NoError(t, err)
|
|
assert.True(t, actual)
|
|
|
|
// Team member.
|
|
actual, err = repo_model.HasAccessToRepoCodeUnit(t.Context(), repo1, 4)
|
|
assert.NoError(t, err)
|
|
assert.True(t, actual)
|
|
|
|
// Normal user.
|
|
actual, err = repo_model.HasAccessToRepoCodeUnit(t.Context(), repo1, 1)
|
|
assert.NoError(t, err)
|
|
assert.False(t, actual)
|
|
|
|
repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
|
|
|
|
// Collaborator.
|
|
actual, err = repo_model.HasAccessToRepoCodeUnit(t.Context(), repo2, 4)
|
|
assert.NoError(t, err)
|
|
assert.True(t, actual)
|
|
|
|
repo3 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 15})
|
|
|
|
// Repository owner.
|
|
actual, err = repo_model.HasAccessToRepoCodeUnit(t.Context(), repo3, 2)
|
|
assert.NoError(t, err)
|
|
assert.True(t, actual)
|
|
}
|
|
|
|
func TestRepo_GetCollaboration(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
|
|
|
|
// Existing collaboration.
|
|
collab, err := repo_model.GetCollaboration(t.Context(), repo.ID, 4)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, collab)
|
|
assert.EqualValues(t, 4, collab.UserID)
|
|
assert.EqualValues(t, 4, collab.RepoID)
|
|
|
|
// Non-existing collaboration.
|
|
collab, err = repo_model.GetCollaboration(t.Context(), repo.ID, 1)
|
|
assert.NoError(t, err)
|
|
assert.Nil(t, collab)
|
|
}
|