mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-02 22:39:36 +00:00
13d0f24423
* Closes #36942 * Fixes #19265 Replaces the SSE-based push channel (`/user/events`) with a WebSocket endpoint (`/-/ws`). ### What changes - **New `/-/ws` endpoint** (authenticated). One WebSocket per origin, shared across tabs via a single `SharedWorker`. - **Pubsub broker** (`services/pubsub`) for fan-out by topic, behind a `Broker` interface. `MemoryBroker` is the default (single process); a Redis backend is available for multi-process setups, configured via `[websocket].PUBSUB_TYPE` / `PUBSUB_CONN_STR`. The internal Gitea queue was not usable here because it has FIFO/single-consumer semantics. - **Push-only event production.** Events are emitted by write-triggered notifiers — `NotificationCountChange`, `PublishStopwatchesForUser`, and the logout publisher — wired into the existing `notify.Notifier` interface. No server-side pollers. - **Typed pub/sub on the client.** `web_src/js/modules/worker.ts` is a singleton transport; features subscribe per event type via `onUserEvent('notification-count', cb)` instead of branching on `event.data.type`. - **Wire contract** (`UserEventType` union) is shared between the worker and consumers via `web_src/js/types.ts`, kept in sync with `services/websocket/events.go`. - **Client-side periodic polling fallback** kicks in only when the WebSocket cannot be established (e.g. proxy blocks WS, browser lacks module-SharedWorker support). ### What's removed - `modules/eventsource` (SSE manager, run loop, messenger). - `/user/events` route and `tests/integration/eventsource_test.go`. - All server-side polling for stopwatches and notification counts. ### Stopwatch multi-tab fix The navbar stopwatch icon was previously rendered conditionally on `{{if $activeStopwatch}}`, so tabs loaded before the timer started had no DOM element to update. The icon and popup are now always rendered (toggled with `tw-hidden`), and the start/stop/cancel handlers POST silently so all open tabs reflect the change in real time. ### Deployment note WebSocket needs the upgrade headers to pass through a reverse proxy, e.g. for nginx: ```nginx proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "upgrade"; ``` Without them the WebSocket cannot be established, and after 3 consecutive failed opens the shared worker signals `push-unavailable`: the notification count and stopwatch fall back to periodic polling on the existing `[ui.notification]` timeouts. Real-time push is lost, the features keep working. The reverse-proxy docs need the same note (see the `docs-update-needed` label). --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Epid <rexmrj@gmail.com>
177 lines
4.9 KiB
Go
177 lines
4.9 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package notify
|
|
|
|
import (
|
|
"net/http"
|
|
"time"
|
|
|
|
activities_model "gitea.dev/models/activities"
|
|
"gitea.dev/models/db"
|
|
"gitea.dev/modules/structs"
|
|
"gitea.dev/services/context"
|
|
"gitea.dev/services/convert"
|
|
"gitea.dev/services/notifications"
|
|
)
|
|
|
|
// ListNotifications list users's notification threads
|
|
func ListNotifications(ctx *context.APIContext) {
|
|
// swagger:operation GET /notifications notification notifyGetList
|
|
// ---
|
|
// summary: List users's notification threads
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: all
|
|
// in: query
|
|
// description: If true, show notifications marked as read. Default value is false
|
|
// type: boolean
|
|
// - name: status-types
|
|
// in: query
|
|
// description: "Show notifications with the provided status types. Options are: unread, read and/or pinned. Defaults to unread & pinned."
|
|
// type: array
|
|
// collectionFormat: multi
|
|
// items:
|
|
// type: string
|
|
// - name: subject-type
|
|
// in: query
|
|
// description: "filter notifications by subject type"
|
|
// type: array
|
|
// collectionFormat: multi
|
|
// items:
|
|
// type: string
|
|
// enum: [issue,pull,commit,repository]
|
|
// - name: since
|
|
// in: query
|
|
// description: Only show notifications updated after the given time. This is a timestamp in RFC 3339 format
|
|
// type: string
|
|
// format: date-time
|
|
// - name: before
|
|
// in: query
|
|
// description: Only show notifications updated before the given time. This is a timestamp in RFC 3339 format
|
|
// type: string
|
|
// format: date-time
|
|
// - name: page
|
|
// in: query
|
|
// description: page number of results to return (1-based)
|
|
// type: integer
|
|
// - name: limit
|
|
// in: query
|
|
// description: page size of results
|
|
// type: integer
|
|
// responses:
|
|
// "200":
|
|
// "$ref": "#/responses/NotificationThreadList"
|
|
opts := getFindNotificationOptions(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
totalCount, err := db.Count[activities_model.Notification](ctx, opts)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
nl, err := db.Find[activities_model.Notification](ctx, opts)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
err = activities_model.NotificationList(nl).LoadAttributes(ctx)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
ctx.SetLinkHeader(totalCount, opts.PageSize)
|
|
ctx.SetTotalCountHeader(totalCount)
|
|
ctx.JSON(http.StatusOK, convert.ToNotifications(ctx, nl))
|
|
}
|
|
|
|
// ReadNotifications mark notification threads as read, unread, or pinned
|
|
func ReadNotifications(ctx *context.APIContext) {
|
|
// swagger:operation PUT /notifications notification notifyReadList
|
|
// ---
|
|
// summary: Mark notification threads as read, pinned or unread
|
|
// consumes:
|
|
// - application/json
|
|
// produces:
|
|
// - application/json
|
|
// parameters:
|
|
// - name: last_read_at
|
|
// in: query
|
|
// description: Describes the last point that notifications were checked. Anything updated since this time will not be updated.
|
|
// type: string
|
|
// format: date-time
|
|
// required: false
|
|
// - name: all
|
|
// in: query
|
|
// description: If true, mark all notifications on this repo. Default value is false
|
|
// type: string
|
|
// required: false
|
|
// - name: status-types
|
|
// in: query
|
|
// description: "Mark notifications with the provided status types. Options are: unread, read and/or pinned. Defaults to unread."
|
|
// type: array
|
|
// collectionFormat: multi
|
|
// items:
|
|
// type: string
|
|
// required: false
|
|
// - name: to-status
|
|
// in: query
|
|
// description: Status to mark notifications as, Defaults to read.
|
|
// type: string
|
|
// required: false
|
|
// responses:
|
|
// "205":
|
|
// "$ref": "#/responses/NotificationThreadList"
|
|
|
|
lastRead := int64(0)
|
|
qLastRead := ctx.FormTrim("last_read_at")
|
|
if len(qLastRead) > 0 {
|
|
tmpLastRead, err := time.Parse(time.RFC3339, qLastRead)
|
|
if err != nil {
|
|
ctx.APIError(http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
if !tmpLastRead.IsZero() {
|
|
lastRead = tmpLastRead.Unix()
|
|
}
|
|
}
|
|
opts := &activities_model.FindNotificationOptions{
|
|
UserID: ctx.Doer.ID,
|
|
UpdatedBeforeUnix: lastRead,
|
|
}
|
|
if !ctx.FormBool("all") {
|
|
statuses := ctx.FormStrings("status-types")
|
|
opts.Status = statusStringsToNotificationStatuses(statuses, []string{"unread"})
|
|
}
|
|
nl, err := db.Find[activities_model.Notification](ctx, opts)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
|
|
targetStatus := statusStringToNotificationStatus(ctx.FormString("to-status"))
|
|
if targetStatus == 0 {
|
|
targetStatus = activities_model.NotificationStatusRead
|
|
}
|
|
|
|
updated, err := notifications.SetManyNotificationStatuses(ctx, nl, ctx.Doer, targetStatus)
|
|
if err != nil {
|
|
ctx.APIErrorInternal(err)
|
|
return
|
|
}
|
|
changed := make([]*structs.NotificationThread, 0, len(updated))
|
|
for _, notif := range updated {
|
|
_ = notif.LoadAttributes(ctx)
|
|
changed = append(changed, convert.ToNotificationThread(ctx, notif))
|
|
}
|
|
|
|
ctx.JSON(http.StatusResetContent, changed)
|
|
}
|