mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-08 14:47:44 +00:00
silverwind
9dac77fdc2
Registration omitted `userVerification`, so Chromium raised the credential to credProtect level 3 and the authenticator then hid it from the second-factor login, which asked for `discouraged`. Registration and each login now set their own value, with `preferred` on the second factor so credentials already registered at level 3 keep working without re-enrollment. Also add relevant e2e test coverage for webauthn, one test chromium only because Firefox lacks the APIs needed. Fixes https://github.com/go-gitea/gitea/issues/33531 Fixes https://github.com/go-gitea/gitea/issues/36019 Fixes https://github.com/go-gitea/gitea/issues/38139
69 lines
2.0 KiB
Go
69 lines
2.0 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/log"
|
|
"gitea.dev/modules/session"
|
|
)
|
|
|
|
// Ensure the struct implements the interface.
|
|
var (
|
|
_ Method = &Session{}
|
|
)
|
|
|
|
// Session checks if there is a user uid stored in the session and returns the user
|
|
// object for that uid.
|
|
type Session struct{}
|
|
|
|
// Name represents the name of auth method
|
|
func (s *Session) Name() string {
|
|
return "session"
|
|
}
|
|
|
|
// Verify checks if there is a user uid stored in the session and returns the user
|
|
// object for that uid.
|
|
// Returns nil if there is no user uid stored in the session.
|
|
func (s *Session) Verify(req *http.Request, w http.ResponseWriter, store DataStore, sess SessionStore) (*user_model.User, error) {
|
|
if sess == nil {
|
|
return nil, nil //nolint:nilnil // the auth method is not applicable
|
|
}
|
|
|
|
// Get session user ID
|
|
uid, ok := sess.Get(session.KeyUID).(int64)
|
|
if !ok {
|
|
return nil, nil //nolint:nilnil // the auth method is not applicable
|
|
}
|
|
|
|
// Get user object
|
|
user, err := user_model.GetUserByID(req.Context(), uid)
|
|
if err != nil {
|
|
if !user_model.IsErrUserNotExist(err) {
|
|
log.Error("GetUserByID: %v", err)
|
|
// Return the err as-is to keep current signed-in session, in case the err is something like context.Canceled. Otherwise non-existing user (nil, nil) will make the caller clear the signed-in session.
|
|
return nil, err
|
|
}
|
|
return nil, nil //nolint:nilnil // the auth method is not applicable
|
|
}
|
|
|
|
log.Trace("Session Authorization: Logged in user %-v", user)
|
|
return user, nil
|
|
}
|
|
|
|
func ClearSessionKeysForSignIn(sess SessionStore) {
|
|
_ = sess.Delete("openid_verified_uri")
|
|
_ = sess.Delete("openid_signin_remember")
|
|
_ = sess.Delete("openid_determined_email")
|
|
_ = sess.Delete("openid_determined_username")
|
|
_ = sess.Delete("twofaUid")
|
|
_ = sess.Delete("twofaRemember")
|
|
_ = sess.Delete("webauthnAssertion")
|
|
_ = sess.Delete("linkAccount")
|
|
_ = sess.Delete("linkAccountData")
|
|
_ = sess.Delete("openidPendingURI")
|
|
}
|