mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-12 13:04:29 +00:00
500a09e044
Backport #38321 by @bircni The `/user/starred` and `/user/subscriptions` endpoints returned private repositories a user had starred/watched even after their access to those repositories was revoked, still exposing the repository name, description and visibility (including later metadata changes). Private repositories in the starred/watched queries are now gated on the actor's current access via `AccessibleRepositoryCondition`, so users who no longer have access no longer receive the metadata. Public repositories and public-only tokens are unaffected. Co-authored-by: bircni <bircni@icloud.com>
227 lines
7.7 KiB
Go
227 lines
7.7 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/perm"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/setting"
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/modules/test"
|
|
repo_service "gitea.dev/services/repository"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAPIStar(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
user := "user1"
|
|
repo := "user2/repo1"
|
|
|
|
session := loginUser(t, user)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
tokenWithUserScope := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteUser, auth_model.AccessTokenScopeWriteRepository)
|
|
|
|
t.Run("Star", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "PUT", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusNoContent)
|
|
|
|
// blocked user can't star a repo
|
|
user34 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 34})
|
|
req = NewRequest(t, "PUT", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(getUserToken(t, user34.Name, auth_model.AccessTokenScopeWriteRepository))
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
})
|
|
|
|
t.Run("GetStarredRepos", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("/api/v1/users/%s/starred", user)).
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
assert.Equal(t, "1", resp.Header().Get("X-Total-Count"))
|
|
|
|
repos := DecodeJSON(t, resp, []api.Repository{})
|
|
assert.Len(t, repos, 1)
|
|
assert.Equal(t, repo, repos[0].FullName)
|
|
})
|
|
|
|
t.Run("GetMyStarredRepos", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/user/starred").
|
|
AddTokenAuth(tokenWithUserScope)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
assert.Equal(t, "1", resp.Header().Get("X-Total-Count"))
|
|
|
|
repos := DecodeJSON(t, resp, []api.Repository{})
|
|
assert.Len(t, repos, 1)
|
|
assert.Equal(t, repo, repos[0].FullName)
|
|
})
|
|
|
|
t.Run("IsStarring", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusNoContent)
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user/starred/"+repo+"notexisting").
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
})
|
|
|
|
t.Run("Unstar", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "DELETE", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusNoContent)
|
|
})
|
|
}
|
|
|
|
// TestAPIStarredReposAccessRevoked ensures a private repository disappears from a user's
|
|
// starred list once their access to it has been revoked, so no metadata leaks afterwards.
|
|
func TestAPIStarredReposAccessRevoked(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// user2/repo2 is a private repository owned by user2
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
|
|
collaborator := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
|
|
// grant the collaborator read access and star the private repo as them
|
|
require.NoError(t, repo_service.AddOrUpdateCollaborator(t.Context(), repo, collaborator, perm.AccessModeRead))
|
|
require.NoError(t, repo_model.StarRepo(t.Context(), collaborator, repo, true))
|
|
|
|
token := getUserToken(t, collaborator.Name, auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopeReadRepository)
|
|
|
|
// while access is granted, the private repo is visible in the starred list
|
|
req := NewRequest(t, "GET", "/api/v1/user/starred").AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
repos := DecodeJSON(t, resp, []api.Repository{})
|
|
require.Len(t, repos, 1)
|
|
assert.Equal(t, repo.FullName(), repos[0].FullName)
|
|
|
|
// revoke access
|
|
require.NoError(t, repo_service.DeleteCollaboration(t.Context(), repo, collaborator))
|
|
|
|
// the star record still exists, but the repo (and its metadata) must no longer be returned
|
|
assert.True(t, repo_model.IsStaring(t.Context(), collaborator.ID, repo.ID))
|
|
req = NewRequest(t, "GET", "/api/v1/user/starred").AddTokenAuth(token)
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
repos = DecodeJSON(t, resp, []api.Repository{})
|
|
assert.Empty(t, repos)
|
|
|
|
// sanity: the owner still sees their own private repo
|
|
ownerToken := getUserToken(t, owner.Name, auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopeReadRepository)
|
|
require.NoError(t, repo_model.StarRepo(t.Context(), owner, repo, true))
|
|
req = NewRequest(t, "GET", "/api/v1/user/starred").AddTokenAuth(ownerToken)
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
repos = DecodeJSON(t, resp, []api.Repository{})
|
|
fullNames := make([]string, len(repos))
|
|
for i, r := range repos {
|
|
fullNames[i] = r.FullName
|
|
}
|
|
assert.Contains(t, fullNames, repo.FullName())
|
|
}
|
|
|
|
func TestAPIStarDisabled(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
user := "user1"
|
|
repo := "user2/repo1"
|
|
|
|
session := loginUser(t, user)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
tokenWithUserScope := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteUser, auth_model.AccessTokenScopeWriteRepository)
|
|
|
|
defer test.MockVariableValue(&setting.Repository.DisableStars, true)()
|
|
|
|
t.Run("Star", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "PUT", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
|
|
user34 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 34})
|
|
req = NewRequest(t, "PUT", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(getUserToken(t, user34.Name, auth_model.AccessTokenScopeWriteRepository))
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
})
|
|
|
|
t.Run("GetStarredRepos", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("/api/v1/users/%s/starred", user)).
|
|
AddTokenAuth(token)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
})
|
|
|
|
t.Run("GetMyStarredRepos", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/user/starred").
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
})
|
|
|
|
t.Run("IsStarring", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user/starred/"+repo+"notexisting").
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
})
|
|
|
|
t.Run("Unstar", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "DELETE", "/api/v1/user/starred/"+repo).
|
|
AddTokenAuth(tokenWithUserScope)
|
|
MakeRequest(t, req, http.StatusForbidden)
|
|
})
|
|
}
|
|
|
|
func TestAPIStarPublicOnly(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
token := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopeReadRepository, auth_model.AccessTokenScopePublicOnly)
|
|
req := NewRequest(t, "GET", "/api/v1/user/starred").
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
repos := DecodeJSON(t, resp, []api.Repository{})
|
|
if assert.Len(t, repos, 1) {
|
|
assert.Equal(t, "user5/repo4", repos[0].FullName)
|
|
}
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/users/user2/starred").
|
|
AddTokenAuth(token)
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
repos = DecodeJSON(t, resp, []api.Repository{})
|
|
require.Len(t, repos, 1)
|
|
assert.Equal(t, "user5/repo4", repos[0].FullName)
|
|
}
|