mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-11 21:48:41 +00:00
silverwind
e3ee28f15b
- Hash emails with sha256. Gravatar moved to sha256, and both it and libravatar.org serve the same image for either hash. - Drop `strk.kbt.io/projects/go/libravatar` for a 46 line inline SRV lookup. It could not bound or cancel its DNS query and panicked on an unexpected resolver error. The replacement carries the request context and a 3s timeout. - Fix federated avatars querying DNS for every avatar on every render. `loadAvatarSetting` compared a cache field that was never assigned, so each call rebuilt the resolver and dropped its cache. That cache is gone, both settings are read where they are used. - Migration 348 recreates `email_hash` with a 64 char hash column and a `hash_type` column, so a later algorithm change can tell old rows apart. The MD5 rows are unreachable and their `UNIQUE` email index would reject the SHA256 replacements. - Fix a re-saved avatar form replacing an uploaded avatar with a random one. - Remove the `duoshuo` `GRAVATAR_SOURCE` alias, that service shut down in 2017. - Remove dead i18n key. Fixes: https://github.com/go-gitea/gitea/issues/34284 Fixes: https://github.com/go-gitea/gitea/issues/28110 Docs: https://gitea.com/gitea/docs/pulls/499 Signed-off-by: silverwind <me@silverwind.io>
105 lines
3.3 KiB
Go
105 lines
3.3 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package user
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"image/png"
|
|
"io"
|
|
|
|
"gitea.dev/models/avatars"
|
|
"gitea.dev/models/db"
|
|
"gitea.dev/modules/avatar"
|
|
"gitea.dev/modules/httplib"
|
|
"gitea.dev/modules/log"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/storage"
|
|
"gitea.dev/modules/util"
|
|
)
|
|
|
|
// CustomAvatarRelativePath returns user custom avatar relative path.
|
|
func (u *User) CustomAvatarRelativePath() string {
|
|
return u.Avatar
|
|
}
|
|
|
|
// GenerateRandomAvatar generates a random avatar for user.
|
|
func GenerateRandomAvatar(ctx context.Context, u *User) error {
|
|
seed := []byte(util.IfZero(u.Email, u.Name))
|
|
u.Avatar = avatar.HashAvatar(u.ID, seed)
|
|
|
|
// a failed Stat usually means the file is not there yet
|
|
if _, err := storage.Avatars.Stat(u.CustomAvatarRelativePath()); err != nil {
|
|
if err := storage.SaveFrom(storage.Avatars, u.CustomAvatarRelativePath(), func(w io.Writer) error {
|
|
return png.Encode(w, avatar.RandomImageDefaultSize(seed))
|
|
}); err != nil {
|
|
return fmt.Errorf("failed to save avatar %s: %w", u.CustomAvatarRelativePath(), err)
|
|
}
|
|
}
|
|
|
|
if _, err := db.GetEngine(ctx).ID(u.ID).Cols("avatar").Update(u); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// AvatarLinkWithSize returns a link to the user's avatar with size. size <= 0 means default size
|
|
func (u *User) AvatarLinkWithSize(ctx context.Context, size int) string {
|
|
// ghost user was deleted, Gitea actions is a bot user, 0 means the user should be a virtual user
|
|
// which comes from git configure information
|
|
if u.IsGhost() || u.IsGiteaActions() || u.ID <= 0 {
|
|
return avatars.DefaultAvatarLink()
|
|
}
|
|
|
|
useLocalAvatar := false
|
|
autoGenerateAvatar := false
|
|
|
|
disableGravatar := setting.Config().Picture.DisableGravatar.Value(ctx)
|
|
|
|
switch {
|
|
case u.UseCustomAvatar:
|
|
useLocalAvatar = true
|
|
case disableGravatar:
|
|
useLocalAvatar = true
|
|
autoGenerateAvatar = true
|
|
}
|
|
|
|
if useLocalAvatar {
|
|
if u.Avatar == "" && autoGenerateAvatar {
|
|
if err := GenerateRandomAvatar(ctx, u); err != nil {
|
|
log.Error("GenerateRandomAvatar: %v", err)
|
|
}
|
|
}
|
|
if u.Avatar == "" {
|
|
return avatars.DefaultAvatarLink()
|
|
}
|
|
return avatars.GenerateUserAvatarImageLink(u.Avatar, size)
|
|
}
|
|
return avatars.GenerateEmailAvatarFastLink(ctx, u.AvatarEmail, size)
|
|
}
|
|
|
|
// AvatarLink returns the full avatar url with http host.
|
|
// TODO: refactor it to a relative URL, but it is still used in API response at the moment
|
|
func (u *User) AvatarLink(ctx context.Context) string {
|
|
relLink := u.AvatarLinkWithSize(ctx, 0) // it can't be empty
|
|
return httplib.MakeAbsoluteURL(ctx, relLink)
|
|
}
|
|
|
|
// IsUploadAvatarChanged returns true if the current user's avatar would be changed with the provided data
|
|
func (u *User) IsUploadAvatarChanged(data []byte) bool {
|
|
if !u.UseCustomAvatar || len(u.Avatar) == 0 {
|
|
return true
|
|
}
|
|
avatarID := avatar.HashAvatar(u.ID, data)
|
|
return u.Avatar != avatarID
|
|
}
|
|
|
|
// ExistsWithAvatarAtStoragePath returns true if there is a user with this Avatar
|
|
func ExistsWithAvatarAtStoragePath(ctx context.Context, storagePath string) (bool, error) {
|
|
// See func (u *User) CustomAvatarRelativePath()
|
|
// u.Avatar is used directly as the storage path - therefore we can check for existence directly using the path
|
|
return db.GetEngine(ctx).Where("`avatar`=?", storagePath).Exist(new(User))
|
|
}
|