mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-08 03:09:15 +00:00
7733f1953f
## Issue Gitea fails to dump LFS (and other object-storage) files when Azure Blob Storage is configured as the storage backend. The dump reports: Failed to dump LFS objects: /file/path: copying contents: file does not exist This happens with any non-empty base path (the default for LFS storage), which is why the user could only work around it by using `--skip-*` flags. The root cause is in `AzureBlobStorage.IterateObjects()`: Azure's list API already returns each blob's name including the configured base path, but the code was building the read client by running that name through the base-path-prepending helper a second time. This doubled the base path (e.g. `gitea-lfs/gitea-lfs/aa/bb/hash`), pointing at a blob that doesn't exist. `Stat()` still succeeded because it doesn't touch the network, so the failure only surfaced when the dumper actually tried to read the object's contents. ## Solution Add `getBlobClientByFullName()`, which builds a blob client from a name that is already fully qualified, without re-applying `buildAzureBlobPath()`. `IterateObjects()` now uses it for names obtained from Azure's list API. `getBlobClient()` (used by `Open`, `Stat`, `Delete`, `ServeDirectURL`, which take relative paths) is unchanged in behavior. Also add `TestAzureBlobStorageDumpArchive`, a regression test that drives the real dump path (`IterateObjects` → `Stat` → `dump.Dumper.AddFileByReader` → `mholt/archives` zip writer) against a **non-empty** `BasePath`, and verifies the produced archive contains the object with the correct content. The existing Azure tests use an empty `BasePath` and never read object content via `IterateObjects`, which is why they didn't catch this. Fixes #35476 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
335 lines
9.5 KiB
Go
335 lines
9.5 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package storage
|
|
|
|
import (
|
|
"context"
|
|
"crypto/tls"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"os"
|
|
"path"
|
|
"strings"
|
|
"time"
|
|
|
|
"gitea.dev/modules/log"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/util"
|
|
|
|
"github.com/minio/minio-go/v7"
|
|
"github.com/minio/minio-go/v7/pkg/credentials"
|
|
)
|
|
|
|
var _ ObjectStorage = &MinioStorage{}
|
|
|
|
const unknownSizePartSize = 1024 * 1024 * 16 // same as minio-go's minPartSize
|
|
|
|
type minioObject struct {
|
|
*minio.Object
|
|
}
|
|
|
|
func (m *minioObject) Stat() (os.FileInfo, error) {
|
|
oi, err := m.Object.Stat()
|
|
if err != nil {
|
|
return nil, convertMinioErr(err)
|
|
}
|
|
|
|
return &minioFileInfo{oi}, nil
|
|
}
|
|
|
|
// minio reports a missing key on the first Read, ReadAt or Seek rather than on Open, so all
|
|
// of them convert it like Stat does.
|
|
func (m *minioObject) Read(p []byte) (int, error) {
|
|
n, err := m.Object.Read(p)
|
|
return n, convertMinioErr(err)
|
|
}
|
|
|
|
func (m *minioObject) ReadAt(p []byte, off int64) (int, error) {
|
|
n, err := m.Object.ReadAt(p, off)
|
|
return n, convertMinioErr(err)
|
|
}
|
|
|
|
func (m *minioObject) Seek(offset int64, whence int) (int64, error) {
|
|
n, err := m.Object.Seek(offset, whence)
|
|
return n, convertMinioErr(err)
|
|
}
|
|
|
|
// MinioStorage returns a minio bucket storage
|
|
type MinioStorage struct {
|
|
cfg *setting.MinioStorageConfig
|
|
ctx context.Context
|
|
client *minio.Client
|
|
bucket string
|
|
basePath string
|
|
}
|
|
|
|
func convertMinioErr(err error, optMsg ...string) error {
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
|
|
wrapErr := func(err error) error {
|
|
if len(optMsg) == 0 {
|
|
return err
|
|
}
|
|
return fmt.Errorf("%s: %w", optMsg[0], err)
|
|
}
|
|
|
|
errResp, ok := errors.AsType[minio.ErrorResponse](err)
|
|
if !ok {
|
|
return wrapErr(err)
|
|
}
|
|
|
|
// Convert two responses to standard analogues
|
|
switch errResp.Code {
|
|
case "NoSuchKey":
|
|
return wrapErr(os.ErrNotExist)
|
|
case "AccessDenied":
|
|
return wrapErr(os.ErrPermission)
|
|
}
|
|
|
|
return wrapErr(err)
|
|
}
|
|
|
|
// NewMinioStorage returns a minio storage
|
|
func NewMinioStorage(ctx context.Context, cfg *setting.Storage) (ObjectStorage, error) {
|
|
config := cfg.MinioConfig
|
|
log.Info("Creating minio storage at %s:%s with base path %s", config.Endpoint, config.Bucket, config.BasePath)
|
|
if config.ChecksumAlgorithm != "" && config.ChecksumAlgorithm != "default" && config.ChecksumAlgorithm != "md5" {
|
|
return nil, fmt.Errorf("invalid minio checksum algorithm: %s", config.ChecksumAlgorithm)
|
|
}
|
|
|
|
var lookup minio.BucketLookupType
|
|
switch config.BucketLookUpType {
|
|
case "auto", "":
|
|
lookup = minio.BucketLookupAuto
|
|
case "dns":
|
|
lookup = minio.BucketLookupDNS
|
|
case "path":
|
|
lookup = minio.BucketLookupPath
|
|
default:
|
|
return nil, fmt.Errorf("invalid minio bucket lookup type: %s", config.BucketLookUpType)
|
|
}
|
|
|
|
// The request error message is something like:
|
|
// * "The request signature we calculated does not match the signature you provided. Check your key and signing method."
|
|
// It doesn't contain useful information to site admin, so here we wrap the error with our error message
|
|
// to tell the site admin what is the problem.
|
|
makeErrMsg := func(hint string) string {
|
|
return fmt.Sprintf("ObjectStorage.%s: endpoint=%s, location=%s, bucket=%s", hint, config.Endpoint, config.Location, config.Bucket)
|
|
}
|
|
minioClient, err := minio.New(config.Endpoint, &minio.Options{
|
|
Creds: buildMinioCredentials(config),
|
|
Secure: config.UseSSL,
|
|
Transport: &http.Transport{TLSClientConfig: &tls.Config{InsecureSkipVerify: config.InsecureSkipVerify}},
|
|
Region: config.Location,
|
|
BucketLookup: lookup,
|
|
})
|
|
if err != nil {
|
|
return nil, convertMinioErr(err, makeErrMsg("NewClient"))
|
|
}
|
|
|
|
// Check to see if we already own this bucket
|
|
exists, err := minioClient.BucketExists(ctx, config.Bucket)
|
|
if err != nil {
|
|
return nil, convertMinioErr(err, makeErrMsg("BucketExists"))
|
|
}
|
|
|
|
// If the bucket doesn't exist, try to create one
|
|
if !exists {
|
|
if err := minioClient.MakeBucket(ctx, config.Bucket, minio.MakeBucketOptions{
|
|
Region: config.Location,
|
|
}); err != nil {
|
|
return nil, convertMinioErr(err, makeErrMsg("MakeBucket"))
|
|
}
|
|
}
|
|
|
|
return &MinioStorage{
|
|
cfg: &config,
|
|
ctx: ctx,
|
|
client: minioClient,
|
|
bucket: config.Bucket,
|
|
basePath: config.BasePath,
|
|
}, nil
|
|
}
|
|
|
|
func (m *MinioStorage) buildMinioPath(p string) string {
|
|
return buildObjectStorePath(m.basePath, p)
|
|
}
|
|
|
|
func (m *MinioStorage) buildMinioDirPrefix(p string) string {
|
|
return buildObjectStorePathPrefix(m.basePath, p)
|
|
}
|
|
|
|
func buildMinioCredentials(config setting.MinioStorageConfig) *credentials.Credentials {
|
|
// If static credentials are provided, use those
|
|
if config.AccessKeyID != "" {
|
|
return credentials.NewStaticV4(config.AccessKeyID, config.SecretAccessKey, "")
|
|
}
|
|
|
|
// Otherwise, fallback to a credentials chain for S3 access
|
|
chain := []credentials.Provider{
|
|
// configure based upon MINIO_ prefixed environment variables
|
|
&credentials.EnvMinio{},
|
|
// configure based upon AWS_ prefixed environment variables
|
|
&credentials.EnvAWS{},
|
|
// read credentials from MINIO_SHARED_CREDENTIALS_FILE
|
|
// environment variable, or default json config files
|
|
&credentials.FileMinioClient{},
|
|
// read credentials from AWS_SHARED_CREDENTIALS_FILE
|
|
// environment variable, or default credentials file
|
|
&credentials.FileAWSCredentials{},
|
|
// read IAM role from EC2 metadata endpoint if available
|
|
&credentials.IAM{
|
|
// passing in an empty Endpoint lets the IAM Provider
|
|
// decide which endpoint to resolve internally
|
|
Endpoint: config.IamEndpoint,
|
|
Client: &http.Client{
|
|
Transport: http.DefaultTransport,
|
|
},
|
|
},
|
|
}
|
|
return credentials.NewChainCredentials(chain)
|
|
}
|
|
|
|
// Open opens a file
|
|
func (m *MinioStorage) Open(path string) (Object, error) {
|
|
opts := minio.GetObjectOptions{}
|
|
object, err := m.client.GetObject(m.ctx, m.bucket, m.buildMinioPath(path), opts)
|
|
if err != nil {
|
|
return nil, convertMinioErr(err)
|
|
}
|
|
return &minioObject{object}, nil
|
|
}
|
|
|
|
// Save saves a file to minio
|
|
func (m *MinioStorage) Save(path string, r io.Reader, size int64) (int64, error) {
|
|
uploadInfo, err := m.client.PutObject(
|
|
m.ctx,
|
|
m.bucket,
|
|
m.buildMinioPath(path),
|
|
r,
|
|
size,
|
|
minio.PutObjectOptions{
|
|
ContentType: "application/octet-stream",
|
|
// some storages like:
|
|
// * https://developers.cloudflare.com/r2/api/s3/api/
|
|
// * https://www.backblaze.com/b2/docs/s3_compatible_api.html
|
|
// do not support "x-amz-checksum-algorithm" header, so use legacy MD5 checksum
|
|
SendContentMd5: m.cfg.ChecksumAlgorithm == "md5",
|
|
|
|
// with an unknown size (-1) minio-go assumes a 5TiB object and buffers a 528MiB part for it, even
|
|
// for a payload of a few KiB, so pin the part size there, a known size derives its own
|
|
PartSize: util.Iif[uint64](size < 0, unknownSizePartSize, 0),
|
|
},
|
|
)
|
|
if err != nil {
|
|
return 0, convertMinioErr(err)
|
|
}
|
|
return uploadInfo.Size, nil
|
|
}
|
|
|
|
type minioFileInfo struct {
|
|
minio.ObjectInfo
|
|
}
|
|
|
|
func (m minioFileInfo) Name() string {
|
|
return path.Base(m.ObjectInfo.Key)
|
|
}
|
|
|
|
func (m minioFileInfo) Size() int64 {
|
|
return m.ObjectInfo.Size
|
|
}
|
|
|
|
func (m minioFileInfo) ModTime() time.Time {
|
|
return m.LastModified
|
|
}
|
|
|
|
func (m minioFileInfo) IsDir() bool {
|
|
return strings.HasSuffix(m.ObjectInfo.Key, "/")
|
|
}
|
|
|
|
func (m minioFileInfo) Mode() os.FileMode {
|
|
return os.ModePerm
|
|
}
|
|
|
|
func (m minioFileInfo) Sys() any {
|
|
return nil
|
|
}
|
|
|
|
// Stat returns the stat information of the object
|
|
func (m *MinioStorage) Stat(path string) (os.FileInfo, error) {
|
|
info, err := m.client.StatObject(
|
|
m.ctx,
|
|
m.bucket,
|
|
m.buildMinioPath(path),
|
|
minio.StatObjectOptions{},
|
|
)
|
|
if err != nil {
|
|
return nil, convertMinioErr(err)
|
|
}
|
|
return &minioFileInfo{info}, nil
|
|
}
|
|
|
|
// Delete delete a file
|
|
func (m *MinioStorage) Delete(path string) error {
|
|
err := m.client.RemoveObject(m.ctx, m.bucket, m.buildMinioPath(path), minio.RemoveObjectOptions{})
|
|
|
|
return convertMinioErr(err)
|
|
}
|
|
|
|
func (m *MinioStorage) ServeDirectURL(storePath, name, method string, opt *ServeDirectOptions) (*url.URL, error) {
|
|
reqParams := url.Values{}
|
|
|
|
param := prepareServeDirectOptions(opt, name)
|
|
// minio does not ignore empty params
|
|
if param.ContentType != "" {
|
|
reqParams.Set("response-content-type", param.ContentType)
|
|
}
|
|
if param.ContentDisposition != "" {
|
|
reqParams.Set("response-content-disposition", param.ContentDisposition)
|
|
}
|
|
|
|
expires := 5 * time.Minute
|
|
if method == http.MethodHead {
|
|
u, err := m.client.PresignedHeadObject(m.ctx, m.bucket, m.buildMinioPath(storePath), expires, reqParams)
|
|
return u, convertMinioErr(err)
|
|
}
|
|
u, err := m.client.PresignedGetObject(m.ctx, m.bucket, m.buildMinioPath(storePath), expires, reqParams)
|
|
return u, convertMinioErr(err)
|
|
}
|
|
|
|
func (m *MinioStorage) IterateObjects(dirName string, fn func(path string, obj Object) error) error {
|
|
basePrefix := m.buildMinioDirPrefix("")
|
|
dirPrefix := m.buildMinioDirPrefix(dirName)
|
|
callback := func(object *minio.Object, objPath string) error {
|
|
defer object.Close()
|
|
return fn(objPath, &minioObject{object})
|
|
}
|
|
|
|
ctxList, ctxListCancel := context.WithCancel(m.ctx)
|
|
defer ctxListCancel() // ListObjectsIter: make sure to cancel the passed context, without that you might leak coroutines
|
|
|
|
getOpts := minio.GetObjectOptions{}
|
|
listOpts := minio.ListObjectsOptions{Prefix: dirPrefix, Recursive: true}
|
|
for mObjInfo := range m.client.ListObjectsIter(ctxList, m.bucket, listOpts) {
|
|
object, err := m.client.GetObject(m.ctx, m.bucket, mObjInfo.Key, getOpts)
|
|
if err != nil {
|
|
return convertMinioErr(err)
|
|
}
|
|
objPath := strings.TrimPrefix(mObjInfo.Key, basePrefix)
|
|
if err := callback(object, objPath); err != nil {
|
|
return convertMinioErr(err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func init() {
|
|
RegisterStorageType(setting.MinioStorageType, NewMinioStorage)
|
|
}
|