Artem Lytkin c8660364d9 fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073) ...

With SIGNING_FORMAT = ssh the OpenPGP verification path builds its
GPGSettings from the instance signing key but leaves the format empty,
so it runs `gpg -a --export` on an SSH public key path. Depending on the
local gpg setup that either exports nothing, so an OpenPGP signed commit
reports gpg.error.generate_hash instead of a missing key, or it fails
outright and logs an export error for every such commit.

Both guards are needed. The first covers SIGNING_KEY set to a path with
SIGNING_FORMAT=ssh; the second covers the shipped default
SIGNING_KEY=default, where the format comes from git's own gpg.format
and never gets reconciled with the hardcoded "openpgp". Drop either one
and a working config goes back to broken.

Also raise minimum git version to 2.18 which was already required before this change.

Fixes: https://github.com/go-gitea/gitea/issues/37452
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>

2026-08-25 12:02:31 +00:00

..

attribute

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

foreachref

fix(release): separate publication time from the release date (#36761)

2026-08-22 08:59:37 +00:00

gitcmd

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

gitrepo

refactor: hide git repo path details from more packages (#38601)

2026-07-23 17:42:55 +00:00

internal

…

languagestats

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

pipeline

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

tests/repos

refactor: git repo and relative path handling (#38522)

2026-07-19 07:32:00 +00:00

url

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

archive_test.go

fix(repo): avoid a repo-sized temp file for every bundle download (#38863)

2026-08-11 16:33:15 +00:00

archive.go

fix(repo): avoid a repo-sized temp file for every bundle download (#38863)

2026-08-11 16:33:15 +00:00

blame_sha256_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

blame_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

blame.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

blob_gogit.go

refactor: remove Ctx field from git.Repository (#38500)

2026-07-17 18:44:31 +08:00

blob_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

blob_test.go

fix: git diff blob excerpt (#38808)

2026-08-07 02:44:55 +00:00

blob.go

fix: git diff blob excerpt (#38808)

2026-08-07 02:44:55 +00:00

branch.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

catfile_batch_command.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

catfile_batch_legacy.go

refactor: use WithRepo instead of WithDir for most git operations, clean up model migrations (#38555)

2026-07-21 12:18:00 +00:00

catfile_batch_reader.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

catfile_batch_test.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

catfile_batch.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

clone.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

cmdverb.go

Fix a bug when uploading file via lfs ssh command (#34408)

2025-05-09 16:17:08 +00:00

commit2_test.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

commit2.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

commit_convert_gogit.go

fix: Invalid UTF-8 commit messages in JSON API responses (#37542)

2026-05-07 16:19:45 +02:00

commit_count_cache.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

commit_file_test.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

commit_file.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

commit_info_gogit.go

chore: enable forcetypeassert linter, fix issues (#38804)

2026-08-09 10:25:06 +00:00

commit_info_nogogit_test.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

commit_info_nogogit.go

fix: repo home page 500 due to the timeout of "get last commit info" (#38678)

2026-07-28 19:12:53 +08:00

commit_info_test.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

commit_info.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

commit_message_test.go

fix(git): parse co-author trailers that are not RFC 5322 addresses (#39076)

2026-08-24 19:06:30 +00:00

commit_message.go

fix(git): parse co-author trailers that are not RFC 5322 addresses (#39076)

2026-08-24 19:06:30 +00:00

commit_reader.go

refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)

2026-07-15 17:30:01 +00:00

commit_sha256_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

commit_submodule_file_test.go

Fix various bugs (#35177)

2025-07-30 07:08:59 +00:00

commit_submodule_file.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

commit_submodule.go

refactor: remove Ctx field from git.Repository (#38500)

2026-07-17 18:44:31 +08:00

commit_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

commit.go

chore: misc go 1.27 tweaks (#39069)

2026-08-24 18:26:10 +00:00

compare_test.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

compare.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

config_managed.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

config_submodule_test.go

…

config_submodule.go

…

config_test.go

enhance: allow builtin default git config options to be overridden (#38172)

2026-06-22 18:29:06 +00:00

config.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00

diff2.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

diff_test.go

Run gopls modernize on codebase (#34751)

2025-06-18 01:48:09 +00:00

diff.go

refactor: remove Path field from git.Repository (#38552)

2026-07-20 18:03:28 +00:00

error.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

fastimport.go

enhance: fall back to DEFAULT_TEMPLATE.md when style-specific template is missing (#38803)

2026-08-07 14:11:03 +00:00

fetch.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

fsck.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

git_test.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

git.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00

gitrepo.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

gpg_test.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00

gpg.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00

grep_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

grep.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

hook.go

refactor: retry file remove/rename when a file is busy and clean up os detection (#38588)

2026-07-23 14:31:29 +00:00

hooks_test.go

fix(git): restrict hook permissions (#39008)

2026-08-21 07:52:23 +00:00

hooks.go

fix(git): restrict hook permissions (#39008)

2026-08-21 07:52:23 +00:00

key.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00

last_commit_cache_gogit.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

last_commit_cache_nogogit.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

last_commit_cache.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

localfs.go

refactor: hide git repo path details from more packages (#38601)

2026-07-23 17:42:55 +00:00

log_name_status_nogogit.go

refactor: remove Path field from git.Repository (#38552)

2026-07-20 18:03:28 +00:00

main_test.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

merge_tree_test.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

merge_tree.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

merge.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

notes_test.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

notes.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

object_format.go

enhance(repo): add default object format setting (#38877)

2026-08-12 16:12:57 +00:00

object_id_gogit.go

…

object_id_test.go

enhance(repo): add default object format setting (#38877)

2026-08-12 16:12:57 +00:00

object_id.go

chore: fix git commit "rev-list" (#38069)

2026-06-11 18:08:55 +00:00

parse_treeentry_test.go

refactor: simplify ParseCatFileTreeLine and catBatchParseTreeEntries (#37210)

2026-04-14 12:03:26 +00:00

parse_treeentry.go

fix: catch and fix more lint problems (#37674)

2026-05-13 09:00:41 +02:00

parse.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

push.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

redirection.go

fix: revert git clone http redirection forbidden (#38530)

2026-07-20 10:04:23 +00:00

ref_test.go

feat(api): support ref suffixes in compare (#38148)

2026-06-24 05:38:02 +00:00

ref.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

remote_managed.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

remote.go

refactor: remove unnecessary git command wrapper functions (#38531)

2026-07-20 03:17:25 +00:00

repo_base_gogit.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

repo_base_nogogit_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_base_nogogit.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_blob_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_blob.go

Fix panic when get editor config file (#36241)

2025-12-25 19:26:23 -08:00

repo_branch_gogit.go

refactor: remove Ctx field from git.Repository (#38500)

2026-07-17 18:44:31 +08:00

repo_branch_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_branch_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_branch.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_commit_gogit.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_commit_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_commit_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_commit.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_commitgraph_gogit.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

repo_commitgraph.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00

repo_compare_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_compare.go

refactor: hide git repo path details from more packages (#38601)

2026-07-23 17:42:55 +00:00

repo_index.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_object.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_ref_gogit.go

refactor: remove Path field from git.Repository (#38552)

2026-07-20 18:03:28 +00:00

repo_ref_nogogit.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_ref_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_ref.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_stats_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_stats.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_tag_gogit.go

refactor: remove Ctx field from git.Repository (#38500)

2026-07-17 18:44:31 +08:00

repo_tag_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_tag_test.go

fix(release): separate publication time from the release date (#36761)

2026-08-22 08:59:37 +00:00

repo_tag.go

fix(release): separate publication time from the release date (#36761)

2026-08-22 08:59:37 +00:00

repo_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_tree_gogit.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo_tree_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

repo_tree.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

repo.go

fix: git cache (#38763)

2026-08-05 00:17:07 +08:00

signature_gogit.go

…

signature_nogogit.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

signature_test.go

…

signature.go

chore: Move import path from code.gitea.io/gitea to gitea.dev (#37873)

2026-05-26 15:49:31 -07:00

size.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

submodule_test.go

refactor: use WithRepo instead of WithDir for most git operations, clean up model migrations (#38555)

2026-07-21 12:18:00 +00:00

submodule.go

refactor: clean up git repo and model migration packages (#38564)

2026-07-23 01:22:26 +00:00

tag_test.go

fix: Invalid UTF-8 commit messages in JSON API responses (#37542)

2026-05-07 16:19:45 +02:00

tag.go

fix(release): separate publication time from the release date (#36761)

2026-08-22 08:59:37 +00:00

tree_blob_gogit.go

refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)

2026-07-15 17:30:01 +00:00

tree_blob_nogogit.go

refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)

2026-07-15 17:30:01 +00:00

tree_blob.go

refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)

2026-07-15 17:30:01 +00:00

tree_entry_common_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

tree_entry_gogit_test.go

fix: catch and fix more lint problems (#37674)

2026-05-13 09:00:41 +02:00

tree_entry_gogit.go

refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)

2026-07-15 17:30:01 +00:00

tree_entry_mode.go

refactor: simplify ParseCatFileTreeLine and catBatchParseTreeEntries (#37210)

2026-04-14 12:03:26 +00:00

tree_entry_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

tree_entry_test.go

refactor: simplify ParseCatFileTreeLine and catBatchParseTreeEntries (#37210)

2026-04-14 12:03:26 +00:00

tree_entry.go

refactor: remove Ctx field from git.Repository (#38500)

2026-07-17 18:44:31 +08:00

tree_gogit.go

refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)

2026-07-15 17:30:01 +00:00

tree_nogogit.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

tree_test.go

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

2026-07-28 17:04:22 +00:00

tree.go

refactor: make git package handle all git operations (#38543)

2026-07-20 16:07:38 +00:00

utils_test.go

Fix various bugs (#35177)

2025-07-30 07:08:59 +00:00

utils.go

fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (#39073)

2026-08-25 12:02:31 +00:00