mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-29 04:53:26 +00:00
Adds bulk actions on the site-admin runner list (`/-/admin/actions/runners`). Site admins can now select multiple runners and **Delete**, **Disable**, or **Enable** them in one go instead of clicking through each runner's edit page. Scope is intentionally limited to the admin page. The user, org, and repo runner pages keep their existing per-row UX — the shared list template gates the bulk UI behind an `AllowBulkActions` flag set only by the admin handler. ## Screenshots <img width="1582" height="353" src="https://github.com/user-attachments/assets/2125661f-aac0-4168-990a-97995a26abd2" /> --------- Signed-off-by: Nicolas <bircni@icloud.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
470 lines
13 KiB
Go
470 lines
13 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
stdctx "context"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
actions_model "gitea.dev/models/actions"
|
|
"gitea.dev/models/db"
|
|
"gitea.dev/modules/log"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/templates"
|
|
"gitea.dev/modules/util"
|
|
"gitea.dev/modules/web"
|
|
shared_user "gitea.dev/routers/web/shared/user"
|
|
"gitea.dev/services/context"
|
|
"gitea.dev/services/forms"
|
|
)
|
|
|
|
const (
|
|
// TODO: Separate secrets from runners when layout is ready
|
|
tplRepoRunners templates.TplName = "repo/settings/actions"
|
|
tplOrgRunners templates.TplName = "org/settings/actions"
|
|
tplAdminRunners templates.TplName = "admin/actions"
|
|
tplUserRunners templates.TplName = "user/settings/actions"
|
|
tplRepoRunnerEdit templates.TplName = "repo/settings/runner_edit"
|
|
tplOrgRunnerEdit templates.TplName = "org/settings/runners_edit"
|
|
tplAdminRunnerEdit templates.TplName = "admin/runners/edit"
|
|
tplUserRunnerEdit templates.TplName = "user/settings/runner_edit"
|
|
)
|
|
|
|
type runnersCtx struct {
|
|
OwnerID int64
|
|
RepoID int64
|
|
IsRepo bool
|
|
IsOrg bool
|
|
IsAdmin bool
|
|
IsUser bool
|
|
RunnersTemplate templates.TplName
|
|
RunnerEditTemplate templates.TplName
|
|
RedirectLink string
|
|
}
|
|
|
|
func getRunnersCtx(ctx *context.Context) (*runnersCtx, error) {
|
|
if ctx.Data["PageIsRepoSettings"] == true {
|
|
return &runnersCtx{
|
|
RepoID: ctx.Repo.Repository.ID,
|
|
OwnerID: 0,
|
|
IsRepo: true,
|
|
RunnersTemplate: tplRepoRunners,
|
|
RunnerEditTemplate: tplRepoRunnerEdit,
|
|
RedirectLink: ctx.Repo.RepoLink + "/settings/actions/runners/",
|
|
}, nil
|
|
}
|
|
|
|
if ctx.Data["PageIsOrgSettings"] == true {
|
|
if _, err := shared_user.RenderUserOrgHeader(ctx); err != nil {
|
|
return nil, fmt.Errorf("RenderUserOrgHeader: %w", err)
|
|
}
|
|
return &runnersCtx{
|
|
RepoID: 0,
|
|
OwnerID: ctx.Org.Organization.ID,
|
|
IsOrg: true,
|
|
RunnersTemplate: tplOrgRunners,
|
|
RunnerEditTemplate: tplOrgRunnerEdit,
|
|
RedirectLink: ctx.Org.OrgLink + "/settings/actions/runners/",
|
|
}, nil
|
|
}
|
|
|
|
if ctx.Data["PageIsAdmin"] == true {
|
|
return &runnersCtx{
|
|
RepoID: 0,
|
|
OwnerID: 0,
|
|
IsAdmin: true,
|
|
RunnersTemplate: tplAdminRunners,
|
|
RunnerEditTemplate: tplAdminRunnerEdit,
|
|
RedirectLink: setting.AppSubURL + "/-/admin/actions/runners/",
|
|
}, nil
|
|
}
|
|
|
|
if ctx.Data["PageIsUserSettings"] == true {
|
|
return &runnersCtx{
|
|
OwnerID: ctx.Doer.ID,
|
|
RepoID: 0,
|
|
IsUser: true,
|
|
RunnersTemplate: tplUserRunners,
|
|
RunnerEditTemplate: tplUserRunnerEdit,
|
|
RedirectLink: setting.AppSubURL + "/user/settings/actions/runners/",
|
|
}, nil
|
|
}
|
|
|
|
return nil, errors.New("unable to set Runners context")
|
|
}
|
|
|
|
// Runners render settings/actions/runners page for repo level
|
|
func Runners(ctx *context.Context) {
|
|
ctx.Data["PageIsSharedSettingsRunners"] = true
|
|
ctx.Data["Title"] = ctx.Tr("actions.actions")
|
|
ctx.Data["PageType"] = "runners"
|
|
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
page := max(ctx.FormInt("page"), 1)
|
|
|
|
opts := actions_model.FindRunnerOptions{
|
|
ListOptions: db.ListOptions{
|
|
Page: page,
|
|
PageSize: 100,
|
|
},
|
|
Sort: ctx.Req.URL.Query().Get("sort"),
|
|
Filter: ctx.Req.URL.Query().Get("q"),
|
|
}
|
|
if rCtx.IsRepo {
|
|
opts.RepoID = rCtx.RepoID
|
|
opts.WithAvailable = true
|
|
} else if rCtx.IsOrg || rCtx.IsUser {
|
|
opts.OwnerID = rCtx.OwnerID
|
|
opts.WithAvailable = true
|
|
}
|
|
|
|
runners, count, err := db.FindAndCount[actions_model.ActionRunner](ctx, opts)
|
|
if err != nil {
|
|
ctx.ServerError("CountRunners", err)
|
|
return
|
|
}
|
|
|
|
if err := actions_model.RunnerList(runners).LoadAttributes(ctx); err != nil {
|
|
ctx.ServerError("LoadAttributes", err)
|
|
return
|
|
}
|
|
|
|
// ownid=0,repo_id=0,means this token is used for global
|
|
var token *actions_model.ActionRunnerToken
|
|
token, err = actions_model.GetLatestRunnerToken(ctx, opts.OwnerID, opts.RepoID)
|
|
if errors.Is(err, util.ErrNotExist) || (token != nil && !token.IsActive) {
|
|
token, err = actions_model.NewRunnerToken(ctx, opts.OwnerID, opts.RepoID)
|
|
if err != nil {
|
|
ctx.ServerError("CreateRunnerToken", err)
|
|
return
|
|
}
|
|
} else if err != nil {
|
|
ctx.ServerError("GetLatestRunnerToken", err)
|
|
return
|
|
}
|
|
|
|
ctx.Data["Keyword"] = opts.Filter
|
|
ctx.Data["Runners"] = runners
|
|
ctx.Data["Total"] = count
|
|
ctx.Data["RegistrationToken"] = token.Token
|
|
ctx.Data["RunnerOwnerID"] = opts.OwnerID
|
|
ctx.Data["RunnerRepoID"] = opts.RepoID
|
|
ctx.Data["SortType"] = opts.Sort
|
|
ctx.Data["AllowBulkActions"] = rCtx.IsAdmin
|
|
|
|
pager := context.NewPagination(count, opts.PageSize, opts.Page, 5)
|
|
|
|
ctx.Data["Page"] = pager
|
|
|
|
ctx.HTML(http.StatusOK, rCtx.RunnersTemplate)
|
|
}
|
|
|
|
// RunnersEdit renders runner edit page for repository level
|
|
func RunnersEdit(ctx *context.Context) {
|
|
ctx.Data["PageIsSharedSettingsRunners"] = true
|
|
ctx.Data["Title"] = ctx.Tr("actions.runners.edit_runner")
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
page := max(ctx.FormInt("page"), 1)
|
|
|
|
runnerID := ctx.PathParamInt64("runnerid")
|
|
ownerID := rCtx.OwnerID
|
|
repoID := rCtx.RepoID
|
|
|
|
runner, err := actions_model.GetRunnerByID(ctx, runnerID)
|
|
if err != nil {
|
|
ctx.ServerError("GetRunnerByID", err)
|
|
return
|
|
}
|
|
if err := runner.LoadAttributes(ctx); err != nil {
|
|
ctx.ServerError("LoadAttributes", err)
|
|
return
|
|
}
|
|
if !runner.EditableInContext(ownerID, repoID) {
|
|
err = errors.New("no permission to edit this runner")
|
|
ctx.NotFound(err)
|
|
return
|
|
}
|
|
|
|
ctx.Data["Runner"] = runner
|
|
|
|
opts := actions_model.FindTaskOptions{
|
|
ListOptions: db.ListOptions{
|
|
Page: page,
|
|
PageSize: 30,
|
|
},
|
|
Status: actions_model.StatusUnknown, // Unknown means all
|
|
RunnerID: runner.ID,
|
|
}
|
|
|
|
tasks, count, err := db.FindAndCount[actions_model.ActionTask](ctx, opts)
|
|
if err != nil {
|
|
ctx.ServerError("CountTasks", err)
|
|
return
|
|
}
|
|
|
|
if err = actions_model.TaskList(tasks).LoadAttributes(ctx); err != nil {
|
|
ctx.ServerError("TasksLoadAttributes", err)
|
|
return
|
|
}
|
|
|
|
ctx.Data["Tasks"] = tasks
|
|
pager := context.NewPagination(count, opts.PageSize, opts.Page, 5)
|
|
ctx.Data["Page"] = pager
|
|
|
|
ctx.HTML(http.StatusOK, rCtx.RunnerEditTemplate)
|
|
}
|
|
|
|
func RunnersEditPost(ctx *context.Context) {
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
runnerID := ctx.PathParamInt64("runnerid")
|
|
ownerID := rCtx.OwnerID
|
|
repoID := rCtx.RepoID
|
|
redirectTo := rCtx.RedirectLink
|
|
|
|
runner, err := actions_model.GetRunnerByID(ctx, runnerID)
|
|
if err != nil {
|
|
log.Warn("RunnerDetailsEditPost.GetRunnerByID failed: %v, url: %s", err, ctx.Req.URL)
|
|
ctx.ServerError("RunnerDetailsEditPost.GetRunnerByID", err)
|
|
return
|
|
}
|
|
if !runner.EditableInContext(ownerID, repoID) {
|
|
ctx.NotFound(util.NewPermissionDeniedErrorf("no permission to edit this runner"))
|
|
return
|
|
}
|
|
|
|
form := web.GetForm(ctx).(*forms.EditRunnerForm)
|
|
runner.Description = form.Description
|
|
|
|
err = actions_model.UpdateRunner(ctx, runner, "description")
|
|
if err != nil {
|
|
log.Warn("RunnerDetailsEditPost.UpdateRunner failed: %v, url: %s", err, ctx.Req.URL)
|
|
ctx.Flash.Warning(ctx.Tr("actions.runners.update_runner_failed"))
|
|
ctx.Redirect(redirectTo)
|
|
return
|
|
}
|
|
|
|
log.Debug("RunnerDetailsEditPost success: %s", ctx.Req.URL)
|
|
|
|
ctx.Flash.Success(ctx.Tr("actions.runners.update_runner_success"))
|
|
ctx.Redirect(redirectTo)
|
|
}
|
|
|
|
func ResetRunnerRegistrationToken(ctx *context.Context) {
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
ownerID := rCtx.OwnerID
|
|
repoID := rCtx.RepoID
|
|
redirectTo := rCtx.RedirectLink
|
|
|
|
if _, err := actions_model.NewRunnerToken(ctx, ownerID, repoID); err != nil {
|
|
ctx.ServerError("ResetRunnerRegistrationToken", err)
|
|
return
|
|
}
|
|
ctx.Flash.Success(ctx.Tr("actions.runners.reset_registration_token_success"))
|
|
ctx.JSONRedirect(redirectTo)
|
|
}
|
|
|
|
// RunnerDeletePost response for deleting runner
|
|
func RunnerDeletePost(ctx *context.Context) {
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
runner := findActionsRunner(ctx, rCtx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if !runner.EditableInContext(rCtx.OwnerID, rCtx.RepoID) {
|
|
ctx.NotFound(util.NewPermissionDeniedErrorf("no permission to delete this runner"))
|
|
return
|
|
}
|
|
|
|
successRedirectTo := rCtx.RedirectLink
|
|
failedRedirectTo := rCtx.RedirectLink + url.PathEscape(ctx.PathParam("runnerid"))
|
|
|
|
if err := actions_model.DeleteRunner(ctx, runner.ID); err != nil {
|
|
log.Warn("DeleteRunnerPost.UpdateRunner failed: %v, url: %s", err, ctx.Req.URL)
|
|
ctx.Flash.Warning(ctx.Tr("actions.runners.delete_runner_failed"))
|
|
|
|
ctx.JSONRedirect(failedRedirectTo)
|
|
return
|
|
}
|
|
|
|
log.Info("DeleteRunnerPost success: %s", ctx.Req.URL)
|
|
|
|
ctx.Flash.Success(ctx.Tr("actions.runners.delete_runner_success"))
|
|
|
|
ctx.JSONRedirect(successRedirectTo)
|
|
}
|
|
|
|
func RunnerUpdatePost(ctx *context.Context) {
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
runner := findActionsRunner(ctx, rCtx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if !runner.EditableInContext(rCtx.OwnerID, rCtx.RepoID) {
|
|
ctx.NotFound(util.NewPermissionDeniedErrorf("no permission to edit this runner"))
|
|
return
|
|
}
|
|
|
|
isDisabled := ctx.FormOptionalBool("disabled")
|
|
if !isDisabled.Has() {
|
|
ctx.HTTPError(http.StatusBadRequest, "missing 'disabled' parameter")
|
|
return
|
|
}
|
|
|
|
successKey := "actions.runners.enable_runner_success"
|
|
failedKey := "actions.runners.enable_runner_failed"
|
|
if isDisabled.Value() {
|
|
successKey = "actions.runners.disable_runner_success"
|
|
failedKey = "actions.runners.disable_runner_failed"
|
|
}
|
|
|
|
if err := actions_model.SetRunnerDisabled(ctx, runner, isDisabled.Value()); err != nil {
|
|
log.Warn("RunnerUpdatePost.SetRunnerDisabled failed: %v, url: %s", err, ctx.Req.URL)
|
|
ctx.Flash.Error(ctx.Tr(failedKey))
|
|
ctx.JSONRedirect("")
|
|
return
|
|
}
|
|
|
|
ctx.Flash.Success(ctx.Tr(successKey))
|
|
ctx.JSONRedirect("")
|
|
}
|
|
|
|
// RunnerBulkActionPost performs a bulk action (delete/disable/enable) on multiple runners.
|
|
// Admin-only: route must be mounted inside the admin runners group; defense-in-depth check below.
|
|
func RunnerBulkActionPost(ctx *context.Context) {
|
|
rCtx, err := getRunnersCtx(ctx)
|
|
if err != nil {
|
|
ctx.ServerError("getRunnersCtx", err)
|
|
return
|
|
}
|
|
|
|
var runnerIDs []int64
|
|
if rCtx.IsAdmin {
|
|
// ATTENTION: it completely depends on the assumption that the doer is "site admin"
|
|
// So it doesn't do extra permission check to the runner IDs
|
|
// In the future, if you need to support such operation on non-admin pages, be careful!
|
|
runnerIDs = ctx.FormStringInt64s("ids")
|
|
} else {
|
|
ctx.HTTPError(http.StatusForbidden, "bulk actions are admin-only")
|
|
return
|
|
}
|
|
|
|
action := ctx.FormString("action")
|
|
var successKey, failedKey string
|
|
switch action {
|
|
case "delete":
|
|
successKey, failedKey = "actions.runners.delete_runner_success", "actions.runners.delete_runner_failed"
|
|
case "disable":
|
|
successKey, failedKey = "actions.runners.disable_runner_success", "actions.runners.disable_runner_failed"
|
|
case "enable":
|
|
successKey, failedKey = "actions.runners.enable_runner_success", "actions.runners.enable_runner_failed"
|
|
default:
|
|
ctx.HTTPError(http.StatusBadRequest, "invalid action")
|
|
return
|
|
}
|
|
|
|
runners, err := db.Find[actions_model.ActionRunner](ctx, &actions_model.FindRunnerOptions{IDs: runnerIDs})
|
|
if err != nil {
|
|
ctx.ServerError("FindRunners", err)
|
|
return
|
|
}
|
|
|
|
err = db.WithTx(ctx, func(txCtx stdctx.Context) error {
|
|
for _, r := range runners {
|
|
switch action {
|
|
case "delete":
|
|
if err := actions_model.DeleteRunner(txCtx, r.ID); err != nil {
|
|
return err
|
|
}
|
|
case "disable":
|
|
if err := actions_model.SetRunnerDisabled(txCtx, r, true); err != nil {
|
|
return err
|
|
}
|
|
case "enable":
|
|
if err := actions_model.SetRunnerDisabled(txCtx, r, false); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
log.Warn("RunnerBulkActionPost.%s failed: %v, url: %s", action, err, ctx.Req.URL)
|
|
ctx.Flash.Error(ctx.Tr(failedKey))
|
|
ctx.JSONRedirect(rCtx.RedirectLink)
|
|
return
|
|
}
|
|
|
|
ctx.Flash.Success(ctx.Tr(successKey))
|
|
ctx.JSONRedirect(rCtx.RedirectLink)
|
|
}
|
|
|
|
func findActionsRunner(ctx *context.Context, rCtx *runnersCtx) *actions_model.ActionRunner {
|
|
runnerID := ctx.PathParamInt64("runnerid")
|
|
opts := &actions_model.FindRunnerOptions{
|
|
IDs: []int64{runnerID},
|
|
}
|
|
switch {
|
|
case rCtx.IsRepo:
|
|
opts.RepoID = rCtx.RepoID
|
|
if opts.RepoID == 0 {
|
|
panic("repoID is 0")
|
|
}
|
|
case rCtx.IsOrg, rCtx.IsUser:
|
|
opts.OwnerID = rCtx.OwnerID
|
|
if opts.OwnerID == 0 {
|
|
panic("ownerID is 0")
|
|
}
|
|
case rCtx.IsAdmin:
|
|
// do nothing
|
|
default:
|
|
panic("invalid actions runner context")
|
|
}
|
|
|
|
got, err := db.Find[actions_model.ActionRunner](ctx, opts)
|
|
if err != nil {
|
|
ctx.ServerError("FindRunner", err)
|
|
return nil
|
|
} else if len(got) == 0 {
|
|
ctx.NotFound(errors.New("runner not found"))
|
|
return nil
|
|
}
|
|
|
|
return got[0]
|
|
}
|