mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-16 12:41:03 +00:00
Backport https://github.com/go-gitea/gitea/pull/39993 Gitea accepted unlimited wrong TOTP passcodes, so anyone holding an account's password could enumerate the 6-digit code in minutes. This allows 5 failed attempts per account, then refuses TOTP until 15 minutes after the last one. - The count lives in the cache, and the global lock spans the check, validation and counting, so new sessions and concurrent requests cannot widen it. With Redis, both are shared across instances - Applies to every TOTP check: the web 2FA page, account recovery and Basic auth with `X-Gitea-OTP` (API, git, packages) - Only wrong or replayed passcodes count, server errors do not - Scratch codes and WebAuthn stay usable as the recovery path while locked - Failures log `Failed authentication attempt for <user> from <ip>`, which the fail2ban filter already matches Co-authored-by: Sandiyo Christan <55909152+sandiyochristan@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
120 lines
4.0 KiB
Go
120 lines
4.0 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/pquerna/otp/totp"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPITwoFactor(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 16})
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
otpKey, err := totp.Generate(totp.GenerateOpts{
|
|
SecretSize: 40,
|
|
Issuer: "gitea-test",
|
|
AccountName: user.Name,
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
tfa := &auth_model.TwoFactor{
|
|
UID: user.ID,
|
|
}
|
|
assert.NoError(t, tfa.SetSecret(otpKey.Secret()))
|
|
|
|
assert.NoError(t, auth_model.NewTwoFactor(t.Context(), tfa))
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
passcode, err := totp.GenerateCode(otpKey.Secret(), time.Now())
|
|
assert.NoError(t, err)
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
req.Header.Set("X-Gitea-OTP", passcode)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
// the same passcode must not be replayable on the basic-auth surface (RFC 6238 single-use)
|
|
req = NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
req.Header.Set("X-Gitea-OTP", passcode)
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
for range 4 {
|
|
MakeRequest(t, NewRequest(t, "GET", "/api/v1/user").AddBasicAuth(user.Name).SetHeader("X-Gitea-OTP", "0000000"), http.StatusUnauthorized)
|
|
}
|
|
nextPasscode, err := totp.GenerateCode(otpKey.Secret(), time.Now().Add(30*time.Second))
|
|
assert.NoError(t, err)
|
|
resp := MakeRequest(t, NewRequest(t, "GET", "/api/v1/user").AddBasicAuth(user.Name).SetHeader("X-Gitea-OTP", nextPasscode), http.StatusUnauthorized)
|
|
assert.Contains(t, resp.Body.String(), "too many failed OTP attempts")
|
|
}
|
|
|
|
func TestBasicAuthWithWebAuthn(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// user1 has no webauthn enrolled, he can request API with basic auth
|
|
user1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
unittest.AssertNotExistsBean(t, &auth_model.WebAuthnCredential{UserID: user1.ID})
|
|
req := NewRequest(t, "GET", "/api/v1/user")
|
|
req.SetBasicAuth(user1.Name, "password")
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
// user1 has no webauthn enrolled, he can request git protocol with basic auth
|
|
req = NewRequest(t, "GET", "/user2/repo1/info/refs")
|
|
req.SetBasicAuth(user1.Name, "password")
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
// user1 has no webauthn enrolled, he can request container package with basic auth
|
|
req = NewRequest(t, "GET", "/v2/token")
|
|
req.SetBasicAuth(user1.Name, "password")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
type tokenResponse struct {
|
|
Token string `json:"token"`
|
|
}
|
|
tokenParsed := DecodeJSON(t, resp, &tokenResponse{})
|
|
assert.NotEmpty(t, tokenParsed.Token)
|
|
|
|
// user32 has webauthn enrolled, he can't request API with basic auth
|
|
user32 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 32})
|
|
unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{UserID: user32.ID})
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user")
|
|
req.SetBasicAuth(user32.Name, "notpassword")
|
|
resp = MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
type userResponse struct {
|
|
Message string `json:"message"`
|
|
}
|
|
userParsed := DecodeJSON(t, resp, &userResponse{})
|
|
assert.Equal(t, "basic authorization is not allowed while WebAuthn enrolled", userParsed.Message)
|
|
|
|
// user32 has webauthn enrolled, he can't request git protocol with basic auth
|
|
req = NewRequest(t, "GET", "/user2/repo1/info/refs")
|
|
req.SetBasicAuth(user32.Name, "notpassword")
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
// user32 has webauthn enrolled, he can't request container package with basic auth
|
|
req = NewRequest(t, "GET", "/v2/token")
|
|
req.SetBasicAuth(user1.Name, "notpassword")
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
}
|