diff --git a/routers/api/v1/user/star.go b/routers/api/v1/user/star.go index 146973021a5..26288161fd4 100644 --- a/routers/api/v1/user/star.go +++ b/routers/api/v1/user/star.go @@ -32,6 +32,9 @@ func getStarredRepos(ctx *context.APIContext, user *user_model.User, private boo if err != nil { return nil, err } + if err := repo_model.RepositoryList(starredRepos).LoadAttributes(ctx); err != nil { + return nil, err + } repos := make([]*api.Repository, 0, len(starredRepos)) for _, starred := range starredRepos { @@ -113,6 +116,7 @@ func GetMyStarredRepos(ctx *context.APIContext) { repos, err := getStarredRepos(ctx, ctx.Doer, true) if err != nil { ctx.APIErrorInternal(err) + return } ctx.SetLinkHeader(int64(ctx.Doer.NumStars), utils.GetListOptions(ctx).PageSize) diff --git a/routers/api/v1/user/watch.go b/routers/api/v1/user/watch.go index d5f3fc223ee..a37682c2997 100644 --- a/routers/api/v1/user/watch.go +++ b/routers/api/v1/user/watch.go @@ -30,6 +30,9 @@ func getWatchedRepos(ctx *context.APIContext, user *user_model.User, private boo if err != nil { return nil, 0, err } + if err := repo_model.RepositoryList(watchedRepos).LoadAttributes(ctx); err != nil { + return nil, 0, err + } repos := make([]*api.Repository, len(watchedRepos)) for i, watched := range watchedRepos { @@ -73,6 +76,7 @@ func GetWatchedRepos(ctx *context.APIContext) { repos, total, err := getWatchedRepos(ctx, ctx.ContextUser, private) if err != nil { ctx.APIErrorInternal(err) + return } ctx.SetLinkHeader(total, utils.GetListOptions(ctx).PageSize) @@ -103,6 +107,7 @@ func GetMyWatchedRepos(ctx *context.APIContext) { repos, total, err := getWatchedRepos(ctx, ctx.Doer, true) if err != nil { ctx.APIErrorInternal(err) + return } ctx.SetLinkHeader(total, utils.GetListOptions(ctx).PageSize) ctx.SetTotalCountHeader(total) diff --git a/tests/integration/api_user_star_test.go b/tests/integration/api_user_star_test.go index 7ea7f9f9715..79803a744e8 100644 --- a/tests/integration/api_user_star_test.go +++ b/tests/integration/api_user_star_test.go @@ -9,6 +9,7 @@ import ( "testing" auth_model "gitea.dev/models/auth" + "gitea.dev/models/db" "gitea.dev/models/perm" repo_model "gitea.dev/models/repo" "gitea.dev/models/unittest" @@ -206,6 +207,7 @@ func TestAPIStarDisabled(t *testing.T) { func TestAPIStarPublicOnly(t *testing.T) { defer tests.PrepareTestEnv(t)() + require.NoError(t, db.Insert(t.Context(), &repo_model.LanguageStat{RepoID: 4, IsPrimary: true, Language: "Go", Size: 1})) token := getUserToken(t, "user2", auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopeReadRepository, auth_model.AccessTokenScopePublicOnly) req := NewRequest(t, "GET", "/api/v1/user/starred"). @@ -215,6 +217,7 @@ func TestAPIStarPublicOnly(t *testing.T) { repos := DecodeJSON(t, resp, []api.Repository{}) if assert.Len(t, repos, 1) { assert.Equal(t, "user5/repo4", repos[0].FullName) + assert.Equal(t, "Go", repos[0].Language) } req = NewRequest(t, "GET", "/api/v1/users/user2/starred").