mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-09 08:02:27 +00:00
refactor: prepare vue components for vapor mode (#38798)
Removes what would block a later switch to Vue's vapor mode: `vue-chartjs` and the `SvgIcon` render function are virtual DOM components, and `v-memo` has no vapor equivalent. This does not adopt vapor mode, which will be stable in upcoming Vue 3.6. `vue-chartjs` was a thin wrapper over chart.js, so a local `ChartCanvas.vue` replaces it. Chart data and options move into computed values to keep their object identity, which is what `v-memo` was compensating for. `chartjs-adapter-dayjs-4` is moved first-party, just ~40 lines that are easy to maintain.
This commit is contained in:
@@ -0,0 +1,71 @@
|
||||
<script lang="ts" setup>
|
||||
import {onMounted, onUnmounted, toRaw, useTemplateRef, watch, type ShallowRef} from 'vue';
|
||||
import {_adapters, BarController, Chart, LinearScale, LineController, TimeScale, type ChartData, type ChartOptions, type TimeUnit} from 'chart.js';
|
||||
import {chartJsColors} from '../utils/color.ts';
|
||||
import dayjs from 'dayjs';
|
||||
import advancedFormat from 'dayjs/plugin/advancedFormat.js';
|
||||
import quarterOfYear from 'dayjs/plugin/quarterOfYear.js';
|
||||
import type {ConfigType, ManipulateType} from 'dayjs';
|
||||
|
||||
dayjs.extend(advancedFormat); // the quarter format needs the `Q` token
|
||||
dayjs.extend(quarterOfYear);
|
||||
|
||||
Chart.defaults.color = chartJsColors.text;
|
||||
Chart.defaults.borderColor = chartJsColors.border;
|
||||
Chart.register(BarController, LineController, LinearScale, TimeScale);
|
||||
|
||||
// minimal port of chartjs-adapter-dayjs-4, MIT license, Copyright (c) 2022 bolstycjw
|
||||
_adapters._date.override({
|
||||
formats: () => ({
|
||||
datetime: 'MMM D, YYYY, h:mm:ss a',
|
||||
millisecond: 'h:mm:ss.SSS a',
|
||||
second: 'h:mm:ss a',
|
||||
minute: 'h:mm a',
|
||||
hour: 'hA',
|
||||
day: 'MMM D',
|
||||
week: 'MMM D, YYYY',
|
||||
month: 'MMM YYYY',
|
||||
quarter: '[Q]Q - YYYY',
|
||||
year: 'YYYY',
|
||||
}),
|
||||
parse: (value: ConfigType) => {
|
||||
const date = dayjs(value);
|
||||
return date.isValid() ? date.valueOf() : null;
|
||||
},
|
||||
format: (time: number, format: string) => dayjs(time).format(format),
|
||||
add: (time: number, amount: number, unit: TimeUnit) => dayjs(time).add(amount, unit as ManipulateType).valueOf(), // the quarter plugin widens this at runtime
|
||||
diff: (max: number, min: number, unit: TimeUnit) => dayjs(max).diff(min, unit),
|
||||
// chart.js only asks for `isoWeek` when `time.isoWeekday` is set, which we never do
|
||||
startOf: (time: number, unit: TimeUnit) => dayjs(time).startOf(unit).valueOf(),
|
||||
endOf: (time: number, unit: TimeUnit) => dayjs(time).endOf(unit).valueOf(),
|
||||
});
|
||||
|
||||
const props = defineProps<{
|
||||
type: 'bar' | 'line',
|
||||
data: ChartData,
|
||||
options: ChartOptions,
|
||||
}>();
|
||||
|
||||
const elCanvas = useTemplateRef('elCanvas') as Readonly<ShallowRef<HTMLCanvasElement>>;
|
||||
let chart: Chart | undefined;
|
||||
|
||||
// chart.js mutates what it gets, so it must never see a reactive proxy
|
||||
onMounted(() => {
|
||||
chart = new Chart(elCanvas.value, {type: props.type, data: toRaw(props.data), options: toRaw(props.options)});
|
||||
});
|
||||
|
||||
onUnmounted(() => {
|
||||
chart?.destroy();
|
||||
});
|
||||
|
||||
watch([() => props.data, () => props.options], ([data, options]) => {
|
||||
if (!chart) return; // chart creation failed
|
||||
chart.data = toRaw(data);
|
||||
chart.options = toRaw(options);
|
||||
chart.update();
|
||||
});
|
||||
</script>
|
||||
|
||||
<template>
|
||||
<canvas ref="elCanvas" role="img"/>
|
||||
</template>
|
||||
Reference in New Issue
Block a user