From b0d6cc1d22be030304590583a9924f3ca3e51f4f Mon Sep 17 00:00:00 2001 From: Zain Qureshi <43629888+ZainnQureshii@users.noreply.github.com> Date: Thu, 1 Oct 2026 00:49:22 +0200 Subject: [PATCH] docs: correct three stale defaults in app.example.ini (#39500) Three commented defaults in `custom/conf/app.example.ini` differ from what Gitea actually uses, so the file says they default to something else: - `MINIMUM_KEY_SIZE_CHECK`: example `false`, code `true` (`modules/setting/ssh.go:55`, read at `:152`). - `SSH_SERVER_HOST_KEYS`: example lists `ssh/gitea.rsa, ssh/gogs.rsa`, code also loads `ssh/gitea.ed25519` and `ssh/gitea.ecdsa` (`modules/setting/ssh.go:57`). - `[queue] DATADIR`: example `queues/`, code `queues/common` (`modules/setting/queue.go:33`), which the comment above it already states. Co-authored-by: silverwind --- custom/conf/app.example.ini | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index 8431853e1d6..2dcbf66c8d7 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -198,7 +198,7 @@ ;; For the built-in SSH server, choose the keypair to offer as the host key ;; The private key should be at SSH_SERVER_HOST_KEY and the public SSH_SERVER_HOST_KEY.pub ;; relative paths are made absolute relative to the APP_DATA_PATH -;SSH_SERVER_HOST_KEYS=ssh/gitea.rsa, ssh/gogs.rsa +;SSH_SERVER_HOST_KEYS=ssh/gitea.rsa, ssh/gitea.ed25519, ssh/gitea.ecdsa, ssh/gogs.rsa ;; ;; Enable SSH Authorized Key Backup when rewriting all keys, default is false ;SSH_AUTHORIZED_KEYS_BACKUP = false @@ -237,7 +237,7 @@ ;SSH_PER_WRITE_PER_KB_TIMEOUT = 30s ;; ;; Indicate whether to check minimum key size with corresponding type -;MINIMUM_KEY_SIZE_CHECK = false +;MINIMUM_KEY_SIZE_CHECK = true ;; ;; TLS Settings: Either ACME or manual ;; (Other common TLS configuration are found before) @@ -1669,13 +1669,13 @@ LEVEL = Info ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; -;; General queue queue type, currently support: persistable-channel, channel, level, redis, dummy -;; default to persistable-channel -;TYPE = persistable-channel +;; General queue type, currently support: level, channel, redis, dummy +;; default to level +;TYPE = level ;; -;; data-dir for storing persistable queues and level queues, individual queues will default to `queues/common` meaning the queue is shared. +;; data-dir for storing level queues, individual queues will default to `queues/common` meaning the queue is shared. ;; Relative paths will be made absolute against "APP_DATA_PATH" -;DATADIR = queues/ +;DATADIR = queues/common ;; ;; Default queue length before a channel queue will block ;LENGTH = 100000 @@ -1683,7 +1683,7 @@ LEVEL = Info ;; Batch size to send for batched queues ;BATCH_LENGTH = 20 ;; -;; When `TYPE` is `persistable-channel`, this provides a directory for the underlying leveldb +;; When `TYPE` is `level`, this provides a directory for the underlying leveldb ;; or additional options of the form `leveldb://path/to/db?option=value&....`, and will override `DATADIR`. ;; When `TYPE` is `redis` and this is left empty, it falls back to the shared [redis] CONN_STR. ;CONN_STR =