refactor: remove Path field from git.Repository (#38552)

The "path" details should be hidden to other packages

By the way, fix a resource leaking in gogit's CommitNodeIndex
(the file was not closed in CacheCommit)
This commit is contained in:
wxiaoguang
2026-07-21 02:03:28 +08:00
committed by GitHub
parent 9dc04289aa
commit a4526d5a82
28 changed files with 146 additions and 107 deletions
+3 -3
View File
@@ -16,7 +16,7 @@ func GitHooks(ctx *context.Context) {
ctx.Data["Title"] = ctx.Tr("repo.settings.githooks")
ctx.Data["PageIsSettingsGitHooks"] = true
hooks, err := ctx.Repo.GitRepo.Hooks()
hooks, err := git.ListHooks(ctx.Repo.GitRepo)
if err != nil {
ctx.ServerError("Hooks", err)
return
@@ -32,7 +32,7 @@ func GitHooksEdit(ctx *context.Context) {
ctx.Data["PageIsSettingsGitHooks"] = true
name := ctx.PathParam("name")
hook, err := ctx.Repo.GitRepo.GetHook(name)
hook, err := git.GetHook(ctx.Repo.GitRepo, name)
if err != nil {
if err == git.ErrNotValidHook {
ctx.NotFound(err)
@@ -49,7 +49,7 @@ func GitHooksEdit(ctx *context.Context) {
// GitHooksEditPost response for editing a git hook of a repository
func GitHooksEditPost(ctx *context.Context) {
name := ctx.PathParam("name")
hook, err := ctx.Repo.GitRepo.GetHook(name)
hook, err := git.GetHook(ctx.Repo.GitRepo, name)
if err != nil {
if err == git.ErrNotValidHook {
ctx.NotFound(err)