fix(git): return no submodule web link when the URL cannot be parsed (#39274)

This commit is contained in:
KBS authored and GitHub committed 2026-10-04 13:40:27 +00:00
1 parent 6809ecf2d2
commit 9bb8751b29
2 files changed
+9 -2

No files matched your search

+2 -2
View File
@@ -46,11 +46,11 @@ func (sf *CommitSubmoduleFile) getWebLinkInTargetRepo(ctx context.Context, moreL
return &SubmoduleWebLink{RepoWebLink: targetLink, CommitWebLink: targetLink + moreLinkPath}
}
if !sf.parsed {
sf.parsed = true
parsedURL, err := giturl.ParseRepositoryURL(ctx, sf.refURL)
if err != nil {
return nil
return nil // do not mark as parsed, otherwise later calls would return a link with an empty target
}
sf.parsed = true
sf.parsedTargetLink = giturl.MakeRepositoryWebLink(parsedURL)
}
return &SubmoduleWebLink{RepoWebLink: sf.parsedTargetLink, CommitWebLink: sf.parsedTargetLink + moreLinkPath}