mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-16 15:01:03 +00:00
Backport https://github.com/go-gitea/gitea/pull/40219 levelqueue v0.5.1 fixes this upstream (https://gitea.com/lunny/levelqueue/pulls/8), so this now only bumps the dependency. A push wrote "high" before the payload, so an interrupted push left an id counted with no key. `LPop` then returned `ErrNotFound` without advancing "low" and the wrapper retried forever: nothing popped, no worker started, later items unreachable. All were only fixable by clearing the queue, losing the backlog: - https://github.com/go-gitea/gitea/issues/32006 — mail, 0 workers - https://github.com/go-gitea/gitea/issues/28919 — mirror, "already in queue" - https://github.com/go-gitea/gitea/issues/33862 — archives hanging - https://github.com/go-gitea/gitea/issues/33882 — self-healing request v0.5.1 writes counter and payload in one batch, moves the counters past missing keys, and repairs leftover unique-queue set entries, so affected instances recover on their next pop. No test: the behaviour lives in the dependency, which covers it in its own `recover_test.go`. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: William Desportes <williamdes@wdes.fr> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
8 files changed
+30
-152
No files matched your search
@@ -26,9 +26,9 @@ type baseLevelQueuePushPoper interface {
|
||||
|
||||
type baseLevelQueueCommonImpl struct {
|
||||
*baseQueueNotifiable
|
||||
length int
|
||||
internalFunc func() baseLevelQueuePushPoper
|
||||
muCommon *sync.Mutex
|
||||
length int
|
||||
internal baseLevelQueuePushPoper
|
||||
muCommon *sync.Mutex
|
||||
}
|
||||
|
||||
func (q *baseLevelQueueCommonImpl) PushItem(ctx context.Context, data []byte) error {
|
||||
@@ -38,11 +38,11 @@ func (q *baseLevelQueueCommonImpl) PushItem(ctx context.Context, data []byte) er
|
||||
defer q.muCommon.Unlock()
|
||||
}
|
||||
|
||||
cnt := int(q.internalFunc().Len())
|
||||
cnt := int(q.internal.Len())
|
||||
if cnt >= q.length {
|
||||
return true, nil, nil
|
||||
}
|
||||
retry, err = false, q.internalFunc().RPush(data)
|
||||
retry, err = false, q.internal.RPush(data)
|
||||
if err == levelqueue.ErrAlreadyInQueue {
|
||||
err = ErrAlreadyInQueue
|
||||
}
|
||||
@@ -61,7 +61,7 @@ func (q *baseLevelQueueCommonImpl) PopItem(ctx context.Context) ([]byte, error)
|
||||
defer q.muCommon.Unlock()
|
||||
}
|
||||
|
||||
data, err = q.internalFunc().LPop()
|
||||
data, err = q.internal.LPop()
|
||||
if err == levelqueue.ErrNotFound {
|
||||
return true, nil, nil
|
||||
}
|
||||
@@ -72,8 +72,8 @@ func (q *baseLevelQueueCommonImpl) PopItem(ctx context.Context) ([]byte, error)
|
||||
})
|
||||
}
|
||||
|
||||
func baseLevelQueueCommon(cfg *BaseConfig, mu *sync.Mutex, internalFunc func() baseLevelQueuePushPoper) *baseLevelQueueCommonImpl {
|
||||
return &baseLevelQueueCommonImpl{length: cfg.Length, muCommon: mu, internalFunc: internalFunc, baseQueueNotifiable: newBaseQueueNotifiable()}
|
||||
func baseLevelQueueCommon(cfg *BaseConfig, mu *sync.Mutex, internal baseLevelQueuePushPoper) *baseLevelQueueCommonImpl {
|
||||
return &baseLevelQueueCommonImpl{length: cfg.Length, muCommon: mu, internal: internal, baseQueueNotifiable: newBaseQueueNotifiable()}
|
||||
}
|
||||
|
||||
func prepareLevelDB(cfg *BaseConfig) (conn string, db *leveldb.DB, err error) {
|
||||
|
||||
Reference in new issue
Block a user