mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-13 02:51:01 +00:00
chore: enable forcetypeassert linter, fix issues (#38804)
Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert) linter to prevent unchecked type assertions. ~650 issues fixed, most fixes were clean, some use `setting.PanicInDevOrTesting`. The only behaviour changes are where code would previously send a 500 error or panic, a 4xx error is now emitted. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
@@ -78,10 +78,12 @@ func TestExternalMarkupRenderer(t *testing.T) {
|
||||
})
|
||||
|
||||
// above tested in-page rendering (no iframe), then we test iframe mode below
|
||||
r := markup.DetectRendererTypeByFilename("any-file.html").(*external.Renderer)
|
||||
r, ok := markup.DetectRendererTypeByFilename("any-file.html").(*external.Renderer)
|
||||
require.True(t, ok)
|
||||
defer test.MockVariableValue(&r.RenderContentMode, setting.RenderContentModeIframe)()
|
||||
assert.True(t, r.NeedPostProcess())
|
||||
r = markup.DetectRendererTypeByFilename("any-file.no-sanitizer").(*external.Renderer)
|
||||
r, ok = markup.DetectRendererTypeByFilename("any-file.no-sanitizer").(*external.Renderer)
|
||||
require.True(t, ok)
|
||||
defer test.MockVariableValue(&r.RenderContentMode, setting.RenderContentModeIframe)()
|
||||
assert.False(t, r.NeedPostProcess())
|
||||
|
||||
|
||||
Reference in New Issue
Block a user