mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-13 11:01:01 +00:00
chore: enable forcetypeassert linter, fix issues (#38804)
Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert) linter to prevent unchecked type assertions. ~650 issues fixed, most fixes were clean, some use `setting.PanicInDevOrTesting`. The only behaviour changes are where code would previously send a 500 error or panic, a 4xx error is now emitted. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
@@ -199,8 +199,9 @@ func TestPackageMaven(t *testing.T) {
|
||||
|
||||
pd, err = packages.GetPackageDescriptor(t.Context(), pvs[0])
|
||||
require.NoError(t, err)
|
||||
assert.IsType(t, &maven.Metadata{}, pd.Metadata)
|
||||
assert.Equal(t, packageDescription, pd.Metadata.(*maven.Metadata).Description)
|
||||
metadata, ok := pd.Metadata.(*maven.Metadata)
|
||||
require.True(t, ok)
|
||||
assert.Equal(t, packageDescription, metadata.Description)
|
||||
|
||||
pfs, err := packages.GetFilesByVersionID(t.Context(), pvs[0].ID)
|
||||
require.NoError(t, err)
|
||||
|
||||
Reference in New Issue
Block a user