chore: enable forcetypeassert linter, fix issues (#38804)

Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert)
linter to prevent unchecked type assertions. ~650 issues fixed, most
fixes were clean, some use `setting.PanicInDevOrTesting`.

The only behaviour changes are where code would previously send a 500 error
or panic, a 4xx error is now emitted.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwind
2026-08-09 12:25:06 +02:00
committed by GitHub
parent fac8bf2eca
commit 76a81b24f9
248 changed files with 1110 additions and 995 deletions
+3 -2
View File
@@ -199,8 +199,9 @@ func TestPackageMaven(t *testing.T) {
pd, err = packages.GetPackageDescriptor(t.Context(), pvs[0])
require.NoError(t, err)
assert.IsType(t, &maven.Metadata{}, pd.Metadata)
assert.Equal(t, packageDescription, pd.Metadata.(*maven.Metadata).Description)
metadata, ok := pd.Metadata.(*maven.Metadata)
require.True(t, ok)
assert.Equal(t, packageDescription, metadata.Description)
pfs, err := packages.GetFilesByVersionID(t.Context(), pvs[0].ID)
require.NoError(t, err)