Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-11 17:08:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enable forcetypeassert linter, fix issues (#38804)

Browse Source 
Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert)
linter to prevent unchecked type assertions. ~650 issues fixed, most
fixes were clean, some use `setting.PanicInDevOrTesting`.

The only behaviour changes are where code would previously send a 500 error
or panic, a 4xx error is now emitted.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwind
2026-08-09 12:25:06 +02:00
committed by GitHub
parent fac8bf2eca
commit 76a81b24f9
248 changed files with 1110 additions and 995 deletions
Download Patch File Download Diff File Expand all files Collapse all files
routers/api/v1/shared/project.go
+6 -6
View File
@@ -478,7 +478,7 @@ func CreateProject(ctx *context.APIContext) {
// "$ref": "#/responses/validationError"
scope := projectScopeFromContext(ctx)
form := web.GetForm(ctx).(*api.CreateProjectOption)
form := web.GetForm[*api.CreateProjectOption](ctx)
templateType, err := convert.ProjectTemplateTypeFromString(form.TemplateType)
if err != nil {
@@ -611,7 +611,7 @@ func EditProject(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.EditProjectOption)
form := web.GetForm[*api.EditProjectOption](ctx)
if form.Title != nil && util.IsEmptyString(*form.Title) {
ctx.APIError(http.StatusUnprocessableEntity, "title must not be empty")
return
@@ -951,7 +951,7 @@ func CreateProjectColumn(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.CreateProjectColumnOption)
form := web.GetForm[*api.CreateProjectColumnOption](ctx)
column := &project_model.Column{
Title: form.Title,
Color: form.Color,
@@ -1185,7 +1185,7 @@ func EditProjectColumn(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.EditProjectColumnOption)
form := web.GetForm[*api.EditProjectColumnOption](ctx)
if form.Title != nil {
if util.IsEmptyString(*form.Title) {
ctx.APIError(http.StatusUnprocessableEntity, "title must not be empty")
@@ -1529,7 +1529,7 @@ func MoveProjectColumns(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.MoveProjectColumnsOption)
form := web.GetForm[*api.MoveProjectColumnsOption](ctx)
columns, err := project_model.GetColumns(ctx, project.ID, db.ListOptionsAll)
if err != nil {
ctx.APIErrorInternal(err)
@@ -2097,7 +2097,7 @@ func MoveProjectIssue(ctx *context.APIContext) {
return
}
form := web.GetForm(ctx).(*api.MoveProjectIssueOption)
form := web.GetForm[*api.MoveProjectIssueOption](ctx)
column, err := project_model.GetColumnByIDAndProjectID(ctx, form.ColumnID, project.ID)
if err != nil {
if project_model.IsErrProjectColumnNotExist(err) {
routers/api/v1/shared/runners.go
+1 -1
View File
@@ -131,7 +131,7 @@ func UpdateRunner(ctx *context.APIContext, ownerID, repoID, runnerID int64) {
return
}
form := web.GetForm(ctx).(*api.EditActionRunnerOption)
form := web.GetForm[*api.EditActionRunnerOption](ctx)
if form.Disabled == nil {
ctx.APIError(http.StatusUnprocessableEntity, "[Disabled]: Required")
return