mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-14 13:32:47 +00:00
chore: enable forcetypeassert linter, fix issues (#38804)
Enable [`forcetypeassert`](https://github.com/gostaticanalysis/forcetypeassert) linter to prevent unchecked type assertions. ~650 issues fixed, most fixes were clean, some use `setting.PanicInDevOrTesting`. The only behaviour changes are where code would previously send a 500 error or panic, a 4xx error is now emitted. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
@@ -51,16 +51,16 @@ func AddPullRequestRebaseWithMerge(_ context.Context, x base.EngineMigration) er
|
||||
// Allow the new merge style if all other merge styles are allowed
|
||||
allowMergeRebase := true
|
||||
|
||||
if allowMerge, ok := unit.Config["AllowMerge"]; ok {
|
||||
allowMergeRebase = allowMergeRebase && allowMerge.(bool)
|
||||
if allowMerge, ok := unit.Config["AllowMerge"].(bool); ok {
|
||||
allowMergeRebase = allowMergeRebase && allowMerge
|
||||
}
|
||||
|
||||
if allowRebase, ok := unit.Config["AllowRebase"]; ok {
|
||||
allowMergeRebase = allowMergeRebase && allowRebase.(bool)
|
||||
if allowRebase, ok := unit.Config["AllowRebase"].(bool); ok {
|
||||
allowMergeRebase = allowMergeRebase && allowRebase
|
||||
}
|
||||
|
||||
if allowSquash, ok := unit.Config["AllowSquash"]; ok {
|
||||
allowMergeRebase = allowMergeRebase && allowSquash.(bool)
|
||||
if allowSquash, ok := unit.Config["AllowSquash"].(bool); ok {
|
||||
allowMergeRebase = allowMergeRebase && allowSquash
|
||||
}
|
||||
|
||||
if _, ok := unit.Config["AllowRebaseMerge"]; !ok {
|
||||
|
||||
Reference in New Issue
Block a user