refactor: http request binding (#38971)

Better than before, still not good enough (more work can be done in the
future)

And add the missing error handling in the PrivateContext "bind"
middleware.

By the way, picked some "TrimSpace" changes from "fix: trim whitespace
from SMTP address and port - #38934" (fix #38926)

services/context/context.go

@@ -23,11 +23,10 @@ import (
 	"gitea.dev/modules/templates"
 	"gitea.dev/modules/translation"
 	"gitea.dev/modules/util"
+	"gitea.dev/modules/validation"
 	"gitea.dev/modules/web"
 	"gitea.dev/modules/web/middleware"
 	web_types "gitea.dev/modules/web/types"
-
-	"gitea.com/go-chi/binding"
 )
 
 // Render represents a template render
@@ -83,28 +82,6 @@ func GetWebContext(ctx context.Context) *Context {
 	return webCtx
 }
 
-// GetValidateContext gets a context for middleware form validation
-func GetValidateContext(req *http.Request) (ctx *middleware.ValidateContext) {
-	if ctxAPI, ok := req.Context().Value(apiContextKey).(*APIContext); ok {
-		ctx = &middleware.ValidateContext{
-			Data:   ctxAPI.Data,
-			Locale: ctxAPI.Locale,
-			Req:    ctxAPI.Req,
-			Resp:   ctxAPI.Resp,
-		}
-	} else if ctxWeb, ok := req.Context().Value(WebContextKey).(*Context); ok {
-		ctx = &middleware.ValidateContext{
-			Data:   ctxWeb.Data,
-			Locale: ctxWeb.Locale,
-			Req:    ctxWeb.Req,
-			Resp:   ctxWeb.Resp,
-		}
-	} else {
-		panic("invalid context, expect either APIContext or Context")
-	}
-	return ctx
-}
-
 func NewTemplateContextForWeb(ctx reqctx.RequestContext, req *http.Request, locale translation.Locale) TemplateContext {
 	tmplCtx := NewTemplateContext(ctx, req)
 	tmplCtx["Locale"] = locale
@@ -294,21 +271,16 @@ func (ctx *Context) JSONErrorNotFound(optMsg ...string) {
 	ctx.JSON(http.StatusNotFound, buildJsonErrorMap(msg))
 }
 
-func GetFetchActionForm[T interface {
-	*E
-	middleware.Form
-}, E any](ctx *Context) *E {
+func GetFetchActionForm[T middleware.Form](ctx *Context) (ret T) {
 	if web.IsFormSet(ctx) {
 		panic("don't mix fetch-action form validation with template-based form validation")
 	}
-	form := T(new(E))
-	errs := binding.Bind(ctx.Req, form)
-	errs = form.Validate(GetValidateContext(ctx.Req), errs)
+	form, errs := middleware.BindFormValidate[T](ctx.Req, validation.Binder())
 	errorMessage, fieldName, _ := middleware.BuildValidationErrorForUser(form, ctx.Locale, errs)
 	if errorMessage != "" {
 		ctx.Resp.Header().Set("Content-Type", "application/json")
 		ctx.JSONErrorWithField(errorMessage, fieldName)
-		return nil
+		return ret
 	}
 	return form
 }

services/forms/repo_form.go

@@ -12,10 +12,9 @@ import (
 	"gitea.dev/modules/json"
 	"gitea.dev/modules/structs"
 	"gitea.dev/modules/util"
+	"gitea.dev/modules/validation"
 	"gitea.dev/modules/web/middleware"
 	"gitea.dev/services/webhook"
-
-	"gitea.com/go-chi/binding"
 )
 
 // CreateRepoForm form for creating repository
@@ -263,7 +262,7 @@ type NewSlackHookForm struct {
 	WebhookForm
 }
 
-func (f *NewSlackHookForm) Validate(ctx *middleware.ValidateContext, errs binding.Errors) binding.Errors {
+func (f *NewSlackHookForm) Validate(ctx *middleware.ValidateContext, errs validation.BindingErrors) validation.BindingErrors {
 	if !webhook.IsValidSlackChannel(strings.TrimSpace(f.Channel)) {
 		errs = middleware.AddValidationError(errs, "Channel", ctx.Locale.TrString("repo.settings.add_webhook.invalid_channel_name"))
 	}
@@ -564,7 +563,7 @@ type WikiEditForm struct {
 	Message string
 }
 
-func (f *WikiEditForm) Validate(ctx *middleware.ValidateContext, errs binding.Errors) binding.Errors {
+func (f *WikiEditForm) Validate(ctx *middleware.ValidateContext, errs validation.BindingErrors) validation.BindingErrors {
 	f.Title = strings.TrimSpace(f.Title)
 	if f.Title == "" {
 		errs = middleware.AddValidationError(errs, "title", ctx.Locale.TrString("repo.issues.new.title_empty"))

services/forms/user_form.go

@@ -14,36 +14,34 @@ import (
 	"gitea.dev/modules/util"
 	"gitea.dev/modules/validation"
 	"gitea.dev/modules/web/middleware"
-
-	"gitea.com/go-chi/binding"
 )
 
 // InstallForm form for installation page
 type InstallForm struct {
 	middleware.FormDefaultValidator
-	DbType   string `binding:"Required"`
-	DbHost   string
-	DbUser   string
+	DbType   string `binding:"TrimSpace;Required"`
+	DbHost   string `binding:"TrimSpace"`
+	DbUser   string `binding:"TrimSpace"`
 	DbPasswd string
-	DbName   string
-	SSLMode  string
-	DbPath   string
-	DbSchema string
+	DbName   string `binding:"TrimSpace"`
+	SSLMode  string `binding:"TrimSpace"`
+	DbPath   string `binding:"TrimSpace"`
+	DbSchema string `binding:"TrimSpace"`
 
-	AppName      string `binding:"Required" locale:"install.app_name"`
-	RepoRootPath string `binding:"Required"`
-	LFSRootPath  string
-	RunUser      string `binding:"Required"`
-	Domain       string `binding:"Required"`
+	AppName      string `binding:"TrimSpace;Required" locale:"install.app_name"`
+	RepoRootPath string `binding:"TrimSpace;Required"`
+	LFSRootPath  string `binding:"TrimSpace"`
+	RunUser      string `binding:"TrimSpace;Required"`
+	Domain       string `binding:"TrimSpace;Required"`
 	SSHPort      int
-	HTTPPort     string `binding:"Required"`
-	AppURL       string `binding:"Required"`
-	LogRootPath  string `binding:"Required"`
+	HTTPPort     string `binding:"TrimSpace;Required"`
+	AppURL       string `binding:"TrimSpace;Required"`
+	LogRootPath  string `binding:"TrimSpace;Required"`
 
-	SMTPAddr        string
-	SMTPPort        string
-	SMTPFrom        string
-	SMTPUser        string `binding:"OmitEmpty;MaxSize(254)" locale:"install.mailer_user"`
+	SMTPAddr        string `binding:"TrimSpace"`
+	SMTPPort        string `binding:"TrimSpace"`
+	SMTPFrom        string `binding:"TrimSpace"`
+	SMTPUser        string `binding:"TrimSpace;OmitEmpty;MaxSize(254)" locale:"install.mailer_user"`
 	SMTPPasswd      string
 	RegisterConfirm bool
 	MailNotify      bool
@@ -58,14 +56,14 @@ type InstallForm struct {
 	DefaultAllowCreateOrganization bool
 	DefaultEnableTimetracking      bool
 	EnableUpdateChecker            bool
-	NoReplyAddress                 string
+	NoReplyAddress                 string `binding:"TrimSpace"`
 
-	PasswordAlgorithm string
+	PasswordAlgorithm string `binding:"TrimSpace"`
 
-	AdminName          string `binding:"OmitEmpty;Username;MaxSize(30)" locale:"install.admin_name"`
+	AdminName          string `binding:"TrimSpace;OmitEmpty;Username;MaxSize(30)" locale:"install.admin_name"`
 	AdminPasswd        string `binding:"OmitEmpty;MaxSize(255)" locale:"install.admin_password"`
 	AdminConfirmPasswd string
-	AdminEmail         string `binding:"OmitEmpty;MinSize(3);MaxSize(254);Include(@)" locale:"install.admin_email"`
+	AdminEmail         string `binding:"TrimSpace;OmitEmpty;MinSize(3);MaxSize(254);Include(@)" locale:"install.admin_email"`
 
 	// ReinstallConfirmFirst we can not use 1/2/3 or A/B/C here, there is a framework bug, can not parse "reinstall_confirm_1" or "reinstall_confirm_a"
 	ReinstallConfirmFirst  bool
@@ -275,7 +273,7 @@ func DetectInvalidOAuth2ApplicationRedirectURI(uris []string) (invalidURL string
 	return ""
 }
 
-func (f *EditOAuth2ApplicationForm) Validate(ctx *middleware.ValidateContext, errs binding.Errors) binding.Errors {
+func (f *EditOAuth2ApplicationForm) Validate(ctx *middleware.ValidateContext, errs validation.BindingErrors) validation.BindingErrors {
 	invalidURI := DetectInvalidOAuth2ApplicationRedirectURI(util.SplitTrimSpace(f.RedirectURIs, "\n"))
 	if invalidURI != "" {
 		errs = middleware.AddValidationError(errs, "RedirectURIs", "RedirectURIs: "+ctx.Locale.TrString("form.url_error", `"`+invalidURI+`"`))