diff --git a/routers/api/packages/container/container.go b/routers/api/packages/container/container.go index ea527a9f12f..35817e6ccee 100644 --- a/routers/api/packages/container/container.go +++ b/routers/api/packages/container/container.go @@ -45,7 +45,8 @@ var globalVars = sync.OnceValue(func() (ret struct { imageNamePattern, referencePattern *regexp.Regexp }, ) { - ret.imageNamePattern = regexp.MustCompile(`\A[a-z0-9]+([._-][a-z0-9]+)*(/[a-z0-9]+([._-][a-z0-9]+)*)*\z`) + // ref: https://github.com/opencontainers/distribution-spec/blob/v1.1.1/spec.md#pulling-manifests + ret.imageNamePattern = regexp.MustCompile(`\A[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*\z`) ret.referencePattern = regexp.MustCompile(`\A[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}\z`) return ret }) diff --git a/routers/api/packages/container/container_test.go b/routers/api/packages/container/container_test.go new file mode 100644 index 00000000000..cbf3b504cf8 --- /dev/null +++ b/routers/api/packages/container/container_test.go @@ -0,0 +1,19 @@ +// Copyright 2026 The Gitea Authors. All rights reserved. +// SPDX-License-Identifier: MIT + +package container + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestImageNamePattern(t *testing.T) { + for _, name := range []string{"a", "a.b", "a_b", "a__b", "a-b", "a--b", "a---b", "sub/a__b/c--d"} { + assert.True(t, globalVars().imageNamePattern.MatchString(name), name) + } + for _, name := range []string{"", "A", "a___b", "a._b", "-a", "a-", "a//b", "/a", "a/"} { + assert.False(t, globalVars().imageNamePattern.MatchString(name), name) + } +}