mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-12 22:11:07 +00:00
chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)
Unfortunately, we can't completely remove the ctx from git.Repository, because the CatFileBatch still heavily depends on a parent context. If we remove the Repository ctx, the CatFileBatch will become a mess and create a lot of unnecessary git processes. http://localhost:3000/-/admin/monitor/perftrace * Before: open a repo home, dozens of git processes (duplicate cat-file) * After: only a few (no duplicate cat-file)
This commit is contained in:
@@ -409,7 +409,7 @@ func Test_WebhookPushDevBranch(t *testing.T) {
|
||||
assert.Empty(t, payloads)
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
gitRepo, err := git.OpenRepository(repo1)
|
||||
gitRepo, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
defer gitRepo.Close()
|
||||
|
||||
@@ -460,7 +460,7 @@ func Test_WebhookPushToNewBranch(t *testing.T) {
|
||||
testAPICreateWebhookForRepo(t, session, "user2", "repo1", provider.URL(), "push", "new_branch")
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
gitRepo, err := git.OpenRepository(repo1)
|
||||
gitRepo, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
defer gitRepo.Close()
|
||||
|
||||
@@ -925,7 +925,7 @@ func Test_WebhookStatus(t *testing.T) {
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
|
||||
gitRepo1, err := git.OpenRepository(repo1)
|
||||
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
commitID, err := gitRepo1.GetBranchCommitID(t.Context(), repo1.DefaultBranch)
|
||||
assert.NoError(t, err)
|
||||
@@ -998,7 +998,7 @@ func Test_WebhookWorkflowJob(t *testing.T) {
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
|
||||
gitRepo1, err := git.OpenRepository(repo1)
|
||||
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
|
||||
runner := newMockRunner()
|
||||
@@ -1190,7 +1190,7 @@ func testWorkflowRunEvents(t *testing.T, webhookData *workflowRunWebhook) {
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
|
||||
gitRepo1, err := git.OpenRepository(repo1)
|
||||
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
|
||||
// 2.2 trigger the webhooks
|
||||
@@ -1315,7 +1315,7 @@ func testWorkflowRunEventsOnRerun(t *testing.T, webhookData *workflowRunWebhook)
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
|
||||
gitRepo1, err := git.OpenRepository(repo1)
|
||||
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
|
||||
// 2.2 trigger the webhooks
|
||||
@@ -1485,7 +1485,7 @@ func testWorkflowRunEventsOnCancellingAbandonedRun(t *testing.T, webhookData *wo
|
||||
testAPICreateWebhookForRepo(t, session, "user2", repoName, webhookData.URL, "workflow_run")
|
||||
|
||||
ctx := t.Context()
|
||||
gitRepo, err := git.OpenRepository(testRepo)
|
||||
gitRepo, err := git.OpenRepository(ctx, testRepo)
|
||||
assert.NoError(t, err)
|
||||
|
||||
// 2.2 trigger the webhooks
|
||||
@@ -1703,7 +1703,7 @@ func testWebhookWorkflowRun(t *testing.T, webhookData *workflowRunWebhook) {
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
|
||||
gitRepo1, err := git.OpenRepository(repo1)
|
||||
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
|
||||
runner := newMockRunner()
|
||||
@@ -1804,7 +1804,7 @@ func testWebhookWorkflowRunDepthLimit(t *testing.T, webhookData *workflowRunWebh
|
||||
|
||||
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
|
||||
|
||||
gitRepo1, err := git.OpenRepository(repo1)
|
||||
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
|
||||
assert.NoError(t, err)
|
||||
|
||||
// 2. trigger the webhooks
|
||||
|
||||
Reference in New Issue
Block a user