chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

Unfortunately, we can't completely remove the ctx from git.Repository,
because the CatFileBatch still heavily depends on a parent context.

If we remove the Repository ctx, the CatFileBatch will become a mess and
create a lot of unnecessary git processes.

http://localhost:3000/-/admin/monitor/perftrace

* Before: open a repo home, dozens of git processes (duplicate cat-file)
* After: only a few (no duplicate cat-file)
This commit is contained in:
wxiaoguang
2026-07-29 01:04:22 +08:00
committed by GitHub
parent 5672b1c4cf
commit 4d6e172a0d
121 changed files with 259 additions and 254 deletions
+4 -4
View File
@@ -43,7 +43,7 @@ func TestDataAsyncDoubleRead_Issue29101(t *testing.T) {
sha := resp.Commit.SHA
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
commit, err := gitRepo.GetCommit(t.Context(), sha)
@@ -86,7 +86,7 @@ func TestAgitPullPush(t *testing.T) {
dstPath := t.TempDir()
doGitClone(dstPath, u)(t)
gitRepo, err := git.OpenRepositoryLocal(dstPath)
gitRepo, err := git.OpenRepositoryLocal(t.Context(), dstPath)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -149,7 +149,7 @@ func TestAgitReviewStaleness(t *testing.T) {
dstPath := t.TempDir()
doGitClone(dstPath, u)(t)
gitRepo, err := git.OpenRepositoryLocal(dstPath)
gitRepo, err := git.OpenRepositoryLocal(t.Context(), dstPath)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -218,7 +218,7 @@ func TestAgitReviewStaleness(t *testing.T) {
// For AGit PRs, HeadCommitID must be loaded from git references
baseRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
baseGitRepo, err := git.OpenRepository(baseRepo)
baseGitRepo, err := git.OpenRepository(t.Context(), baseRepo)
assert.NoError(t, err)
defer baseGitRepo.Close()