Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-05 03:10:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: still keep ctx in git.Repository struct for cat-file batch command (#38684)

Browse Source 
Unfortunately, we can't completely remove the ctx from git.Repository,
because the CatFileBatch still heavily depends on a parent context.

If we remove the Repository ctx, the CatFileBatch will become a mess and
create a lot of unnecessary git processes.

http://localhost:3000/-/admin/monitor/perftrace

* Before: open a repo home, dozens of git processes (duplicate cat-file)
* After: only a few (no duplicate cat-file)
This commit is contained in:
wxiaoguang
2026-07-29 01:04:22 +08:00
committed by GitHub
parent 5672b1c4cf
commit 4d6e172a0d
121 changed files with 259 additions and 254 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/actions_trigger_test.go
+13 -13
View File
@@ -477,7 +477,7 @@ jobs:
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranchExisting(t.Context(), repo.ID, repo.DefaultBranch)
@@ -787,8 +787,8 @@ func TestPullRequestReviewCommitStatusEvent(t *testing.T) {
assert.NotEmpty(t, repo)
// add user4 as collaborator so they can review
ctx := NewAPITestContext(t, repo.OwnerName, repo.Name, auth_model.AccessTokenScopeWriteRepository)
t.Run("AddUser4AsCollaboratorWithWriteAccess", doAPIAddCollaborator(ctx, "user4", perm.AccessModeWrite))
apiTestCtx := NewAPITestContext(t, repo.OwnerName, repo.Name, auth_model.AccessTokenScopeWriteRepository)
t.Run("AddUser4AsCollaboratorWithWriteAccess", doAPIAddCollaborator(apiTestCtx, "user4", perm.AccessModeWrite))
// add workflow file that triggers on pull_request_review
addWorkflow, err := files_service.ChangeRepoFiles(t.Context(), repo, user2, &files_service.ChangeRepoFilesOptions{
@@ -829,7 +829,7 @@ jobs:
// create a branch and a PR
testBranch := "test-review-branch"
testCreateBranch(t, ctx.Session, repo.OwnerName, repo.Name, "branch/main", testBranch, http.StatusSeeOther)
testCreateBranch(t, apiTestCtx.Session, repo.OwnerName, repo.Name, "branch/main", testBranch, http.StatusSeeOther)
// add a file on the test branch so the PR has changes
addFileResp, err := files_service.ChangeRepoFiles(t.Context(), repo, user2, &files_service.ChangeRepoFilesOptions{
@@ -881,7 +881,7 @@ jobs:
assert.NoError(t, err)
// submit an approval review as user4
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -961,7 +961,7 @@ jobs:
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranchExisting(t.Context(), repo.ID, repo.DefaultBranch)
@@ -1132,7 +1132,7 @@ jobs:
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranchExisting(t.Context(), repo.ID, repo.DefaultBranch)
@@ -1223,7 +1223,7 @@ jobs:
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranchExisting(t.Context(), repo.ID, repo.DefaultBranch)
@@ -1309,7 +1309,7 @@ jobs:
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranchExisting(t.Context(), repo.ID, repo.DefaultBranch)
@@ -1439,7 +1439,7 @@ jobs:
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the dispatch branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
commit, err := gitRepo.GetBranchCommit(t.Context(), "dispatch")
@@ -1637,7 +1637,7 @@ jobs:
assert.Equal(t, workflows.Workflows[0].State, workflow.State)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranchExisting(t.Context(), repo.ID, repo.DefaultBranch)
@@ -1806,7 +1806,7 @@ jobs:
assert.NoError(t, err)
assert.NotEmpty(t, addWorkflowToBaseResp)
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -1884,7 +1884,7 @@ jobs:
assert.NoError(t, err)
assert.NotEmpty(t, addWorkflowToBaseResp)
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
tests/integration/api_packages_cargo_test.go
+1 -1
View File
@@ -76,7 +76,7 @@ func testPackageCargo(t *testing.T, _ *neturl.URL) {
assert.NoError(t, err)
readGitContent := func(t *testing.T, path string) string {
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
tests/integration/api_pull_review_test.go
+2 -2
View File
@@ -375,7 +375,7 @@ func TestAPIPullReviewCommentResolveEndpoints(t *testing.T) {
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: pullIssue.PosterID})
require.NoError(t, pullIssue.LoadPullRequest(ctx))
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(ctx, repo)
require.NoError(t, err)
defer gitRepo.Close()
@@ -536,7 +536,7 @@ func testAPIPullReviewCommentReply(t *testing.T) {
require.NoError(t, pullIssue.LoadRepo(t.Context()))
require.NoError(t, pullIssue.LoadPullRequest(t.Context()))
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
gitRepo, err := git.OpenRepository(pullIssue.Repo)
gitRepo, err := git.OpenRepository(t.Context(), pullIssue.Repo)
require.NoError(t, err)
defer gitRepo.Close()
tests/integration/api_releases_test.go
+3 -3
View File
@@ -186,7 +186,7 @@ func TestAPICreateAndUpdateRelease(t *testing.T) {
session := loginUser(t, owner.LowerName)
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -237,7 +237,7 @@ func TestAPICreateProtectedTagRelease(t *testing.T) {
session := loginUser(t, writer.LowerName)
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -273,7 +273,7 @@ func TestAPICreateReleaseToDefaultBranchOnExistingTag(t *testing.T) {
session := loginUser(t, owner.LowerName)
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
defer gitRepo.Close()
tests/integration/api_repo_file_create_test.go
+2 -2
View File
@@ -153,7 +153,7 @@ func TestAPICreateFile(t *testing.T) {
req := NewRequestWithJSON(t, "POST", fmt.Sprintf("/api/v1/repos/%s/%s/contents/%s", user2.Name, repo1.Name, treePath), &createFileOptions).
AddTokenAuth(token2)
resp := MakeRequest(t, req, http.StatusCreated)
gitRepo, _ := git.OpenRepository(repo1)
gitRepo, _ := git.OpenRepository(t.Context(), repo1)
defer gitRepo.Close()
commitID, _ := gitRepo.GetBranchCommitID(t.Context(), createFileOptions.NewBranchName)
lastCommit, _ := gitRepo.GetCommitByPath(t.Context(), treePath)
@@ -276,7 +276,7 @@ func TestAPICreateFile(t *testing.T) {
AddTokenAuth(token2)
resp = MakeRequest(t, req, http.StatusCreated)
emptyRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerName: "user2", Name: "empty-repo"}) // public repo
gitRepo, _ := git.OpenRepository(emptyRepo)
gitRepo, _ := git.OpenRepository(t.Context(), emptyRepo)
defer gitRepo.Close()
commitID, _ := gitRepo.GetBranchCommitID(t.Context(), createFileOptions.NewBranchName)
latestCommit, _ := gitRepo.GetCommitByPath(t.Context(), treePath)
tests/integration/api_repo_file_update_test.go
+1 -1
View File
@@ -136,7 +136,7 @@ func TestAPIUpdateFile(t *testing.T) {
req := NewRequestWithJSON(t, "PUT", fmt.Sprintf("/api/v1/repos/%s/%s/contents/%s", user2.Name, repo1.Name, treePath), &updateFileOptions).
AddTokenAuth(token2)
resp := MakeRequest(t, req, http.StatusOK)
gitRepo, _ := git.OpenRepository(repo1)
gitRepo, _ := git.OpenRepository(t.Context(), repo1)
defer gitRepo.Close()
commitID, _ := gitRepo.GetBranchCommitID(t.Context(), updateFileOptions.NewBranchName)
lasCommit, _ := gitRepo.GetCommitByPath(t.Context(), treePath)
tests/integration/api_repo_files_change_test.go
+1 -1
View File
@@ -93,7 +93,7 @@ func TestAPIChangeFiles(t *testing.T) {
req := NewRequestWithJSON(t, "POST", fmt.Sprintf("/api/v1/repos/%s/%s/contents", user2.Name, repo1.Name), &changeFilesOptions).
AddTokenAuth(token2)
resp := MakeRequest(t, req, http.StatusCreated)
gitRepo, _ := git.OpenRepository(repo1)
gitRepo, _ := git.OpenRepository(t.Context(), repo1)
defer gitRepo.Close()
commitID, _ := gitRepo.GetBranchCommitID(t.Context(), changeFilesOptions.NewBranchName)
createLasCommit, _ := gitRepo.GetCommitByPath(t.Context(), createTreePath)
tests/integration/api_repo_files_get_test.go
+1 -1
View File
@@ -42,7 +42,7 @@ func TestAPIGetRequestedFiles(t *testing.T) {
session = loginUser(t, user4.Name)
token4 := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
gitRepo, err := git.OpenRepository(repo1)
gitRepo, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
defer gitRepo.Close()
lastCommit, _ := gitRepo.GetCommitByPath(t.Context(), "README.md")
tests/integration/api_repo_get_contents_list_test.go
+1 -1
View File
@@ -73,7 +73,7 @@ func testAPIGetContentsList(t *testing.T, u *url.URL) {
token4 := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo1)
gitRepo, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
defer gitRepo.Close()
tests/integration/api_repo_get_contents_test.go
+1 -1
View File
@@ -78,7 +78,7 @@ func testAPIGetContents(t *testing.T, _ *url.URL) {
token4 := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository)
// Get the commit ID of the default branch
gitRepo, err := git.OpenRepository(repo1)
gitRepo, err := git.OpenRepository(t.Context(), repo1)
require.NoError(t, err)
defer gitRepo.Close()
tests/integration/api_repo_git_tags_test.go
+1 -1
View File
@@ -31,7 +31,7 @@ func TestAPIGitTags(t *testing.T) {
_ = git.ManagedConfigSet(t.Context(), repo, "user.name", user.Name)
_ = git.ManagedConfigSet(t.Context(), repo, "user.email", user.Email)
gitRepo, _ := git.OpenRepository(repo)
gitRepo, _ := git.OpenRepository(t.Context(), repo)
defer gitRepo.Close()
commit, _ := gitRepo.GetBranchCommit(t.Context(), "master")
tests/integration/compare_test.go
+1 -1
View File
@@ -182,7 +182,7 @@ func TestResolveRefWithSuffixContract(t *testing.T) {
defer tests.PrepareTestEnv(t)()
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 31})
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
require.NoError(t, err)
defer gitRepo.Close()
tests/integration/editor_test.go
+1 -1
View File
@@ -220,7 +220,7 @@ func testEditorWebGitCommitEmail(t *testing.T) {
require.True(t, user.KeepEmailPrivate)
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
gitRepo, _ := git.OpenRepository(repo1)
gitRepo, _ := git.OpenRepository(t.Context(), repo1)
defer gitRepo.Close()
getLastCommit := func(t *testing.T) *git.Commit {
c, err := gitRepo.GetBranchCommit(t.Context(), "master")
tests/integration/git_general_test.go
+1 -1
View File
@@ -811,7 +811,7 @@ func doCreateAgitFlowPull(dstPath string, ctx *APITestContext, headBranch string
return
}
gitRepo, err := git.OpenRepositoryLocal(dstPath)
gitRepo, err := git.OpenRepositoryLocal(t.Context(), dstPath)
require.NoError(t, err)
defer gitRepo.Close()
tests/integration/git_misc_test.go
+4 -4
View File
@@ -43,7 +43,7 @@ func TestDataAsyncDoubleRead_Issue29101(t *testing.T) {
sha := resp.Commit.SHA
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(t.Context(), repo)
assert.NoError(t, err)
commit, err := gitRepo.GetCommit(t.Context(), sha)
@@ -86,7 +86,7 @@ func TestAgitPullPush(t *testing.T) {
dstPath := t.TempDir()
doGitClone(dstPath, u)(t)
gitRepo, err := git.OpenRepositoryLocal(dstPath)
gitRepo, err := git.OpenRepositoryLocal(t.Context(), dstPath)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -149,7 +149,7 @@ func TestAgitReviewStaleness(t *testing.T) {
dstPath := t.TempDir()
doGitClone(dstPath, u)(t)
gitRepo, err := git.OpenRepositoryLocal(dstPath)
gitRepo, err := git.OpenRepositoryLocal(t.Context(), dstPath)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -218,7 +218,7 @@ func TestAgitReviewStaleness(t *testing.T) {
// For AGit PRs, HeadCommitID must be loaded from git references
baseRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
baseGitRepo, err := git.OpenRepository(baseRepo)
baseGitRepo, err := git.OpenRepository(t.Context(), baseRepo)
assert.NoError(t, err)
defer baseGitRepo.Close()
tests/integration/git_push_test.go
+1 -1
View File
@@ -205,7 +205,7 @@ func runTestGitPush(t *testing.T, u *url.URL, gitOperation func(t *testing.T, gi
doGitAddRemote(gitPath, "origin", u)(t)
gitRepo, err := git.OpenRepositoryLocal(gitPath)
gitRepo, err := git.OpenRepositoryLocal(t.Context(), gitPath)
require.NoError(t, err)
defer gitRepo.Close()
tests/integration/migrate_test.go
+1 -1
View File
@@ -336,7 +336,7 @@ func Test_MigrateFromGiteaToGitea(t *testing.T) {
assert.False(t, pr13.HasMerged)
assert.True(t, pr13.Issue.IsLocked)
gitRepo, err := git.OpenRepository(migratedRepo)
gitRepo, err := git.OpenRepository(t.Context(), migratedRepo)
require.NoError(t, err)
defer gitRepo.Close()
tests/integration/mirror_pull_test.go
+1 -1
View File
@@ -67,7 +67,7 @@ func TestMirrorPull(t *testing.T) {
assert.True(t, slices.ContainsFunc(mirrorRepo.Units, func(u *repo_model.RepoUnit) bool { return u.Type == unit.TypeReleases }))
assert.True(t, slices.ContainsFunc(mirrorRepo.Units, func(u *repo_model.RepoUnit) bool { return u.Type == unit.TypeWiki }))
gitRepo, err := git.OpenRepository(repo)
gitRepo, err := git.OpenRepository(ctx, repo)
assert.NoError(t, err)
defer gitRepo.Close()
tests/integration/mirror_push_test.go
+2 -2
View File
@@ -60,14 +60,14 @@ func testMirrorPush(t *testing.T, u *url.URL) {
ok := mirror_service.SyncPushMirror(t.Context(), mirrors[0].ID)
assert.True(t, ok)
srcGitRepo, err := git.OpenRepository(srcRepo)
srcGitRepo, err := git.OpenRepository(t.Context(), srcRepo)
assert.NoError(t, err)
defer srcGitRepo.Close()
srcCommit, err := srcGitRepo.GetBranchCommit(t.Context(), "master")
assert.NoError(t, err)
mirrorGitRepo, err := git.OpenRepository(mirrorRepo)
mirrorGitRepo, err := git.OpenRepository(t.Context(), mirrorRepo)
assert.NoError(t, err)
defer mirrorGitRepo.Close()
tests/integration/pull_merge_test.go
+3 -3
View File
@@ -836,7 +836,7 @@ func TestPullAutoMergeAfterCommitStatusSucceed(t *testing.T) {
assert.Empty(t, pr.MergedCommitID)
// update commit status to success, then it should be merged automatically
baseGitRepo, err := git.OpenRepository(baseRepo)
baseGitRepo, err := git.OpenRepository(t.Context(), baseRepo)
assert.NoError(t, err)
sha, err := baseGitRepo.GetRefCommitID(t.Context(), pr.GetGitHeadRefName())
assert.NoError(t, err)
@@ -908,7 +908,7 @@ func TestPullAutoMergeAfterCommitStatusSucceedAndApproval(t *testing.T) {
assert.Empty(t, pr.MergedCommitID)
// update commit status to success, then it should be merged automatically
baseGitRepo, err := git.OpenRepository(baseRepo)
baseGitRepo, err := git.OpenRepository(t.Context(), baseRepo)
assert.NoError(t, err)
sha, err := baseGitRepo.GetRefCommitID(t.Context(), pr.GetGitHeadRefName())
assert.NoError(t, err)
@@ -1021,7 +1021,7 @@ func TestPullAutoMergeAfterCommitStatusSucceedAndApprovalForAgitFlow(t *testing.
assert.Empty(t, pr.MergedCommitID)
// update commit status to success, then it should be merged automatically
baseGitRepo, err := git.OpenRepository(baseRepo)
baseGitRepo, err := git.OpenRepository(t.Context(), baseRepo)
assert.NoError(t, err)
sha, err := baseGitRepo.GetRefCommitID(t.Context(), pr.GetGitHeadRefName())
assert.NoError(t, err)
tests/integration/pull_review_test.go
+1 -1
View File
@@ -99,7 +99,7 @@ func TestPullView_CodeOwner(t *testing.T) {
// capture the current PR head ref so we can wait for the async
// refs/pull/N/head sync triggered by the next push to complete
baseGitRepo, err := git.OpenRepository(repo)
baseGitRepo, err := git.OpenRepository(t.Context(), repo)
require.NoError(t, err)
defer baseGitRepo.Close()
headRefBefore, err := baseGitRepo.GetRefCommitID(t.Context(), pr.GetGitHeadRefName())
tests/integration/repo_webhook_test.go
+9 -9
View File
@@ -409,7 +409,7 @@ func Test_WebhookPushDevBranch(t *testing.T) {
assert.Empty(t, payloads)
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo, err := git.OpenRepository(repo1)
gitRepo, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -460,7 +460,7 @@ func Test_WebhookPushToNewBranch(t *testing.T) {
testAPICreateWebhookForRepo(t, session, "user2", "repo1", provider.URL(), "push", "new_branch")
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo, err := git.OpenRepository(repo1)
gitRepo, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
defer gitRepo.Close()
@@ -925,7 +925,7 @@ func Test_WebhookStatus(t *testing.T) {
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo1, err := git.OpenRepository(repo1)
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
commitID, err := gitRepo1.GetBranchCommitID(t.Context(), repo1.DefaultBranch)
assert.NoError(t, err)
@@ -998,7 +998,7 @@ func Test_WebhookWorkflowJob(t *testing.T) {
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo1, err := git.OpenRepository(repo1)
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
runner := newMockRunner()
@@ -1190,7 +1190,7 @@ func testWorkflowRunEvents(t *testing.T, webhookData *workflowRunWebhook) {
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo1, err := git.OpenRepository(repo1)
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
// 2.2 trigger the webhooks
@@ -1315,7 +1315,7 @@ func testWorkflowRunEventsOnRerun(t *testing.T, webhookData *workflowRunWebhook)
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo1, err := git.OpenRepository(repo1)
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
// 2.2 trigger the webhooks
@@ -1485,7 +1485,7 @@ func testWorkflowRunEventsOnCancellingAbandonedRun(t *testing.T, webhookData *wo
testAPICreateWebhookForRepo(t, session, "user2", repoName, webhookData.URL, "workflow_run")
ctx := t.Context()
gitRepo, err := git.OpenRepository(testRepo)
gitRepo, err := git.OpenRepository(ctx, testRepo)
assert.NoError(t, err)
// 2.2 trigger the webhooks
@@ -1703,7 +1703,7 @@ func testWebhookWorkflowRun(t *testing.T, webhookData *workflowRunWebhook) {
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo1, err := git.OpenRepository(repo1)
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
runner := newMockRunner()
@@ -1804,7 +1804,7 @@ func testWebhookWorkflowRunDepthLimit(t *testing.T, webhookData *workflowRunWebh
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
gitRepo1, err := git.OpenRepository(repo1)
gitRepo1, err := git.OpenRepository(t.Context(), repo1)
assert.NoError(t, err)
// 2. trigger the webhooks
tests/integration/repofiles_change_test.go
+5 -5
View File
@@ -361,7 +361,7 @@ func TestChangeRepoFilesForCreate(t *testing.T) {
// asserts
assert.NoError(t, err)
gitRepo, _ := git.OpenRepository(repo)
gitRepo, _ := git.OpenRepository(ctx, repo)
defer gitRepo.Close()
commitID, _ := gitRepo.GetBranchCommitID(t.Context(), opts.NewBranch)
@@ -398,7 +398,7 @@ func TestChangeRepoFilesForUpdate(t *testing.T) {
// asserts
assert.NoError(t, err)
gitRepo, _ := git.OpenRepository(repo)
gitRepo, _ := git.OpenRepository(ctx, repo)
defer gitRepo.Close()
commit, _ := gitRepo.GetBranchCommit(t.Context(), opts.NewBranch)
@@ -434,7 +434,7 @@ func TestChangeRepoFilesForUpdateWithFileMove(t *testing.T) {
// asserts
assert.NoError(t, err)
gitRepo, _ := git.OpenRepository(repo)
gitRepo, _ := git.OpenRepository(ctx, repo)
defer gitRepo.Close()
commit, _ := gitRepo.GetBranchCommit(t.Context(), opts.NewBranch)
@@ -480,7 +480,7 @@ func TestChangeRepoFilesForUpdateWithFileRename(t *testing.T) {
// asserts
assert.NoError(t, err)
gitRepo, _ := git.OpenRepository(repo)
gitRepo, _ := git.OpenRepository(ctx, repo)
defer gitRepo.Close()
commit, _ := gitRepo.GetBranchCommit(t.Context(), repo.DefaultBranch)
@@ -517,7 +517,7 @@ func TestChangeRepoFilesWithoutBranchNames(t *testing.T) {
// asserts
assert.NoError(t, err)
gitRepo, _ := git.OpenRepository(repo)
gitRepo, _ := git.OpenRepository(ctx, repo)
defer gitRepo.Close()
commit, _ := gitRepo.GetBranchCommit(t.Context(), repo.DefaultBranch)