chore: various UI problems (#38263)

1. fix dirty "list" styles for "githooks" and "webhooks"
2. fix git hook edit page layout
3. fix codemirror editor styles
4. fix incorrect "ui attached header" width
This commit is contained in:
wxiaoguang
2026-06-29 21:06:25 +08:00
committed by GitHub
parent 07b18467c0
commit 4ce63a1d57
10 changed files with 38 additions and 71 deletions
+10 -10
View File
@@ -8,19 +8,19 @@
</div>
</h4>
<div class="ui attached segment">
<p>{{ctx.Locale.Tr "repo.settings.githook_edit_desc"}}</p>
{{ctx.Locale.Tr "repo.settings.githook_edit_desc"}}
</div>
<div class="ui attached fitted segment">
{{with .Hook}}
<div class="field">
<textarea id="content" name="content" class="tw-hidden"
data-code-editor-config="{{JsonUtils.EncodeToString $.CodeEditorConfig}}"
placeholder="{{ctx.Locale.Tr "editor.code_editor.placeholder"}}">{{if .IsActive}}{{.Content}}{{else}}{{.Sample}}{{end}}</textarea>
<div class="editor-loading is-loading"></div>
</div>
<div class="inline field">
<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_githook"}}</button>
</div>
<textarea id="content" name="content" class="tw-hidden"
data-code-editor-config="{{JsonUtils.EncodeToString $.CodeEditorConfig}}"
placeholder="{{ctx.Locale.Tr "editor.code_editor.placeholder"}}">{{if .IsActive}}{{.Content}}{{else}}{{.Sample}}{{end}}</textarea>
<div class="editor-loading is-loading"></div>
{{end}}
</div>
<div class="ui attached segment">
<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.update_githook"}}</button>
</div>
</form>
</div>
{{template "repo/settings/layout_footer" .}}
+5 -4
View File
@@ -4,13 +4,14 @@
{{ctx.Locale.Tr "repo.settings.githooks"}}
</h4>
<div class="ui attached segment">
<div class="ui list flex-items-block">
<div class="item"><span>{{ctx.Locale.Tr "repo.settings.githooks_desc"}}</span></div>
<div>{{ctx.Locale.Tr "repo.settings.githooks_desc"}}</div>
{{if .Hooks}}<div class="divider"></div>{{end}}
<div class="flex-divided-list">
{{range .Hooks}}
<div class="item">
<div class="item flex-text-block">
<span class="{{if .IsActive}}tw-text-green{{else}}tw-text-text-light{{end}}">{{svg "octicon-dot-fill" 22}}</span>
<span class="gt-ellipsis tw-flex-1">{{.Name}}</span>
<a class="muted tw-p-2" href="{{$.RepoLink}}/settings/hooks/git/{{.Name|PathEscape}}">{{svg "octicon-pencil"}}</a>
<a class="muted tw-pr-2" href="{{$.RepoLink}}/settings/hooks/git/{{.Name|PathEscape}}">{{svg "octicon-pencil"}}</a>
</div>
{{end}}
</div>
@@ -8,17 +8,18 @@
</div>
</h4>
<div class="ui attached segment">
<div class="ui list flex-items-block">
<div class="item"><span>{{.Description}}</span></div>
<div>{{.Description}}</div>
{{if .Webhooks}}<div class="divider"></div>{{end}}
<div class="flex-divided-list">
{{range .Webhooks}}
<div class="item">
<div class="item flex-text-block">
<span class="{{if eq .LastStatus 1}}tw-text-green{{else if eq .LastStatus 2}}tw-text-red{{else}}tw-text-text-light{{end}}">{{svg "octicon-dot-fill" 22}}</span>
<div class="gt-ellipsis tw-flex-1">
<a title="{{.URL}}" href="{{$.BaseLink}}/{{.ID}}">{{or .Name (ctx.Locale.Tr "repo.settings.webhook.name_empty")}}</a>
<span class="tw-ml-2 tw-text-grey-light">{{.URL}}</span>
</div>
<a class="muted tw-p-2" href="{{$.BaseLink}}/{{.ID}}">{{svg "octicon-pencil"}}</a>
<a class="tw-text-red tw-p-2 link-action"
<a class="muted" href="{{$.BaseLink}}/{{.ID}}">{{svg "octicon-pencil"}}</a>
<a class="tw-text-red tw-pr-2 link-action"
data-url="{{$.Link}}/delete?id={{.ID}}"
data-modal-confirm="{{ctx.Locale.Tr "repo.settings.webhook_deletion_desc"}}"
>{{svg "octicon-trash"}}</a>
+2 -2
View File
@@ -14,7 +14,7 @@
{{end}}
</h4>
<div class="ui attached segment">
<div class="ui list">
<div class="flex-divided-list">
{{range .History}}
<div class="item">
<div class="flex-left-right">
@@ -32,7 +32,7 @@
{{DateUtils.TimeSince .Delivered}}
</span>
</div>
<div class="info tw-hidden" id="info-{{.ID}}">
<div class="info tw-hidden tw-mt-2" id="info-{{.ID}}">
<div class="ui top attached tabular menu" data-global-init="initTabSwitcher">
<a class="item active" data-tab="request-{{.ID}}">
{{template "shared/misc/tabtitle" (ctx.Locale.Tr "repo.settings.webhook.request")}}