Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-26 12:33:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(auth): record last sign-in on reverse proxy login (#38672)

Browse Source 
Reverse proxy and SSPI logins establish a session but never recorded
`last_login_unix`, so those users stayed "Never Signed-In" in admin.

The write is folded into the language update that `handleSignIn` already
does, so it stays at one query and only runs when a session is
established.

Fixes https://github.com/go-gitea/gitea/issues/7836

---------

Co-authored-by: roman s <roman.sukach@dust-labs.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
roman.s
2026-08-23 11:39:44 +03:00
committed by GitHub
parent 1c16f04bf5
commit 4852091e85
4 changed files with 51 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/auth/auth.go
+8 -10
View File
@@ -38,8 +38,9 @@ func Init() {
webauthn.Init()
}
// handleSignIn clears existing session variables and stores new ones for the specified user object
func handleSignIn(resp http.ResponseWriter, req *http.Request, sess SessionStore, user *user_model.User) {
// handleSignInNonInteractive clears existing session variables and stores new ones for the specified user object
// it is mainly for middleware sign-in which doesn't need user's interaction.
func handleSignInNonInteractive(resp http.ResponseWriter, req *http.Request, sess SessionStore, user *user_model.User) {
// We need to regenerate the session...
newSess, err := session.RegenerateSession(resp, req)
if err != nil {
@@ -54,17 +55,14 @@ func handleSignIn(resp http.ResponseWriter, req *http.Request, sess SessionStore
log.Error(fmt.Sprintf("Error setting session: %v", err))
}
opts := &user_service.UpdateOptions{SetLastLogin: true}
// Language setting of the user overwrites the one previously set
// If the user does not have a locale set, we save the current one.
if len(user.Language) == 0 {
lc := middleware.Locale(resp, req)
opts := &user_service.UpdateOptions{
Language: optional.Some(lc.Language()),
}
if err := user_service.UpdateUser(req.Context(), user, opts); err != nil {
log.Error(fmt.Sprintf("Error updating user language [user: %d, locale: %s]", user.ID, user.Language))
return
}
opts.Language = optional.Some(middleware.Locale(resp, req).Language())
}
if err := user_service.UpdateUser(req.Context(), user, opts); err != nil {
log.Error("Error updating user on sign-in [user: %d]: %v", user.ID, err)
}
middleware.SetLocaleCookie(resp, user.Language, 0)