Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-29 02:04:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(actions): keep step-level continue-on-error expressions unevaluated (#39141)

Browse Source 
Signed-off-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
bircni
2026-08-27 07:46:46 +02:00
committed by GitHub
parent 2c6dacb015
commit 3b6ce586a7
2 changed files with 66 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/actions/jobparser/model.go
+24 -11
View File
@@ -7,6 +7,7 @@ import (
"bytes"
"errors"
"fmt"
"strings"
"gitea.dev/actionslib/pkg/expreval"
"gitea.dev/actionslib/pkg/exprparser"
@@ -175,17 +176,29 @@ func (j *Job) RunsOn() []string {
}
type Step struct {
ID string `yaml:"id,omitempty"`
If yaml.Node `yaml:"if,omitempty"`
Name string `yaml:"name,omitempty"`
Uses string `yaml:"uses,omitempty"`
Run string `yaml:"run,omitempty"`
WorkingDirectory string `yaml:"working-directory,omitempty"`
Shell string `yaml:"shell,omitempty"`
Env yaml.Node `yaml:"env,omitempty"`
With map[string]string `yaml:"with,omitempty"`
ContinueOnError bool `yaml:"continue-on-error,omitempty"`
TimeoutMinutes string `yaml:"timeout-minutes,omitempty"`
ID string `yaml:"id,omitempty"`
If yaml.Node `yaml:"if,omitempty"`
Name string `yaml:"name,omitempty"`
Uses string `yaml:"uses,omitempty"`
Run string `yaml:"run,omitempty"`
WorkingDirectory string `yaml:"working-directory,omitempty"`
Shell string `yaml:"shell,omitempty"`
Env yaml.Node `yaml:"env,omitempty"`
With map[string]string `yaml:"with,omitempty"`
RawContinueOnError yaml.Node `yaml:"continue-on-error,omitempty"` // raw: the runner evaluates it with the steps context
TimeoutMinutes string `yaml:"timeout-minutes,omitempty"`
}
// UnmarshalYAML canonicalizes booleans like continue-on-error
func (s *Step) UnmarshalYAML(node *yaml.Node) error {
type rawStep Step
if err := node.Decode((*rawStep)(s)); err != nil {
return err
}
if raw := &s.RawContinueOnError; raw.Tag == "!!bool" {
raw.Value = strings.ToLower(raw.Value)
}
return nil
}
// String gets the name of step