Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-01 10:40:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fix legacy problems in cmd/serv.go (#38505)

Browse Source 
1. use var names "reqOwnerName, reqRepoName", because these values are
from request and should not be really used for path construction
2. simplify enable-pprof logic, don't "log.Fatal"
3. don't make runServe command to guess the repo storage path, instead,
let server return RepoStoragePath
4. don't process lfs verbs when the repo is a wiki
5. construct the request URI path correctly for the lfs transfer backend
(moved to the caller)
6. don't call "owner, err := user_model.GetUserByName", the "owner
rename redirection" has been done before
7. fix incorrect "repo.OwnerName = ownerName", the real owner might have
been "redirected"
8. fix incorrect "inactive owner" check, it should be checked even if
the repo is redirected


Use general error functions to handle responses, error handling code is
hugely simplified.
This commit is contained in:
wxiaoguang
2026-07-17 22:28:59 +08:00
committed by GitHub
parent 5b078f72aa
commit 3027794c44
13 changed files with 158 additions and 259 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/pprof/pprof.go
+16 -9
View File
@@ -6,15 +6,15 @@ package pprof
import (
"fmt"
"os"
"path/filepath"
"runtime"
"runtime/pprof"
"gitea.dev/modules/log"
)
// DumpMemProfileForUsername dumps a memory profile at pprofDataPath as memprofile_<username>_<temporary id>
func DumpMemProfileForUsername(pprofDataPath, username string) error {
f, err := os.CreateTemp(pprofDataPath, fmt.Sprintf("memprofile_%s_", username))
func dumpMemProfileForUsername(pprofDataPath, subName string) error {
f, err := os.CreateTemp(pprofDataPath, fmt.Sprintf("pprof_mem_%s_", filepath.Clean(subName)))
if err != nil {
return err
}
@@ -23,23 +23,30 @@ func DumpMemProfileForUsername(pprofDataPath, username string) error {
return pprof.WriteHeapProfile(f)
}
// DumpCPUProfileForUsername dumps a CPU profile at pprofDataPath as cpuprofile_<username>_<temporary id>
// the stop function it returns stops, writes and closes the CPU profile file
func DumpCPUProfileForUsername(pprofDataPath, username string) (func(), error) {
f, err := os.CreateTemp(pprofDataPath, fmt.Sprintf("cpuprofile_%s_", username))
func DumpPprofForUsername(pprofDataPath, subName string) (func(), error) {
if err := os.MkdirAll(pprofDataPath, os.ModePerm); err != nil {
return nil, fmt.Errorf(`os.MkdirAll(pprofDataPath) failed: %v`, err)
}
f, err := os.CreateTemp(pprofDataPath, fmt.Sprintf("pprof_cpu_%s_", filepath.Clean(subName)))
if err != nil {
return nil, err
}
err = pprof.StartCPUProfile(f)
if err != nil {
log.Fatal("StartCPUProfile: %v", err)
_ = f.Close()
return nil, fmt.Errorf("StartCPUProfile: %w", err)
}
return func() {
pprof.StopCPUProfile()
err = f.Close()
if err != nil {
log.Fatal("StopCPUProfile Close: %v", err)
log.Error("StopCPUProfile Close: %v", err)
}
err = dumpMemProfileForUsername(pprofDataPath, subName)
if err != nil {
log.Error("DumpMemProfile: %v", err)
}
}, nil
}