fix(db): make paginated database reads always require "order" option (#39017)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

models/user/badge.go

@@ -245,7 +245,7 @@ func (opts *SearchBadgeOptions) ToConds() builder.Cond {
 }
 
 func (opts *SearchBadgeOptions) ToOrders() string {
-	return opts.OrderBy.String()
+	return util.IfZero(opts.OrderBy.String(), "id")
 }
 
 // SearchBadges returns badges based on the provided SearchBadgeOptions options

models/user/block.go

@@ -66,6 +66,10 @@ type FindBlockingOptions struct {
 	BlockeeID int64
 }
 
+func (opts *FindBlockingOptions) ToOrders() string {
+	return "id"
+}
+
 func (opts *FindBlockingOptions) ToConds() builder.Cond {
 	cond := builder.NewCond()
 	if opts.BlockerID != 0 {

models/user/external_login_user.go

@@ -208,9 +208,5 @@ func (opts FindExternalUserOptions) ToConds() builder.Cond {
 }
 
 func (opts FindExternalUserOptions) ToOrders() string {
-	return opts.OrderBy
-}
-
-func IterateExternalLogin(ctx context.Context, opts FindExternalUserOptions, f func(ctx context.Context, u *ExternalLoginUser) error) error {
-	return db.Iterate(ctx, opts.ToConds(), f)
+	return util.IfZero(opts.OrderBy, "external_id")
 }

models/user/search.go

@@ -58,6 +58,10 @@ type SearchUserOptions struct {
 	IncludeReserved    bool
 }
 
+func (opts *SearchUserOptions) ToOrders() string {
+	return "id"
+}
+
 func (opts *SearchUserOptions) ApplyPublicOnly(publicOnly bool) {
 	if publicOnly {
 		opts.Visible = []structs.VisibleType{structs.VisibleTypePublic}