Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-10 02:53:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: js string split (#38233)

Browse Source 
fix #38229
This commit is contained in:
wxiaoguang
2026-06-27 20:09:01 +08:00
committed by GitHub
parent b565f3e00a
commit 16c3216dc6
4 changed files with 60 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/admin_config_test.go
+40 -17
View File
@@ -21,29 +21,52 @@ func TestAdminConfig(t *testing.T) {
defer tests.PrepareTestEnv(t)()
session := loginUser(t, "user1")
req := NewRequest(t, "GET", "/-/admin/config")
resp := session.MakeRequest(t, req, http.StatusOK)
assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
t.Run("ConfigPage", func(t *testing.T) {
req := NewRequest(t, "GET", "/-/admin/config")
resp := session.MakeRequest(t, req, http.StatusOK)
assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
})
t.Run("OpenEditorWithApps", func(t *testing.T) {
cfg := setting.Config().Repository.OpenWithEditorApps
editorApps := cfg.Value(t.Context())
assert.Len(t, editorApps, 3)
assert.False(t, cfg.HasValue(t.Context()))
require.NoError(t, system.SetSettings(t.Context(), map[string]string{cfg.DynKey(): "[]"}))
config.GetDynGetter().InvalidateCache()
t.Run("Default", func(t *testing.T) {
editorApps := cfg.Value(t.Context())
assert.Len(t, editorApps, 3)
assert.False(t, cfg.HasValue(t.Context()))
})
editorApps = cfg.Value(t.Context())
assert.Len(t, editorApps, 3)
assert.False(t, cfg.HasValue(t.Context()))
t.Run("EmptyAsDefault", func(t *testing.T) {
require.NoError(t, system.SetSettings(t.Context(), map[string]string{cfg.DynKey(): "[]"}))
config.GetDynGetter().InvalidateCache()
require.NoError(t, system.SetSettings(t.Context(), map[string]string{cfg.DynKey(): "[{}]"}))
config.GetDynGetter().InvalidateCache()
editorApps := cfg.Value(t.Context())
assert.Len(t, editorApps, 3)
assert.False(t, cfg.HasValue(t.Context()))
})
editorApps = cfg.Value(t.Context())
assert.Len(t, editorApps, 1)
assert.True(t, cfg.HasValue(t.Context()))
t.Run("SingleItem", func(t *testing.T) {
require.NoError(t, system.SetSettings(t.Context(), map[string]string{cfg.DynKey(): "[{}]"}))
config.GetDynGetter().InvalidateCache()
editorApps := cfg.Value(t.Context())
assert.Len(t, editorApps, 1)
assert.True(t, cfg.HasValue(t.Context()))
})
t.Run("ManualSet", func(t *testing.T) {
req := NewRequestWithValues(t, "POST", "/-/admin/config", map[string]string{
"key": "repository.open-with.editor-apps",
"value": `[{"DisplayName":"app-name","OpenURL":"my-app:?u={url}"}]`,
})
session.MakeRequest(t, req, http.StatusOK)
editorApps := cfg.Value(t.Context())
assert.Len(t, editorApps, 1)
assert.Equal(t, "app-name", editorApps[0].DisplayName)
assert.Equal(t, "my-app:?u={url}", editorApps[0].OpenURL)
assert.True(t, cfg.HasValue(t.Context()))
})
})
t.Run("InstanceWebBanner", func(t *testing.T) {
@@ -51,7 +74,7 @@ func TestAdminConfig(t *testing.T) {
assert.False(t, has)
assert.Equal(t, setting.WebBannerType{}, banner)
req = NewRequestWithValues(t, "POST", "/-/admin/config", map[string]string{
req := NewRequestWithValues(t, "POST", "/-/admin/config", map[string]string{
"key": "instance.web_banner",
"value": `{"DisplayEnabled":true,"ContentMessage":"test-msg","StartTimeUnix":123,"EndTimeUnix":456}`,
})