From 1680ac24e65cc066d1ac5f122a6f160fa506c7ff Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 25 Aug 2026 18:36:45 +0200 Subject: [PATCH] chore: anchor golangci exclusion paths to directories (#39116) Co-authored-by: Claude (Opus 5) --- .golangci.yml | 16 ++++++++-------- modules/public/public.go | 2 +- modules/public/public_bindata.go | 4 ++-- modules/public/public_test.go | 2 +- modules/public/vitedev.go | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 038b4c93b25..42cdfa70a02 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -165,10 +165,10 @@ linters: - gocritic text: '(?i)exitAfterDefer:' paths: - - node_modules - - .venv - - public - - web_src + - ^node_modules/ + - ^\.venv/ + - ^public/ + - ^web_src/ issues: max-issues-per-linter: 0 max-same-issues: 0 @@ -190,10 +190,10 @@ formatters: exclusions: generated: lax paths: - - node_modules - - .venv - - public - - web_src + - ^node_modules/ + - ^\.venv/ + - ^public/ + - ^web_src/ run: timeout: 10m diff --git a/modules/public/public.go b/modules/public/public.go index c6fb9eb5c2b..60eb3a293ff 100644 --- a/modules/public/public.go +++ b/modules/public/public.go @@ -43,7 +43,7 @@ func AssetsCors() func(next http.Handler) http.Handler { func FileHandlerFunc() http.HandlerFunc { assetFS := AssetFS() return func(resp http.ResponseWriter, req *http.Request) { - if req.Method != "GET" && req.Method != "HEAD" { + if req.Method != http.MethodGet && req.Method != http.MethodHead { resp.WriteHeader(http.StatusMethodNotAllowed) return } diff --git a/modules/public/public_bindata.go b/modules/public/public_bindata.go index 165b6e4a6cc..551cd3db5fb 100644 --- a/modules/public/public_bindata.go +++ b/modules/public/public_bindata.go @@ -10,9 +10,9 @@ package public import ( "sync" - _ "embed" - "gitea.dev/modules/assetfs" + + _ "embed" ) //go:embed bindata.dat diff --git a/modules/public/public_test.go b/modules/public/public_test.go index f2e0bd074d1..cbac65d3e60 100644 --- a/modules/public/public_test.go +++ b/modules/public/public_test.go @@ -28,7 +28,7 @@ func TestParseAcceptEncoding(t *testing.T) { for _, kase := range kases { t.Run(kase.Header, func(t *testing.T) { - assert.EqualValues(t, kase.Expected, parseAcceptEncoding(kase.Header)) + assert.Equal(t, kase.Expected, parseAcceptEncoding(kase.Header)) }) } } diff --git a/modules/public/vitedev.go b/modules/public/vitedev.go index bf35f1bf8e7..4f7e23884ee 100644 --- a/modules/public/vitedev.go +++ b/modules/public/vitedev.go @@ -115,7 +115,7 @@ func IsViteDevMode() bool { now := time.Now() lastCheck := viteDevModeCheck.Load() - if lastCheck != nil && time.Now().Sub(lastCheck.time) < time.Second { + if lastCheck != nil && now.Sub(lastCheck.time) < time.Second { return lastCheck.isDev }