Gitea-John71/Gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-23 21:10:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

enhance: add permalinks to pull request reviews (#38849) (#39036)

Browse Source 
Backport #38849 by @silverwind

1. Make review threads linkable via `#pullrequestreview-<reviewID>`
2. Improve CSS so username and timestamp go colored on hover.
3. CSS cleanup, remove dead rules, nonexistant class name, make
`.suppressed` actually do what it says in the doc above.

<img width="351" height="84" alt="image"
src="https://github.com/user-attachments/assets/6ddf15d4-3d6e-4846-ab82-0ad0b19b372f"
/>

Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
Giteabot
2026-08-22 00:48:11 -07:00
committed by GitHub
parent f64ee9d1ed
commit 1350cf8a38
10 changed files with 45 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
templates/repo/issue/sidebar/stopwatch_timetracker.tmpl
+1 -1
View File
@@ -72,7 +72,7 @@
{{range $user, $trackedtime := .WorkingUsers}}
<div class="item tw-gap-3">
{{template "shared/user/avatarlink" dict "user" $user}}
<div>
<div class="muted-links">
{{template "shared/user/authorlink" $user}}
<div class="text">{{$trackedtime|Sec2Hour}}</div>
</div>
templates/repo/issue/view_content/comments.tmpl
+8 -6
View File
@@ -361,9 +361,10 @@
</div>
{{else if eq .Type 22}}
<div class="timeline-item-group" id="{{.HashTag}}">
<div class="timeline-item event">
{{$reviewType := 2}}{{/* default to "comment" type if the review record is missing */}}
{{if .Review}}{{$reviewType = .Review.Type}}{{end}}
{{/* default to the "comment" type and the comment anchor if the review record is missing */}}
{{$reviewType := 2}}{{$reviewHashTag := .HashTag}}
{{if .Review}}{{$reviewType = .Review.Type}}{{$reviewHashTag = .Review.HashTag}}{{end}}
<div class="timeline-item event"{{if .Review}} id="{{$reviewHashTag}}"{{end}}>
{{if not .OriginalAuthor}}
{{/* Some timeline avatars need a offset to correctly align with their speech bubble.
The condition depends on whether the comment has contents/attachments,
@@ -381,12 +382,13 @@
</span>
<span class="comment-text-line">
{{template "repo/issue/view_content/comments_authorlink" dict "comment" .}}
{{$createdLink := HTMLFormat `<a href="#%s">%s</a>` $reviewHashTag $createdStr}}
{{if eq $reviewType 1}}
{{ctx.Locale.Tr "repo.issues.review.approve" $createdStr}}
{{ctx.Locale.Tr "repo.issues.review.approve" $createdLink}}
{{else if eq $reviewType 3}}
{{ctx.Locale.Tr "repo.issues.review.reject" $createdStr}}
{{ctx.Locale.Tr "repo.issues.review.reject" $createdLink}}
{{else}}
{{ctx.Locale.Tr "repo.issues.review.comment" $createdStr}}
{{ctx.Locale.Tr "repo.issues.review.comment" $createdLink}}
{{end}}
{{if and .Review .Review.Dismissed}}
<div class="ui small label">{{ctx.Locale.Tr "repo.issues.review.dismissed_label"}}</div>
templates/shared/secrets/add_list.tmpl
+1 -1
View File
@@ -34,7 +34,7 @@
</div>
</div>
<div class="item-trailing">
<span class="color-text-light-2">
<span>
{{ctx.Locale.Tr "settings.added_on" (DateUtils.AbsoluteShort .CreatedUnix)}}
</span>
<button class="btn interact-bg show-modal tw-p-2"
templates/shared/user/authorlink.tmpl
+1 -1
View File
@@ -1 +1 @@
<a class="muted tw-text-text tw-font-semibold"{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>{{.GetDisplayName}}</a>{{if .IsTypeBot}}&nbsp;<span class="ui basic label tw-p-1 tw-align-baseline">bot</span>{{end}}
<a class="tw-font-semibold"{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>{{.GetDisplayName}}</a>{{if .IsTypeBot}}&nbsp;<span class="ui basic label tw-p-1 tw-align-baseline">bot</span>{{end}}
templates/shared/variables/variable_list.tmpl
+1 -1
View File
@@ -33,7 +33,7 @@
</div>
</div>
<div class="item-trailing">
<span class="color-text-light-2">
<span>
{{ctx.Locale.Tr "settings.added_on" (DateUtils.AbsoluteShort .CreatedUnix)}}
</span>
<button class="btn interact-bg tw-p-2 show-modal"